[sailus-media-tree:metadata 90/113] drivers/media/v4l2-core/v4l2-subdev.c:2675 v4l2_subdev_get_frame_desc() warn: was && intended here instead of ||?

[sailus-media-tree:metadata 90/113] drivers/media/v4l2-core/v4l2-subdev.c:2675 v4l2_subdev_get_frame_desc() warn: was && intended here instead of ||?

[Dan Carpenter]

tree:   git://linuxtv.org/sailus/media_tree.git metadata
head:   55ba38aaeb6e07cbbbe550578fa4737b05de1d00
commit: 50fcff1c16cac7152a1b5b56a71656e97d276857 [90/113] media: v4l2-subdev: Introduce v4l2_subdev_get_frame_desc()
config: x86_64-randconfig-161-20260119 (https://download.01.org/0day-ci/archive/20260120/202601200147.SRFr3GE9-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch version: v0.5.0-8985-g2614ff1a

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202601200147.SRFr3GE9-lkp@intel.com/

smatch warnings:
drivers/media/v4l2-core/v4l2-subdev.c:2675 v4l2_subdev_get_frame_desc() warn: was && intended here instead of ||?

vim +2675 drivers/media/v4l2-core/v4l2-subdev.c

50fcff1c16cac7 Sakari Ailus 2025-12-04  2660  int v4l2_subdev_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
50fcff1c16cac7 Sakari Ailus 2025-12-04  2661  			       struct v4l2_mbus_frame_desc *desc)
50fcff1c16cac7 Sakari Ailus 2025-12-04  2662  {
50fcff1c16cac7 Sakari Ailus 2025-12-04  2663  	if (v4l2_subdev_has_op(sd, pad, get_frame_desc)) {
50fcff1c16cac7 Sakari Ailus 2025-12-04  2664  		unsigned int type = desc->type;
50fcff1c16cac7 Sakari Ailus 2025-12-04  2665  		int ret;
50fcff1c16cac7 Sakari Ailus 2025-12-04  2666  
50fcff1c16cac7 Sakari Ailus 2025-12-04  2667  		ret = v4l2_subdev_call(sd, pad, get_frame_desc, pad, desc);
50fcff1c16cac7 Sakari Ailus 2025-12-04  2668  
50fcff1c16cac7 Sakari Ailus 2025-12-04  2669  		if (desc->type != type)
50fcff1c16cac7 Sakari Ailus 2025-12-04  2670  			return -EINVAL;
50fcff1c16cac7 Sakari Ailus 2025-12-04  2671  
50fcff1c16cac7 Sakari Ailus 2025-12-04  2672  		return ret;
50fcff1c16cac7 Sakari Ailus 2025-12-04  2673  	}
50fcff1c16cac7 Sakari Ailus 2025-12-04  2674  
50fcff1c16cac7 Sakari Ailus 2025-12-04 @2675  	if (desc->type != V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL ||

The zero day bot chopped the other side of the or statement off.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki