public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org
Subject: [sailus-media-tree:metadata 109/113] drivers/media/pci/intel/ipu6/ipu6-isys-queue.c:541:14: warning: variable 'first' set but not used
Date: Tue, 20 Jan 2026 01:56:11 +0800	[thread overview]
Message-ID: <202601200156.XCbBK9ms-lkp@intel.com> (raw)

tree:   git://linuxtv.org/sailus/media_tree.git metadata
head:   55ba38aaeb6e07cbbbe550578fa4737b05de1d00
commit: 45316ce8af169db8834efe3f2bd997e28772c2df [109/113] media: ipu6: Bridge the gap between streams in V4L2 and IPU6 firmware
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20260120/202601200156.XCbBK9ms-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260120/202601200156.XCbBK9ms-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601200156.XCbBK9ms-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/pci/intel/ipu6/ipu6-isys-queue.c: In function 'start_streaming':
>> drivers/media/pci/intel/ipu6/ipu6-isys-queue.c:541:14: warning: variable 'first' set but not used [-Wunused-but-set-variable]
     541 |         bool first;
         |              ^~~~~


vim +/first +541 drivers/media/pci/intel/ipu6/ipu6-isys-queue.c

3c1dfb5a69cf83 Bingbu Cao   2024-01-31  532  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  533  static int start_streaming(struct vb2_queue *q, unsigned int count)
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  534  {
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  535  	struct ipu6_isys_queue *aq = vb2_queue_to_isys_queue(q);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  536  	struct ipu6_isys_video *av = ipu6_isys_queue_to_video(aq);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  537  	struct device *dev = &av->isys->adev->auxdev.dev;
d3bd039cd2a009 Bingbu Cao   2024-01-31  538  	const struct ipu6_isys_pixelformat *pfmt =
d3bd039cd2a009 Bingbu Cao   2024-01-31  539  		ipu6_isys_get_isys_format(ipu6_isys_get_format(av), 0);
e660207a1d080c Sakari Ailus 2025-11-07  540  	struct media_pad *source_pad, *remote_pad;
7ff82d1f5490c1 Sakari Ailus 2025-12-11 @541  	bool first;
7ff82d1f5490c1 Sakari Ailus 2025-12-11  542  	int ret;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  543  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  544  	dev_dbg(dev, "stream: %s: width %u, height %u, css pixelformat %u\n",
d3bd039cd2a009 Bingbu Cao   2024-01-31  545  		av->vdev.name, ipu6_isys_get_frame_width(av),
d3bd039cd2a009 Bingbu Cao   2024-01-31  546  		ipu6_isys_get_frame_height(av), pfmt->css_pixelformat);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  547  
e660207a1d080c Sakari Ailus 2025-11-07  548  	remote_pad = media_pad_remote_pad_unique(&av->pad);
e660207a1d080c Sakari Ailus 2025-11-07  549  	if (IS_ERR(remote_pad)) {
e660207a1d080c Sakari Ailus 2025-11-07  550  		dev_dbg(dev, "failed to get remote pad\n");
e660207a1d080c Sakari Ailus 2025-11-07  551  		ret = PTR_ERR(remote_pad);
e660207a1d080c Sakari Ailus 2025-11-07  552  		goto out_return_buffers;
e660207a1d080c Sakari Ailus 2025-11-07  553  	}
e660207a1d080c Sakari Ailus 2025-11-07  554  
e660207a1d080c Sakari Ailus 2025-11-07  555  	source_pad = media_pad_remote_pad_unique(&remote_pad->entity->pads[0]);
e660207a1d080c Sakari Ailus 2025-11-07  556  	if (IS_ERR(source_pad)) {
e660207a1d080c Sakari Ailus 2025-11-07  557  		dev_dbg(dev, "No external source entity\n");
e660207a1d080c Sakari Ailus 2025-11-07  558  		ret = PTR_ERR(source_pad);
e660207a1d080c Sakari Ailus 2025-11-07  559  		goto out_return_buffers;
e660207a1d080c Sakari Ailus 2025-11-07  560  	}
e660207a1d080c Sakari Ailus 2025-11-07  561  
45316ce8af169d Sakari Ailus 2025-12-01  562  	bool has_pipeline = (bool)video_device_pipeline(&av->vdev);
45316ce8af169d Sakari Ailus 2025-12-01  563  
45316ce8af169d Sakari Ailus 2025-12-01  564  	ret = video_device_pipeline_alloc_start(&av->vdev);
45316ce8af169d Sakari Ailus 2025-12-01  565  	if (ret < 0)
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  566  		goto out_return_buffers;
45316ce8af169d Sakari Ailus 2025-12-01  567  
45316ce8af169d Sakari Ailus 2025-12-01  568  	first = !has_pipeline;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  569  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  570  	ret = ipu6_isys_link_fmt_validate(aq);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  571  	if (ret) {
4ff61c4ce93677 Sakari Ailus 2024-05-02  572  		dev_dbg(dev,
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  573  			"%s: link format validation failed (%d)\n",
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  574  			av->vdev.name, ret);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  575  		goto out_pipeline_stop;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  576  	}
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  577  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  578  	ret = ipu6_isys_fw_open(av->isys);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  579  	if (ret)
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  580  		goto out_pipeline_stop;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  581  
2085a6131710b0 Sakari Ailus 2025-11-10  582  	ret = ipu6_isys_stream_start(av);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  583  	if (ret)
45316ce8af169d Sakari Ailus 2025-12-01  584  		goto out_fw_close;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  585  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  586  	return 0;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  587  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  588  out_fw_close:
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  589  	ipu6_isys_fw_close(av->isys);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  590  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  591  out_pipeline_stop:
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  592  	ipu6_isys_stream_cleanup(av);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  593  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  594  out_return_buffers:
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  595  	return_buffers(aq, VB2_BUF_STATE_QUEUED);
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  596  
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  597  	return ret;
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  598  }
3c1dfb5a69cf83 Bingbu Cao   2024-01-31  599  

:::::: The code at line 541 was first introduced by commit
:::::: 7ff82d1f5490c155b938c69a670296b08334bd49 media: ipu6: Remove nr_queues and nr_streaming fields in ipu6_isys_stream

:::::: TO: Sakari Ailus <sakari.ailus@linux.intel.com>
:::::: CC: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-01-19 17:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202601200156.XCbBK9ms-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox