From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0A212F6160; Wed, 4 Feb 2026 16:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223439; cv=none; b=n0rlvGjVRPGLtpucpjLTgNzMOyBPVK3DjbZe19/3L0JHbGzO4sZVZNcZdU3bso4RGnn5fDcFI9D+5db1/yaZpgSDzY/Vtpsivd0XqPxsfwYZk3JiloGipWtcNV//BwqgIStF+isjvQITovM+EiQZuyNIo7xsTWPvTeoCSq51seQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770223439; c=relaxed/simple; bh=qldJ6sgrNVhQ6+tMXyVzxSoNgaT7hsfl7eFw2SC7SYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JImd/q1T0XxS4ozZVzQN6zZfzjxhKVJw5HKwtFHAYRP4DZEYbyXCsA96rl84ENBpNtghpwAbJ/fITk86AYgH/gqjLDES3nnSI9RzfCRreahkdgMSofyfc1FbcTmwwK9XTM1qcxw/Fng6SktlgtctbeLDzoN7YWpMtxOiwBS9Ts8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=SiHcPyGf; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SiHcPyGf" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--ff4.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::ff4]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 88E73593; Wed, 4 Feb 2026 17:43:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770223395; bh=qldJ6sgrNVhQ6+tMXyVzxSoNgaT7hsfl7eFw2SC7SYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SiHcPyGf0AEpN8eWR17GhmL1DwNCRD7xM0HnZ15NDAzsVpgnO5N9uwJTLJkHgTEvc o+rq9bafM9vx45FqFPuBhhDISq38Z0LN64vyUwhwJwWmEobPKoHpWVxFRFofKFh5C1 uS6hMnz87sngNVI0SPpXjgaFfAKmszYC7YkK9lYE= Date: Wed, 4 Feb 2026 18:43:56 +0200 From: Laurent Pinchart To: Isaac Scott Cc: linux-media@vger.kernel.org, dafna@fastmail.com, mchehab@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] media: rkisp1-resizer: Add YUV source formats to resizer Message-ID: <20260204164356.GC170964@killaraus> References: <20260204112506.3706049-1-isaac.scott@ideasonboard.com> <20260204112506.3706049-2-isaac.scott@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260204112506.3706049-2-isaac.scott@ideasonboard.com> On Wed, Feb 04, 2026 at 11:25:01AM +0000, Isaac Scott wrote: > To be able to use YUV bypass, YUV formats need to be available on the > source pad of the rkisp1 resizer. Add them. > > Signed-off-by: Isaac Scott > --- > .../platform/rockchip/rkisp1/rkisp1-resizer.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > index 8e6b753d3081..e72b76ab078c 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c > @@ -23,11 +23,26 @@ struct rkisp1_rsz_yuv_mbus_info { > }; > > static const struct rkisp1_rsz_yuv_mbus_info rkisp1_rsz_yuv_src_formats[] = { > + { > + .mbus_code = MEDIA_BUS_FMT_UYVY8_2X8, /* YUV422 */ > + .hdiv = 1, > + .vdiv = 1, > + }, > + { > + .mbus_code = MEDIA_BUS_FMT_VYUY8_2X8, /* YUV422 */ > + .hdiv = 1, > + .vdiv = 1, > + }, > { > .mbus_code = MEDIA_BUS_FMT_YUYV8_2X8, /* YUV422 */ > .hdiv = 2, > .vdiv = 1, > }, > + { > + .mbus_code = MEDIA_BUS_FMT_YVYU8_2X8, /* YUV422 */ > + .hdiv = 1, Shouldn't hdiv be 2 for all those new formats ? But overall, I don't think those formats are needed. I would be very surprised if the resizer used different YUV orders on its output bus. Can't you use MEDIA_BUS_FMT_YUYV8_2X8 unconditionally ? > + .vdiv = 1, > + }, > { > .mbus_code = MEDIA_BUS_FMT_YUYV8_1_5X8, /* YUV420 */ > .hdiv = 2, -- Regards, Laurent Pinchart