From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Taekyung Oh <ohxorud@ohxorud.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: media: atomisp: fix block comment style in ov2722.h
Date: Mon, 9 Feb 2026 07:47:11 +0100 [thread overview]
Message-ID: <2026020950-pacific-concur-9b99@gregkh> (raw)
In-Reply-To: <20260209045514.40352-2-ohxorud@ohxorud.com>
On Mon, Feb 09, 2026 at 04:55:53AM +0000, Taekyung Oh wrote:
> Fix coding style warnings reported by checkpatch.pl.
> Move the comments above the corresponding code lines.
>
> Signed-off-by: Taekyung Oh <ohxorud@ohxorud.com>
> ---
> drivers/staging/media/atomisp/i2c/ov2722.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> index 00317d105..c69f0086c 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> @@ -566,8 +566,8 @@ static const struct ov2722_reg ov2722_VGA_30fps[] = {
> #endif
>
> static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
> - {OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
> - a whole frame complete.(vblank) */
> + /* For stand wait for a whole frame complete.(vblank) */
> + {OV2722_8BIT, 0x3021, 0x03},
You now added a different coding style warning :(
next prev parent reply other threads:[~2026-02-09 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 4:55 [PATCH 0/2] staging: media: atomisp: cleanup ov2722.h driver Taekyung Oh
2026-02-09 4:55 ` [PATCH 1/2] staging: media: atomisp: fix block comment style in ov2722.h Taekyung Oh
2026-02-09 6:47 ` Greg Kroah-Hartman [this message]
2026-02-09 16:37 ` Taekyung Oh
2026-02-09 4:55 ` [PATCH 2/2] staging: media: atomisp: remove dead code " Taekyung Oh
2026-02-09 8:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020950-pacific-concur-9b99@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy@kernel.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=ohxorud@ohxorud.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox