From: Frank Li <Frank.Li@nxp.com>
To: Michael Riesch <michael.riesch@collabora.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Guoniu Zhou <guoniu.zhou@oss.nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
imx@lists.linux.dev, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 2/6] media: synopsys: only check errors from devm_clk_bulk_get_all()
Date: Tue, 10 Feb 2026 12:11:09 -0500 [thread overview]
Message-ID: <20260210-imx93-dw-csi2-v1-2-69667bb86bfa@nxp.com> (raw)
In-Reply-To: <20260210-imx93-dw-csi2-v1-0-69667bb86bfa@nxp.com>
devm_clk_bulk_get_all() returns all clocks described in the DT, which are
already validated by the binding. Do not need enforce an expected clock
count.
Only check for error returns (< 0) to support more SoCs.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/media/platform/synopsys/dw-mipi-csi2rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c
index 0cc892f4a1b3c6ce575a5d4fca7acf7057f7b7f7..61cd7f491b3d5b8a37707b23ca03ce709b40a79f 100644
--- a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c
+++ b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c
@@ -630,7 +630,7 @@ static int dw_mipi_csi2rx_probe(struct platform_device *pdev)
return PTR_ERR(csi2->base_addr);
ret = devm_clk_bulk_get_all(dev, &csi2->clks);
- if (ret != DW_MIPI_CSI2RX_CLKS_MAX)
+ if (ret < 0)
return dev_err_probe(dev, -ENODEV, "failed to get clocks\n");
csi2->clks_num = ret;
--
2.43.0
next prev parent reply other threads:[~2026-02-10 17:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 17:11 [PATCH 0/6] media: synopsys: Add imx93 support Frank Li
2026-02-10 17:11 ` [PATCH 1/6] media: synopsys: use devm_reset_control_get_optional_exclusive() Frank Li
2026-02-13 9:25 ` Michael Riesch
2026-02-10 17:11 ` Frank Li [this message]
2026-02-13 9:35 ` [PATCH 2/6] media: synopsys: only check errors from devm_clk_bulk_get_all() Michael Riesch
2026-02-10 17:11 ` [PATCH 3/6] media: synopsys: implement .get_frame_desc() callback Frank Li
2026-03-24 8:02 ` Sakari Ailus
2026-02-10 17:11 ` [PATCH 4/6] media: synopsys: use struct dw_mipi_csi2rx_regs to describe register offsets Frank Li
2026-02-13 10:02 ` Michael Riesch
2026-03-24 8:16 ` Sakari Ailus
2026-02-10 17:11 ` [PATCH 5/6] media: dt-bindings: add NXP i.MX93 compatible string Frank Li
2026-02-11 6:47 ` Krzysztof Kozlowski
2026-02-10 17:11 ` [PATCH 6/6] media: synopsys: add i.MX93 support Frank Li
2026-02-13 10:22 ` Michael Riesch
2026-03-23 19:10 ` [PATCH 0/6] media: synopsys: Add imx93 support Frank Li
2026-03-24 8:01 ` Sakari Ailus
2026-03-24 8:18 ` Sakari Ailus
2026-03-24 9:46 ` Michael Riesch
2026-03-24 10:35 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210-imx93-dw-csi2-v1-2-69667bb86bfa@nxp.com \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoniu.zhou@oss.nxp.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox