From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 338E9354AD4 for ; Wed, 11 Feb 2026 09:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770800966; cv=none; b=lj5ZoZE+d8ph6t9NcQqcbmgLxO/0Agv3JcOzs2UylqEh6wpR2vQ+9Fc9Wi749E2NIL9Ic+M/xU2ZanOuEhqAMzxkaPYB87T83x12ngJUhSKG1wg7nj0+W4BQL4ni6vysNhtHeJdIeWlFlfmkpnWzsATiMwxw5eadwr7IJpEr9EU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770800966; c=relaxed/simple; bh=bAwMwkgd7CjdEwH8mKy4oHqYagQfAW66fXJC90aViXE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JN8uN9Z65tNIk4Zp+SwEAEtlnip+j5mzAQeNweUbZabsHaJLihE6eS16CwSEW62zAtbzYOEXuZpOQXFhsUQnM9AYeLn9cHUDUKtA+uSvYXFDd4Qq2g4Rwjb04uIcJO0xeWgzYlTwMfArMOgiutd6rzpIjnbgP6lQIPs2OYhDumU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ml5O7IUV; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ml5O7IUV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770800965; x=1802336965; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bAwMwkgd7CjdEwH8mKy4oHqYagQfAW66fXJC90aViXE=; b=Ml5O7IUVowKFdOxxuTj/Y0lVJdFuH2zqpMGG7ra13JqK9pvMuyebuHcb 1A/gjYPJFgfIDwesrtty5oC5BPujSdtkQNiSRKQKCePHMfCLc63GpGre2 jW/zVrQG+OD3M3vK+HPci7CAoXfG7W6u5WHWP+RlRhYsHVJSZT/pB/Pmr o5aRIjYpgx6o53AAaN2cqvGf8NciTmzAoZR3db4rGKrPFlv05gblEasy+ 1HZB1Ff5rpq+UaobejcWn3S7SA9IciO4TOlvefI9jPiYcymrrCAv1WFNr coIRR+iT9t2Zgt3mQwS6+vLJ8rpPk/fqGCfFb0T2ZvYmTXNb6EB5j+OMj g==; X-CSE-ConnectionGUID: OPfUfROHQZWrG6WFAIsyoA== X-CSE-MsgGUID: Y70BSW++RIimGIW3rybRTQ== X-IronPort-AV: E=McAfee;i="6800,10657,11697"; a="72018932" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="72018932" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 01:09:21 -0800 X-CSE-ConnectionGUID: AJ9zxxgQTS+XUsbvGb43Eg== X-CSE-MsgGUID: EEs+OzR+TICGvKu4fKM6hQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="212222789" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.208]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 01:09:15 -0800 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id A686A121D3A; Wed, 11 Feb 2026 11:09:31 +0200 (EET) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1vq6Do-00000007lZo-26UR; Wed, 11 Feb 2026 11:09:20 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" Subject: [PATCH v2 01/14] media: imx219: Rename "PIXEL_ARRAY" as "CROP" Date: Wed, 11 Feb 2026 11:09:07 +0200 Message-ID: <20260211090920.1851141-2-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260211090920.1851141-1-sakari.ailus@linux.intel.com> References: <20260211090920.1851141-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The imx219 driver uses macros for denoting different aspects of the pixel array. The values used for IMX219_PIXEL_ARRAY_* macros imply a crop configuration however, not the size of the pixel array. Reflect this in the naming, too. Signed-off-by: Sakari Ailus --- drivers/media/i2c/imx219.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index fee63bc106d9..54622c406a03 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -142,10 +142,10 @@ /* IMX219 native and active pixel array size. */ #define IMX219_NATIVE_WIDTH 3296U #define IMX219_NATIVE_HEIGHT 2480U -#define IMX219_PIXEL_ARRAY_LEFT 8U -#define IMX219_PIXEL_ARRAY_TOP 8U -#define IMX219_PIXEL_ARRAY_WIDTH 3280U -#define IMX219_PIXEL_ARRAY_HEIGHT 2464U +#define IMX219_CROP_LEFT 8U +#define IMX219_CROP_TOP 8U +#define IMX219_CROP_WIDTH 3280U +#define IMX219_CROP_HEIGHT 2464U /* Mode : resolution and related config&values */ struct imx219_mode { @@ -675,13 +675,13 @@ static int imx219_set_framefmt(struct imx219 *imx219, bpp = imx219_get_format_bpp(format); cci_write(imx219->regmap, IMX219_REG_X_ADD_STA_A, - crop->left - IMX219_PIXEL_ARRAY_LEFT, &ret); + crop->left - IMX219_CROP_LEFT, &ret); cci_write(imx219->regmap, IMX219_REG_X_ADD_END_A, - crop->left - IMX219_PIXEL_ARRAY_LEFT + crop->width - 1, &ret); + crop->left - IMX219_CROP_LEFT + crop->width - 1, &ret); cci_write(imx219->regmap, IMX219_REG_Y_ADD_STA_A, - crop->top - IMX219_PIXEL_ARRAY_TOP, &ret); + crop->top - IMX219_CROP_TOP, &ret); cci_write(imx219->regmap, IMX219_REG_Y_ADD_END_A, - crop->top - IMX219_PIXEL_ARRAY_TOP + crop->height - 1, &ret); + crop->top - IMX219_CROP_TOP + crop->height - 1, &ret); imx219_get_binning(state, &bin_h, &bin_v); cci_write(imx219->regmap, IMX219_REG_BINNING_MODE_H, bin_h, &ret); @@ -867,8 +867,8 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, * Use binning to maximize the crop rectangle size, and centre it in the * sensor. */ - bin_h = min(IMX219_PIXEL_ARRAY_WIDTH / format->width, 2U); - bin_v = min(IMX219_PIXEL_ARRAY_HEIGHT / format->height, 2U); + bin_h = min(IMX219_CROP_WIDTH / format->width, 2U); + bin_v = min(IMX219_CROP_HEIGHT / format->height, 2U); /* Ensure bin_h and bin_v are same to avoid 1:2 or 2:1 stretching */ binning = min(bin_h, bin_v); @@ -967,10 +967,10 @@ static int imx219_get_selection(struct v4l2_subdev *sd, case V4L2_SEL_TGT_CROP_DEFAULT: case V4L2_SEL_TGT_CROP_BOUNDS: - sel->r.top = IMX219_PIXEL_ARRAY_TOP; - sel->r.left = IMX219_PIXEL_ARRAY_LEFT; - sel->r.width = IMX219_PIXEL_ARRAY_WIDTH; - sel->r.height = IMX219_PIXEL_ARRAY_HEIGHT; + sel->r.top = IMX219_CROP_TOP; + sel->r.left = IMX219_CROP_LEFT; + sel->r.width = IMX219_CROP_WIDTH; + sel->r.height = IMX219_CROP_HEIGHT; return 0; } -- 2.47.3