public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Arun T <arun.t@intel.com>
To: arun.t@intel.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio
Date: Wed, 11 Feb 2026 21:09:01 +0530	[thread overview]
Message-ID: <20260211153901.3737233-2-arun.t@intel.com> (raw)
In-Reply-To: <20260211153901.3737233-1-arun.t@intel.com>

Ov13b10 sensor get clock and regulator from TPS68470 PMIC.
Added tps68470 regulator/gpio names in power_on

Signed-off-by: Arun T <arun.t@intel.com>
---
 drivers/media/i2c/ov13b10.c | 47 ++++++++++++++++++++-----------------
 1 file changed, 26 insertions(+), 21 deletions(-)

diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
index 5421874732bc..228ffe5ada70 100644
--- a/drivers/media/i2c/ov13b10.c
+++ b/drivers/media/i2c/ov13b10.c
@@ -11,6 +11,7 @@
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-fwnode.h>
+#include <linux/regulator/consumer.h>
 
 #define OV13B10_REG_VALUE_08BIT		1
 #define OV13B10_REG_VALUE_16BIT		2
@@ -699,6 +700,13 @@ static const struct ov13b10_mode supported_2_lanes_modes[] = {
 	},
 };
 
+static const char * const ov13b10_supply_names[] = {
+	"dovdd",        /* Digital I/O power */
+	"avdd",         /* Analog power */
+	"dvdd",         /* Digital core power */
+};
+
+
 struct ov13b10 {
 	struct device *dev;
 
@@ -708,7 +716,7 @@ struct ov13b10 {
 	struct v4l2_ctrl_handler ctrl_handler;
 
 	struct clk *img_clk;
-	struct regulator *avdd;
+	struct regulator_bulk_data supplies[ARRAY_SIZE(ov13b10_supply_names)];
 	struct gpio_desc *reset;
 
 	/* V4L2 Controls */
@@ -1194,9 +1202,8 @@ static int ov13b10_power_off(struct device *dev)
 	struct ov13b10 *ov13b10 = to_ov13b10(sd);
 
 	gpiod_set_value_cansleep(ov13b10->reset, 1);
-
-	if (ov13b10->avdd)
-		regulator_disable(ov13b10->avdd);
+	regulator_bulk_disable(ARRAY_SIZE(ov13b10_supply_names),
+					ov13b10->supplies);
 
 	clk_disable_unprepare(ov13b10->img_clk);
 
@@ -1214,14 +1221,12 @@ static int ov13b10_power_on(struct device *dev)
 		dev_err(dev, "failed to enable imaging clock: %d", ret);
 		return ret;
 	}
-
-	if (ov13b10->avdd) {
-		ret = regulator_enable(ov13b10->avdd);
-		if (ret < 0) {
-			dev_err(dev, "failed to enable avdd: %d", ret);
-			clk_disable_unprepare(ov13b10->img_clk);
-			return ret;
-		}
+	ret = regulator_bulk_enable(ARRAY_SIZE(ov13b10_supply_names),
+					ov13b10->supplies);
+	if (ret < 0) {
+		dev_err(dev, "failed to enable regulators\n");
+		clk_disable_unprepare(ov13b10->img_clk);
+		return ret;
 	}
 
 	gpiod_set_value_cansleep(ov13b10->reset, 0);
@@ -1473,7 +1478,7 @@ static void ov13b10_free_controls(struct ov13b10 *ov13b)
 static int ov13b10_get_pm_resources(struct ov13b10 *ov13b)
 {
 	unsigned long freq;
-	int ret;
+	int ret, i;
 
 	ov13b->reset = devm_gpiod_get_optional(ov13b->dev, "reset", GPIOD_OUT_LOW);
 	if (IS_ERR(ov13b->reset))
@@ -1481,6 +1486,7 @@ static int ov13b10_get_pm_resources(struct ov13b10 *ov13b)
 				     "failed to get reset gpio\n");
 
 	ov13b->img_clk = devm_v4l2_sensor_clk_get(ov13b->dev, NULL);
+
 	if (IS_ERR(ov13b->img_clk))
 		return dev_err_probe(ov13b->dev, PTR_ERR(ov13b->img_clk),
 				     "failed to get imaging clock\n");
@@ -1491,15 +1497,14 @@ static int ov13b10_get_pm_resources(struct ov13b10 *ov13b)
 				     "external clock %lu is not supported\n",
 				     freq);
 
-	ov13b->avdd = devm_regulator_get_optional(ov13b->dev, "avdd");
-	if (IS_ERR(ov13b->avdd)) {
-		ret = PTR_ERR(ov13b->avdd);
-		ov13b->avdd = NULL;
-		if (ret != -ENODEV)
-			return dev_err_probe(ov13b->dev, ret,
-					     "failed to get avdd regulator\n");
-	}
+	for (i = 0; i < ARRAY_SIZE(ov13b10_supply_names); i++)
+		ov13b->supplies[i].supply = ov13b10_supply_names[i];
 
+	ret = devm_regulator_bulk_get(ov13b->dev, ARRAY_SIZE(ov13b10_supply_names),
+					ov13b->supplies);
+	if (ret)
+		return dev_err_probe(ov13b->dev, ret,
+				     "failed to get regulators\n");
 	return 0;
 }
 
-- 
2.43.0


  reply	other threads:[~2026-02-11 15:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  9:24 [PATCH 1/2] platform/x86: int3472: Add board data for Intel nvl Arun T
2026-01-30  9:24 ` [PATCH 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio Arun T
2026-02-02 15:11   ` johannes.goede
2026-02-17  6:11     ` T, Arun
2026-02-24 18:21       ` T, Arun
2026-02-11 15:39   ` [PATCH 1/2] platform/x86: int3472: Add board data for Intel nvl Arun T
2026-02-11 15:39     ` Arun T [this message]
2026-02-11 16:16   ` Arun T
2026-02-11 16:16     ` [PATCH 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio Arun T
2026-02-26  1:12   ` [PATCH 1/2] platform/x86: int3472: Add board data for Intel nvl Arun T
2026-02-26  1:12     ` [PATCH 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio Arun T
2026-02-26 11:15     ` [PATCH 1/2] platform/x86: int3472: Add board data for Intel nvl Kieran Bingham
2026-02-27 13:35   ` [PATCH v2 0/2] Add TPS68470 power supply support for ov13b10 sensor Arun T
2026-02-27 13:35     ` [PATCH v2 1/2] platform/x86: int3472: Add board data for Intel nvl Arun T
2026-03-01 14:37       ` Sakari Ailus
2026-03-04  9:29         ` johannes.goede
2026-03-06  8:47           ` T, Arun
2026-03-06  9:22             ` johannes.goede
2026-03-12  9:46               ` T, Arun
2026-03-16 17:57                 ` T, Arun
2026-02-27 13:35     ` [PATCH v2 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio Arun T
2026-03-01 14:40       ` Sakari Ailus
2026-03-02 17:46   ` [PATCH v3 0/2] Add TPS68470 power supply support for ov13b10 sensor Arun T
2026-03-02 17:46     ` [PATCH v3 1/2] platform/x86: int3472: Add TPS68470 board data for Intel nvl Arun T
2026-03-04  9:32       ` johannes.goede
2026-03-02 17:46     ` [PATCH v3 2/2] media: i2c: ov13b10: support tps68470 regulator and gpio Arun T
2026-02-02 15:10 ` [PATCH 1/2] platform/x86: int3472: Add board data for Intel nvl johannes.goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211153901.3737233-2-arun.t@intel.com \
    --to=arun.t@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox