* [PATCH] staging: media: av7110: replace BUG() with error return in gpioirq
@ 2026-02-07 22:05 Artem Lytkin
0 siblings, 0 replies; 2+ messages in thread
From: Artem Lytkin @ 2026-02-07 22:05 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-media, linux-staging, linux-kernel, Artem Lytkin
Replace BUG() with a return statement in the gpioirq tasklet handler.
If saa7146_wait_for_debi_done() times out, crashing the kernel is
disproportionate. The pr_err() already logs the failure, and returning
early avoids accessing hardware in a potentially broken state.
Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
---
drivers/staging/media/av7110/av7110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 602342d11..bd53d1a41 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -460,7 +460,7 @@ static void gpioirq(struct tasklet_struct *t)
if (saa7146_wait_for_debi_done(av7110->dev, 0)) {
pr_err("%s(): saa7146_wait_for_debi_done timed out\n", __func__);
- BUG(); /* maybe we should try resetting the debi? */
+ return;
}
spin_lock(&av7110->debilock);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] staging: media: av7110: replace BUG() with error return in gpioirq
@ 2026-02-16 20:18 Artem Lytkin
0 siblings, 0 replies; 2+ messages in thread
From: Artem Lytkin @ 2026-02-16 20:18 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-media, linux-staging, linux-kernel, Artem Lytkin
Replace BUG() with a return statement in the gpioirq tasklet handler.
If saa7146_wait_for_debi_done() times out, crashing the kernel is
disproportionate. The pr_err() already logs the failure, and returning
early avoids accessing hardware in a potentially broken state.
Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
---
drivers/staging/media/av7110/av7110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 602342d11..bd53d1a41 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -460,7 +460,7 @@ static void gpioirq(struct tasklet_struct *t)
if (saa7146_wait_for_debi_done(av7110->dev, 0)) {
pr_err("%s(): saa7146_wait_for_debi_done timed out\n", __func__);
- BUG(); /* maybe we should try resetting the debi? */
+ return;
}
spin_lock(&av7110->debilock);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-16 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-16 20:18 [PATCH] staging: media: av7110: replace BUG() with error return in gpioirq Artem Lytkin
-- strict thread matches above, loose matches on Subject: below --
2026-02-07 22:05 Artem Lytkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox