From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39D9246335 for ; Tue, 17 Feb 2026 00:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771288069; cv=none; b=PW5BV02WIBklILYvibWIcToV3Iegcstsoa5AbCw+jcj9w8aKIPVYTpg3fq+tECXSYMCav+CAAqme8Tclhehqla3QnqbSuprgKOGMyNtjyRqftRn3fSlyKbXOP6TjBp2YHzj2ioXRcun2+5k6N+5iN3ywGAt+pZZog5B/dmUTS7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771288069; c=relaxed/simple; bh=pVDlvVS5Bi6Vg+pGcrdIxRvJe/OF7V/L/8y6hmVgEX4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IGu3tLej9TGBVC//4nqpNATWTKV4K24DdfenwlfRrLsvWz5+MrNwadv5WnS/oJ+obP0yMlH4YFuzRqizeWDbeCkMBSDX2hqDzz9LBwaQXskZs+ECJ0bC9mSAPVBS3oxF2lcYnk618NFvwMmXdNaQOdJGXDn/z9AhzowcAFd+3lI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GymMXMIE; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GymMXMIE" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8cb5c9ba82bso215748485a.2 for ; Mon, 16 Feb 2026 16:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771288067; x=1771892867; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lbk1GUedD4ye8Cnd2HrixlkkqkX5OW0vDgVQlNzH9xs=; b=GymMXMIEo/YeX6lcjURHfo3fLa8XjAljeGp4EXuTKPM9DVxTrQWuJSw8wteReyHSFK k372WVsZKXoksXUFyOslF5VxBh+222YygYvHbcsOFeW3e/2ikCL8VUJXUoj2B0sURdzl ln37VsWiYHgl8Nk9bKd6Czud6Qf7JIcBk9Vmvd/YLHMhNpwvkpa4pFtJ8RzrWWIxTOjx 0TiJCCK2G2Y0e8/ideeKn2MYpjSmmqcG+v1F7qX2CuWGRLRMM/AVMXOMMd4iSctY4BeV 4z8XIM2YAA1o9yhYILYJ4F4vikvd72IQlU3Jm2j4Jaio8ODM8uIrGtNKbpJDcvdZGYeV wb5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771288067; x=1771892867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lbk1GUedD4ye8Cnd2HrixlkkqkX5OW0vDgVQlNzH9xs=; b=aYrpFozT2szd0JqvgsmwpFBThotS6bxN9Al+YD3bYpgtsZrKLKIn0YppuYPrjOHdzV pOI/9RWe+GtQUcbNQJvG3NmvGbq1cB/+cQiPRqXR4eZyYBhvNBceYg7kvG5u+Dr0ygQy Fu6v2L8RLrugt6EaJ652NyVRO27kUxWxeL5FkdnSOk+xjiLygPhqMla6xVKATfG5aDQk l6yGsdefmDcVHjZlhfaIyCY2r7GhpmC8GWvvGeQNjnRe6a2JW9KY1DX5CmM2pswy4nzI SJkJk1HFj1VBJVrYkStBJleMSLCMxKrsx0TksvYSqQaJL4dTSC88dIY6ioQKCM/4d3rn Iqaw== X-Forwarded-Encrypted: i=1; AJvYcCUPyKx1Wuec7vIXFTiwV6r7E8xWwUH057aho01vARuWgrOJ1wabtQTAm6H2nDmRuEM710UVqtPC02EUmg==@vger.kernel.org X-Gm-Message-State: AOJu0YyK9SY+roNj5NHOwRk9DYdoa//tF7+VQiTgHc8bXUXBNaQuSTwA RKwzDxkNMkdHP/kgOMYm+5Ex9op67q6xp8bObtzc38s0vi//RJRglVBp X-Gm-Gg: AZuq6aK3Z+pADscTSRw895Fu/VYz4ZpNvpJbOkFKm/qK6qoaRD9GI5CZkMopPp6ppAt NWegfEPte7uEPzPSSqtVAnDnKOk8R4dFxzR1rue6TybEF4FA8nzRSns0FLtrbzSimnoN/k62cNJ Tm/oB4FU8BooC1aAxfCB6nrBFnnPcA86X2imYhjYv6GckYHn/TV2pqcX2Pt1VEqDQVbkttXUekL HLCwCH+UvJQ7/gjyWgT/mnw7F/HXh0z/LDfzEfob2kNwZw8sCv2w2r8E7/azLC0UBiKrD4nd8mn KK8jsicSzB8IjbksG9IOapJMEUyBS9Fw19ohGPnYqlFbxeGwSYZ5qoTcruDZ7tN4+3vwFd98DXH NeYEQ6jBp9LbHRsDZEGiGpN4OXIZLkX/uVMo5nw3DA5Xpphg2ub6iHwvsjxrscMCgjzovzxCUuJ WUnuuNz+S1ev5bFv2qwX7ARwslmNIwNg== X-Received: by 2002:ac8:7f48:0:b0:501:4f38:3d47 with SMTP id d75a77b69052e-506b4000f79mr134622751cf.53.1771288066964; Mon, 16 Feb 2026 16:27:46 -0800 (PST) Received: from localhost ([184.144.58.243]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8971cdbd860sm148817756d6.46.2026.02.16.16.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 16:27:46 -0800 (PST) From: Richard Acayan To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , "Bryan O'Donoghue" , Vladimir Zapolskiy , Bjorn Andersson , Konrad Dybcio , Tianshu Qiu , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Robert Mader , David Heidelberg , phone-devel@vger.kernel.org, Richard Acayan Subject: [PATCH v9 3/7] media: i2c: imx355: Support devicetree and power management Date: Mon, 16 Feb 2026 19:27:34 -0500 Message-ID: <20260217002738.133534-4-mailingradian@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260217002738.133534-1-mailingradian@gmail.com> References: <20260217002738.133534-1-mailingradian@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A device tree compatible makes it possible for this driver to be used on Open Firmware devices. Initialization of power-managed resources such as the reset GPIO and voltage regulators can be specified in the device tree and handled by the driver. Add support for this so the Pixel 3a can use the driver. Reviewed-by: Bryan O'Donoghue Reviewed-by: Vladimir Zapolskiy Signed-off-by: Richard Acayan --- drivers/media/i2c/imx355.c | 111 ++++++++++++++++++++++++++++++++++--- 1 file changed, 103 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index 776107efe386..9ca87488c933 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -3,9 +3,13 @@ #include #include +#include +#include #include #include +#include #include +#include #include #include @@ -125,6 +129,15 @@ struct imx355 { * Protect access to sensor v4l2 controls. */ struct mutex mutex; + + struct gpio_desc *reset_gpio; + struct regulator_bulk_data *supplies; +}; + +static const struct regulator_bulk_data imx355_supplies[] = { + { .supply = "avdd" }, + { .supply = "dvdd" }, + { .supply = "dovdd" }, }; static const struct imx355_reg imx355_global_regs[] = { @@ -1515,6 +1528,52 @@ static const struct v4l2_subdev_internal_ops imx355_internal_ops = { .open = imx355_open, }; +static int imx355_power_off(struct device *dev) +{ + struct i2c_client *client = container_of(dev, struct i2c_client, dev); + struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct imx355 *imx355 = to_imx355(sd); + + gpiod_set_value_cansleep(imx355->reset_gpio, 1); + + regulator_bulk_disable(ARRAY_SIZE(imx355_supplies), imx355->supplies); + clk_disable_unprepare(imx355->clk); + + return 0; +} + +static int imx355_power_on(struct device *dev) +{ + struct i2c_client *client = container_of(dev, struct i2c_client, dev); + struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct imx355 *imx355 = to_imx355(sd); + int ret; + + ret = clk_prepare_enable(imx355->clk); + if (ret) + return dev_err_probe(dev, ret, "failed to enable clocks"); + + ret = regulator_bulk_enable(ARRAY_SIZE(imx355_supplies), + imx355->supplies); + if (ret) { + dev_err_probe(dev, ret, "failed to enable regulators"); + goto error_disable_clocks; + } + + usleep_range(1000, 2000); + gpiod_set_value_cansleep(imx355->reset_gpio, 0); + usleep_range(10000, 11000); + + return 0; + +error_disable_clocks: + clk_disable_unprepare(imx355->clk); + return ret; +} + +static DEFINE_RUNTIME_DEV_PM_OPS(imx355_pm_ops, imx355_power_off, + imx355_power_on, NULL); + /* Initialize control handlers */ static int imx355_init_controls(struct imx355 *imx355) { @@ -1689,16 +1748,26 @@ static int imx355_probe(struct i2c_client *client) "external clock %lu is not supported\n", freq); - /* Initialize subdev */ - v4l2_i2c_subdev_init(&imx355->sd, client, &imx355_subdev_ops); - - /* Check module identity */ - ret = imx355_identify_module(imx355); + ret = devm_regulator_bulk_get_const(imx355->dev, + ARRAY_SIZE(imx355_supplies), + imx355_supplies, + &imx355->supplies); if (ret) { - dev_err(imx355->dev, "failed to find sensor: %d", ret); + dev_err_probe(imx355->dev, ret, "could not get regulators"); goto error_probe; } + imx355->reset_gpio = devm_gpiod_get_optional(imx355->dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(imx355->reset_gpio)) { + ret = dev_err_probe(imx355->dev, PTR_ERR(imx355->reset_gpio), + "failed to get gpios"); + goto error_probe; + } + + /* Initialize subdev */ + v4l2_i2c_subdev_init(&imx355->sd, client, &imx355_subdev_ops); + imx355->hwcfg = imx355_get_hwcfg(imx355->dev); if (!imx355->hwcfg) { dev_err(imx355->dev, "failed to get hwcfg"); @@ -1706,13 +1775,24 @@ static int imx355_probe(struct i2c_client *client) goto error_probe; } + ret = imx355_power_on(imx355->dev); + if (ret) + goto error_probe; + + /* Check module identity */ + ret = imx355_identify_module(imx355); + if (ret) { + dev_err(imx355->dev, "failed to find sensor: %d", ret); + goto error_power_off; + } + /* Set default mode to max resolution */ imx355->cur_mode = &supported_modes[0]; ret = imx355_init_controls(imx355); if (ret) { dev_err(imx355->dev, "failed to init controls: %d", ret); - goto error_probe; + goto error_power_off; } /* Initialize subdev */ @@ -1752,6 +1832,9 @@ static int imx355_probe(struct i2c_client *client) error_handler_free: v4l2_ctrl_handler_free(imx355->sd.ctrl_handler); +error_power_off: + imx355_power_off(imx355->dev); + error_probe: mutex_destroy(&imx355->mutex); @@ -1768,7 +1851,11 @@ static void imx355_remove(struct i2c_client *client) v4l2_ctrl_handler_free(sd->ctrl_handler); pm_runtime_disable(imx355->dev); - pm_runtime_set_suspended(imx355->dev); + + if (!pm_runtime_status_suspended(imx355->dev)) { + imx355_power_off(imx355->dev); + pm_runtime_set_suspended(imx355->dev); + } mutex_destroy(&imx355->mutex); } @@ -1779,10 +1866,18 @@ static const struct acpi_device_id imx355_acpi_ids[] __maybe_unused = { }; MODULE_DEVICE_TABLE(acpi, imx355_acpi_ids); +static const struct of_device_id imx355_match_table[] = { + { .compatible = "sony,imx355", }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, imx355_match_table); + static struct i2c_driver imx355_i2c_driver = { .driver = { .name = "imx355", .acpi_match_table = ACPI_PTR(imx355_acpi_ids), + .of_match_table = imx355_match_table, + .pm = &imx355_pm_ops, }, .probe = imx355_probe, .remove = imx355_remove, -- 2.53.0