From: Richard Acayan <mailingradian@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Cc: Robert Mader <robert.mader@collabora.com>,
David Heidelberg <david@ixit.cz>,
phone-devel@vger.kernel.org,
Richard Acayan <mailingradian@gmail.com>
Subject: [PATCH v9 4/7] media: i2c: imx355: Restrict data lanes to 4
Date: Mon, 16 Feb 2026 19:27:35 -0500 [thread overview]
Message-ID: <20260217002738.133534-5-mailingradian@gmail.com> (raw)
In-Reply-To: <20260217002738.133534-1-mailingradian@gmail.com>
The IMX355 sensor driver currently supports having 4 data lanes. There
can't be more or less, so check if the firmware specifies 4 lanes.
Existing ACPI hardware descriptions may not have the data lanes defined
so this check also accepts a placeholder of 0 lanes.
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/aW3uFcT1zmiF4GUP@kekkonen.localdomain
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/media/i2c/imx355.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
index 9ca87488c933..0d6aabea7d59 100644
--- a/drivers/media/i2c/imx355.c
+++ b/drivers/media/i2c/imx355.c
@@ -66,6 +66,9 @@
#define IMX355_EXT_CLK 19200000
#define IMX355_LINK_FREQ_INDEX 0
+/* number of data lanes */
+#define IMX355_DATA_LANES 4
+
struct imx355_reg {
u16 address;
u8 val;
@@ -1705,6 +1708,10 @@ static struct imx355_hwcfg *imx355_get_hwcfg(struct device *dev)
if (!cfg)
goto out_err;
+ if (bus_cfg.bus.mipi_csi2.num_data_lanes != 0
+ && bus_cfg.bus.mipi_csi2.num_data_lanes != IMX355_DATA_LANES)
+ goto out_err;
+
ret = v4l2_link_freq_to_bitmap(dev, bus_cfg.link_frequencies,
bus_cfg.nr_of_link_frequencies,
link_freq_menu_items,
--
2.53.0
next prev parent reply other threads:[~2026-02-17 0:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 0:27 [PATCH v9 0/7] media: i2c: IMX355 for the Pixel 3a Richard Acayan
2026-02-17 0:27 ` [PATCH v9 1/7] dt-bindings: media: qcom,sdm670-camss: Remove clock-lanes requirement Richard Acayan
2026-02-17 7:38 ` Krzysztof Kozlowski
2026-02-17 0:27 ` [PATCH v9 2/7] dt-bindings: media: i2c: Add Sony IMX355 Richard Acayan
2026-02-17 0:27 ` [PATCH v9 3/7] media: i2c: imx355: Support devicetree and power management Richard Acayan
2026-02-17 0:27 ` Richard Acayan [this message]
2026-03-10 8:07 ` [PATCH v9 4/7] media: i2c: imx355: Restrict data lanes to 4 Sakari Ailus
2026-02-17 0:27 ` [PATCH v9 5/7] arm64: dts: qcom: sdm670: label the camss ports instead of endpoints Richard Acayan
2026-02-17 0:27 ` [PATCH v9 6/7] arm64: dts: qcom: sdm670: add camera mclk pins Richard Acayan
2026-02-17 0:27 ` [PATCH v9 7/7] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Richard Acayan
2026-03-11 2:25 ` Richard Acayan
2026-03-11 19:59 ` David Heidelberg
2026-03-13 18:26 ` David Heidelberg
2026-03-24 2:05 ` Richard Acayan
2026-03-24 9:35 ` David Heidelberg
2026-03-24 10:57 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217002738.133534-5-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robert.mader@collabora.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox