Re: [raw2rgbpnm PATCH v3 1/3] Add explicit switch fallthrough notation

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Wed, Feb 18, 2026 at 10:34:22AM +0200, Sakari Ailus wrote:
> Use __attribute__((fallthrough)) instead of a comment this is taking
> place, to make modern GCC happy.

This will require gcc 7 or newer, which I think is fine. You could check
the compiler version at build time and emit an error if the compiler is
not recent enough (and you could use that as an opportunity to switch
from make to meson :-)). This is of course out of scope for this series.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  raw2rgbpnm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/raw2rgbpnm.c b/raw2rgbpnm.c
> index baeb8efc863a..5df3ff7ab31d 100644
> --- a/raw2rgbpnm.c
> +++ b/raw2rgbpnm.c
> @@ -362,7 +362,7 @@ static void raw_to_rgb(const struct format_info *info,
>  
>  	case V4L2_PIX_FMT_NV21:
>  		color_pos = 0;
> -		/* fallthrough */
> +		__attribute__((fallthrough));
>  	case V4L2_PIX_FMT_NV12:
>  		src_luma = src;
>  		src_chroma = &src[src_width * src_height];
> @@ -576,7 +576,7 @@ static void raw_to_rgb(const struct format_info *info,
>  	case V4L2_PIX_FMT_SRGGB10:
>  		if (raw_layout_to_grbg(info, src, src_width, src_height, src_stride))
>  			error("Can't convert RAW layout to GRBG");
> -		/* fallthrough */
> +		__attribute__((fallthrough));
>  	case V4L2_PIX_FMT_SGRBG16:
>  	case V4L2_PIX_FMT_SGRBG14:
>  	case V4L2_PIX_FMT_SGRBG12:
> @@ -620,7 +620,7 @@ static void raw_to_rgb(const struct format_info *info,
>  	case V4L2_PIX_FMT_SRGGB8:
>  		if (raw_layout_to_grbg(info, src, src_width, src_height, src_stride))
>  			error("Can't convert RAW layout to GRBG");
> -		/* fallthrough */
> +		__attribute__((fallthrough));
>  	case V4L2_PIX_FMT_SGRBG8:
>  		buf = malloc(src_width * src_height * 3);
>  		if (buf==NULL) error("out of memory");
> @@ -688,7 +688,7 @@ static void raw_to_rgb(const struct format_info *info,
>  
>  	case V4L2_PIX_FMT_BGR24:
>  		swaprb = !swaprb;
> -		/* fallthrough */
> +		__attribute__((fallthrough));
>  	case V4L2_PIX_FMT_RGB24:
>  		for (src_y = 0, dst_y = 0; dst_y < src_height; src_y++, dst_y++) {
>  			for (src_x = 0, dst_x = 0; dst_x < src_width; ) {

-- 
Regards,

Laurent Pinchart