public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Modified uvc_driver
@ 2026-02-19 13:18 Jayesh Puri
  2026-02-19 13:32 ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Jayesh Puri @ 2026-02-19 13:18 UTC (permalink / raw)
  To: laurent.pinchart, mchehab; +Cc: Jayesh Puri, linux-media, linux-kernel

---
 Kconfig                            | 0
 drivers/media/usb/uvc/uvc_driver.c | 2 ++
 2 files changed, 2 insertions(+)
 mode change 100644 => 100755 Kconfig

diff --git a/Kconfig b/Kconfig
old mode 100644
new mode 100755
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index aa3e8d295e0f..cec117328ab2 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2191,6 +2191,8 @@ static int uvc_probe(struct usb_interface *intf,
 		(const struct uvc_device_info *)id->driver_info;
 	int function;
 	int ret;
+	
+	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
 
 	/* Allocate memory for the device and initialize it. */
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Modified uvc_driver
  2026-02-19 13:18 [PATCH] Modified uvc_driver Jayesh Puri
@ 2026-02-19 13:32 ` Laurent Pinchart
  2026-02-19 20:24   ` Shuah Khan
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2026-02-19 13:32 UTC (permalink / raw)
  To: Jayesh Puri; +Cc: mchehab, linux-media, linux-kernel, Shuah Khan

On Thu, Feb 19, 2026 at 06:48:11PM +0530, Jayesh Puri wrote:
> ---
>  Kconfig                            | 0
>  drivers/media/usb/uvc/uvc_driver.c | 2 ++
>  2 files changed, 2 insertions(+)
>  mode change 100644 => 100755 Kconfig
> 
> diff --git a/Kconfig b/Kconfig
> old mode 100644
> new mode 100755
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index aa3e8d295e0f..cec117328ab2 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2191,6 +2191,8 @@ static int uvc_probe(struct usb_interface *intf,
>  		(const struct uvc_device_info *)id->driver_info;
>  	int function;
>  	int ret;
> +	
> +	pr_info("I changed uvcvideo driver in the Linux Kernel\n");

Congratulations, but I'm afraid we're out of medals.

Shuah, I thought LFD103 has been updated to avoid spamming the lists
with such patches. What happened ?

>  
>  	/* Allocate memory for the device and initialize it. */
>  	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Modified uvc_driver
  2026-02-19 13:32 ` Laurent Pinchart
@ 2026-02-19 20:24   ` Shuah Khan
  2026-02-20 10:27     ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2026-02-19 20:24 UTC (permalink / raw)
  To: Laurent Pinchart, Jayesh Puri
  Cc: mchehab, linux-media, linux-kernel, Shuah Khan

On 2/19/26 06:32, Laurent Pinchart wrote:
> On Thu, Feb 19, 2026 at 06:48:11PM +0530, Jayesh Puri wrote:
>> ---
>>   Kconfig                            | 0
>>   drivers/media/usb/uvc/uvc_driver.c | 2 ++
>>   2 files changed, 2 insertions(+)
>>   mode change 100644 => 100755 Kconfig
>>
>> diff --git a/Kconfig b/Kconfig
>> old mode 100644
>> new mode 100755
>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>> index aa3e8d295e0f..cec117328ab2 100644
>> --- a/drivers/media/usb/uvc/uvc_driver.c
>> +++ b/drivers/media/usb/uvc/uvc_driver.c
>> @@ -2191,6 +2191,8 @@ static int uvc_probe(struct usb_interface *intf,
>>   		(const struct uvc_device_info *)id->driver_info;
>>   	int function;
>>   	int ret;
>> +	
>> +	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> 
> Congratulations, but I'm afraid we're out of medals.
> 
> Shuah, I thought LFD103 has been updated to avoid spamming the lists
> with such patches. What happened ?

It is changed a while back - not sure what's going on.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Modified uvc_driver
  2026-02-19 20:24   ` Shuah Khan
@ 2026-02-20 10:27     ` Laurent Pinchart
  2026-02-20 15:49       ` Shuah Khan
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2026-02-20 10:27 UTC (permalink / raw)
  To: Shuah Khan; +Cc: Jayesh Puri, mchehab, linux-media, linux-kernel

On Thu, Feb 19, 2026 at 01:24:23PM -0700, Shuah Khan wrote:
> On 2/19/26 06:32, Laurent Pinchart wrote:
> > On Thu, Feb 19, 2026 at 06:48:11PM +0530, Jayesh Puri wrote:
> >> ---
> >>   Kconfig                            | 0
> >>   drivers/media/usb/uvc/uvc_driver.c | 2 ++
> >>   2 files changed, 2 insertions(+)
> >>   mode change 100644 => 100755 Kconfig
> >>
> >> diff --git a/Kconfig b/Kconfig
> >> old mode 100644
> >> new mode 100755
> >> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> >> index aa3e8d295e0f..cec117328ab2 100644
> >> --- a/drivers/media/usb/uvc/uvc_driver.c
> >> +++ b/drivers/media/usb/uvc/uvc_driver.c
> >> @@ -2191,6 +2191,8 @@ static int uvc_probe(struct usb_interface *intf,
> >>   		(const struct uvc_device_info *)id->driver_info;
> >>   	int function;
> >>   	int ret;
> >> +	
> >> +	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> > 
> > Congratulations, but I'm afraid we're out of medals.
> > 
> > Shuah, I thought LFD103 has been updated to avoid spamming the lists
> > with such patches. What happened ?
> 
> It is changed a while back - not sure what's going on.

Could you please investigate ?

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Modified uvc_driver
  2026-02-20 10:27     ` Laurent Pinchart
@ 2026-02-20 15:49       ` Shuah Khan
  2026-02-20 16:13         ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2026-02-20 15:49 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: Jayesh Puri, mchehab, linux-media, linux-kernel

On 2/20/26 03:27, Laurent Pinchart wrote:
> On Thu, Feb 19, 2026 at 01:24:23PM -0700, Shuah Khan wrote:
>> On 2/19/26 06:32, Laurent Pinchart wrote:
>>> On Thu, Feb 19, 2026 at 06:48:11PM +0530, Jayesh Puri wrote:
>>>> ---
>>>>    Kconfig                            | 0
>>>>    drivers/media/usb/uvc/uvc_driver.c | 2 ++
>>>>    2 files changed, 2 insertions(+)
>>>>    mode change 100644 => 100755 Kconfig
>>>>
>>>> diff --git a/Kconfig b/Kconfig
>>>> old mode 100644
>>>> new mode 100755
>>>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>>>> index aa3e8d295e0f..cec117328ab2 100644
>>>> --- a/drivers/media/usb/uvc/uvc_driver.c
>>>> +++ b/drivers/media/usb/uvc/uvc_driver.c
>>>> @@ -2191,6 +2191,8 @@ static int uvc_probe(struct usb_interface *intf,
>>>>    		(const struct uvc_device_info *)id->driver_info;
>>>>    	int function;
>>>>    	int ret;
>>>> +	
>>>> +	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
>>>
>>> Congratulations, but I'm afraid we're out of medals.
>>>
>>> Shuah, I thought LFD103 has been updated to avoid spamming the lists
>>> with such patches. What happened ?
>>
>> It is changed a while back - not sure what's going on.
> 
> Could you please investigate ?
> 

I will look into it

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Modified uvc_driver
  2026-02-20 15:49       ` Shuah Khan
@ 2026-02-20 16:13         ` Laurent Pinchart
  0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2026-02-20 16:13 UTC (permalink / raw)
  To: Shuah Khan; +Cc: Jayesh Puri, mchehab, linux-media, linux-kernel

On Fri, Feb 20, 2026 at 08:49:47AM -0700, Shuah Khan wrote:
> On 2/20/26 03:27, Laurent Pinchart wrote:
> > On Thu, Feb 19, 2026 at 01:24:23PM -0700, Shuah Khan wrote:
> >> On 2/19/26 06:32, Laurent Pinchart wrote:
> >>> On Thu, Feb 19, 2026 at 06:48:11PM +0530, Jayesh Puri wrote:
> >>>> ---
> >>>>    Kconfig                            | 0
> >>>>    drivers/media/usb/uvc/uvc_driver.c | 2 ++
> >>>>    2 files changed, 2 insertions(+)
> >>>>    mode change 100644 => 100755 Kconfig
> >>>>
> >>>> diff --git a/Kconfig b/Kconfig
> >>>> old mode 100644
> >>>> new mode 100755
> >>>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> >>>> index aa3e8d295e0f..cec117328ab2 100644
> >>>> --- a/drivers/media/usb/uvc/uvc_driver.c
> >>>> +++ b/drivers/media/usb/uvc/uvc_driver.c
> >>>> @@ -2191,6 +2191,8 @@ static int uvc_probe(struct usb_interface *intf,
> >>>>    		(const struct uvc_device_info *)id->driver_info;
> >>>>    	int function;
> >>>>    	int ret;
> >>>> +	
> >>>> +	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> >>>
> >>> Congratulations, but I'm afraid we're out of medals.
> >>>
> >>> Shuah, I thought LFD103 has been updated to avoid spamming the lists
> >>> with such patches. What happened ?
> >>
> >> It is changed a while back - not sure what's going on.
> > 
> > Could you please investigate ?
> 
> I will look into it

Thank you.

Jayesh, I assume this conversation took you by surprise, so I'll provide
a bit of context. LFD103 used to provide instructions on how to modify a
driver, create a patch and send it to a mailing list. Those instructions
were then followed by a line to tell the reader to not actually run the
commands. Unsurprisingly, that line was often overlooked, and patches
such as this one spammed the list.

I got a bit fed up and reported the issue to Shuah, who ensured LFD103
would be improved to avoid the problem. That was months ago, so I'm
surprised to see the issue occurring again. If you've followed the old
LFD103, I'm blaming the original wording of the course, not you, for the
problem.

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-02-20 16:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-19 13:18 [PATCH] Modified uvc_driver Jayesh Puri
2026-02-19 13:32 ` Laurent Pinchart
2026-02-19 20:24   ` Shuah Khan
2026-02-20 10:27     ` Laurent Pinchart
2026-02-20 15:49       ` Shuah Khan
2026-02-20 16:13         ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox