public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Cory Keitz <ckeitz@amazon.com>
To: David Heidelberg <david@ixit.cz>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	Kieran Bingham <kbingham@kernel.org>,
	Cory Keitz <ckeitz@amazon.com>
Subject: Re: [PATCH WIP v4 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms
Date: Mon, 2 Mar 2026 10:43:59 -0800	[thread overview]
Message-ID: <20260302184359.19394-1-ckeitz@amazon.com> (raw)
In-Reply-To: <20260301-qcom-cphy-v4-0-e53316d2cc65@ixit.cz>

Hi David,

I've been working on CPHY support for sa8775p / csid-gen3 on 6.6 and have a
similar patch set. The approach here aligns well with what I've done, good to
see this infrastructure going upstream. I've implemented the following for
SA8775P that can be added on top of your series once it lands:

- CSI2_RX_CFG0_PHY_TYPE_SEL in camss-csid-gen3.c
- CSIPHY v1.3.1 register tables for sa8775p
- Data rate-specific tuning for 5 bandwidth tiers (1.5/1.7/2.5/3.5/4.5 Gsps)

I've only tested on a 6.6 kernel so far, not on mainline, so I can't give a
Tested-by yet. I can confirm the settle count calculation and PHY selection
approach are in line with what I have tested.

Acked-by: Cory Keitz <ckeitz@amazon.com>

Thanks,
Cory

  parent reply	other threads:[~2026-03-02 18:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01  0:51 [PATCH WIP v4 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms David Heidelberg via B4 Relay
2026-03-01  0:51 ` [PATCH WIP v4 1/9] media: qcom: camss: csiphy: Introduce PHY configuration David Heidelberg via B4 Relay
2026-03-03  9:48   ` Bryan O'Donoghue
2026-03-01  0:51 ` [PATCH WIP v4 2/9] media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanes David Heidelberg via B4 Relay
2026-03-03  9:52   ` Bryan O'Donoghue
2026-03-01  0:51 ` [PATCH WIP v4 3/9] media: qcom: camss: Prepare CSID for C-PHY support David Heidelberg via B4 Relay
2026-03-03  9:53   ` Bryan O'Donoghue
2026-03-03 20:31     ` David Heidelberg
2026-03-01  0:51 ` [PATCH WIP v4 4/9] media: qcom: camss: Initialize lanes after lane configuration is available David Heidelberg via B4 Relay
2026-03-03  9:54   ` Bryan O'Donoghue
2026-03-03 10:06     ` David Heidelberg
2026-03-03 10:10       ` Bryan O'Donoghue
2026-03-03 10:12         ` David Heidelberg
2026-03-01  0:51 ` [PATCH WIP v4 5/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 CPHY init David Heidelberg via B4 Relay
2026-03-01  0:51 ` [PATCH WIP v4 6/9] media: qcom: camss: csiphy-3ph: Update " David Heidelberg via B4 Relay
2026-03-03  9:55   ` Bryan O'Donoghue
2026-03-03 10:00     ` David Heidelberg
2026-03-03 10:08       ` Bryan O'Donoghue
2026-03-03 10:22       ` Konrad Dybcio
2026-03-03 10:27         ` David Heidelberg
2026-03-03 10:39         ` Bryan O'Donoghue
2026-03-03 10:46           ` Konrad Dybcio
2026-03-01  0:51 ` [PATCH WIP v4 7/9] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.1 MIPI CSI-2 C-PHY init David Heidelberg via B4 Relay
2026-03-03  9:56   ` Bryan O'Donoghue
2026-03-01  0:51 ` [PATCH WIP v4 8/9] media: qcom: camss: csiphy-3ph: C-PHY needs own lane configuration David Heidelberg via B4 Relay
2026-03-03  9:59   ` Bryan O'Donoghue
2026-03-01  0:51 ` [PATCH WIP v4 9/9] media: qcom: camss: Account for C-PHY when calculating link frequency David Heidelberg via B4 Relay
2026-03-03 10:07   ` Bryan O'Donoghue
2026-03-20 19:48   ` Cory Keitz
2026-03-02 18:43 ` Cory Keitz [this message]
2026-03-02 23:13   ` [PATCH WIP v4 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms David Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302184359.19394-1-ckeitz@amazon.com \
    --to=ckeitz@amazon.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=david@ixit.cz \
    --cc=kbingham@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox