From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6575C37D13A; Thu, 5 Mar 2026 10:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707169; cv=none; b=hmivW+oJ+bGNzQknIJcIrbxHPV1VqAXCutYqsgphtqCjGRHyeB5QTF4vM9+Yr0WeVY2SIqCCbkOuODNFJJ5X0pn4/MEDSITup/Ij185RxcroxUArWzbT8ZjwMaV1Tag08SZXn/vbRlpsn38C21+CSqq5IyZNlvUcgoTmrGPxmoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707169; c=relaxed/simple; bh=bdMXs3cKCsinjxiW7C7KKB3lLvMOBVAZch5dXGPzlBM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oc/BI1/0BLL3ESmcOifS3Tvvmo1NGDnHoWZtOUpY60RwQ9XV7cTxGqTog6ZRmUJ/xdHdVwfwKOw/EIg49YuXcHlO+wXDjX12W/fJH2NZyYsm0GLR+PbqAN9tQb+VkU5uIsy56ucitUeA2NviLwOpqgsvX7QximxEGG62H+6TMB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L7cwBBHz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L7cwBBHz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D611C4AF0B; Thu, 5 Mar 2026 10:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772707169; bh=bdMXs3cKCsinjxiW7C7KKB3lLvMOBVAZch5dXGPzlBM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L7cwBBHzcHKKwixohDAmXlENn32IwCK74hwBObabRGT7axxvtdWVBGlLkcMPEUscm z1/wROdmWBc++Bl8RTStxd6Uha09eIMAjyQEQX4ziTXKaDxYmXd6+GxMMLfeGq4NTr /VPBw1ONDHpVj9HIU9+xu0dszvl3HYPX4trFXga12caxdV1SvGRwvHYGXlflswob9B voCsdvkz9L1yPe4YSGY8wYJAwZ1V5WzTuoBiR6UGQ0BMsgEyzYE0owJcbjpu1ACcxB /f2KsTo3K+PKNnimWlx7QDcHaBOuHTTa1+dq7tlQ23S/zthD3ig6Z6dPQ+w67wxknM Ou0tWlwB+8u5g== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vy674-0000000043U-3iYQ; Thu, 05 Mar 2026 11:39:26 +0100 From: Johan Hovold To: Sean Young , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/4] media: go7007-loader: drop redundant device reference Date: Thu, 5 Mar 2026 11:39:18 +0100 Message-ID: <20260305103919.15560-4-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260305103919.15560-1-johan@kernel.org> References: <20260305103919.15560-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/media/usb/go7007/go7007-loader.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/usb/go7007/go7007-loader.c b/drivers/media/usb/go7007/go7007-loader.c index 243aa0ad074c..5747e6e4f2d6 100644 --- a/drivers/media/usb/go7007/go7007-loader.c +++ b/drivers/media/usb/go7007/go7007-loader.c @@ -41,9 +41,7 @@ static int go7007_loader_probe(struct usb_interface *interface, int ret; int i; - usbdev = usb_get_dev(interface_to_usbdev(interface)); - if (!usbdev) - goto failed2; + usbdev = interface_to_usbdev(interface); if (usbdev->descriptor.bNumConfigurations != 1) { dev_err(&interface->dev, "can't handle multiple config\n"); @@ -96,7 +94,6 @@ static int go7007_loader_probe(struct usb_interface *interface, return 0; failed2: - usb_put_dev(usbdev); dev_err(&interface->dev, "probe failed\n"); return -ENODEV; } @@ -104,7 +101,6 @@ static int go7007_loader_probe(struct usb_interface *interface, static void go7007_loader_disconnect(struct usb_interface *interface) { dev_info(&interface->dev, "disconnect\n"); - usb_put_dev(interface_to_usbdev(interface)); usb_set_intfdata(interface, NULL); } -- 2.52.0