[PATCH] media: synopsys: fix link failure against GENERIC_PHY_MIPI_DPHY

[PATCH] media: synopsys: fix link failure against GENERIC_PHY_MIPI_DPHY

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The newly added driver uses the generic mipi dphy driver but is missing
a Kconfig dependency:

ld.lld-22: error: undefined symbol: phy_mipi_dphy_get_default_config_for_hsclk
>>> referenced by dw-mipi-csi2rx.c:240 (/home/arnd/arm-soc/drivers/media/platform/synopsys/dw-mipi-csi2rx.c:240)
>>>               drivers/media/platform/synopsys/dw-mipi-csi2rx.o:(dw_mipi_csi2rx_enable_streams) in archive vmlinux.a

This is in a library module that needs to be selected by each user, so
add the missing 'select' here.

Fixes: 355a11004066 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/media/platform/synopsys/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
index e798ec00b189..bf2ac092fbb3 100644
--- a/drivers/media/platform/synopsys/Kconfig
+++ b/drivers/media/platform/synopsys/Kconfig
@@ -7,6 +7,7 @@ config VIDEO_DW_MIPI_CSI2RX
 	depends on VIDEO_DEV
 	depends on V4L_PLATFORM_DRIVERS
 	depends on PM && COMMON_CLK
+	select GENERIC_PHY_MIPI_DPHY
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
-- 
2.39.5

Re: [PATCH] media: synopsys: fix link failure against GENERIC_PHY_MIPI_DPHY

[Michael Riesch]

Hi Arnd,

On 3/6/26 15:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver uses the generic mipi dphy driver but is missing
> a Kconfig dependency:
> 
> ld.lld-22: error: undefined symbol: phy_mipi_dphy_get_default_config_for_hsclk
>>>> referenced by dw-mipi-csi2rx.c:240 (/home/arnd/arm-soc/drivers/media/platform/synopsys/dw-mipi-csi2rx.c:240)
>>>>               drivers/media/platform/synopsys/dw-mipi-csi2rx.o:(dw_mipi_csi2rx_enable_streams) in archive vmlinux.a
> 
> This is in a library module that needs to be selected by each user, so
> add the missing 'select' here.
> 
> Fixes: 355a11004066 ("media: synopsys: add driver for the designware mipi csi-2 receiver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for the patch, but this issue has been addressed here [0] and I
think Sakari has applied this series already.

Best regards,
Michael

> ---
>  drivers/media/platform/synopsys/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
> index e798ec00b189..bf2ac092fbb3 100644
> --- a/drivers/media/platform/synopsys/Kconfig
> +++ b/drivers/media/platform/synopsys/Kconfig
> @@ -7,6 +7,7 @@ config VIDEO_DW_MIPI_CSI2RX
>  	depends on VIDEO_DEV
>  	depends on V4L_PLATFORM_DRIVERS
>  	depends on PM && COMMON_CLK
> +	select GENERIC_PHY_MIPI_DPHY
>  	select MEDIA_CONTROLLER
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API

[0]
https://lore.kernel.org/all/20260216-snps-csi2rx-v1-0-747bc7408f87@collabora.com/