From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77BD53EF0B0; Fri, 6 Mar 2026 16:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772814967; cv=none; b=iRysyB+i1u+SE1VkBGk6ZuSNzvxT3GmAQmDyjJPJ+pM6GCG1ZOqj8tx7kMUkyRzhixfvu7FTva4F7EgK71ULKJ3/Tq7yV3sS6xjhrpUEx1HnN1IOawPuFkjuE7sx6QH75g5BDm8KsB7ucUvJBdZShzaf1obReFGXvp/hZbFzZFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772814967; c=relaxed/simple; bh=IznfVUgNhWMJHCpKhtlk6Ijt6BIL4HKZTTbBUveC/AA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rN2602y49KnusbAf8jgR45YUHjf/kHTzoPmF6iDWARoQeA6ZTzx08ZPi31EN+qgqW5yUQ8/cDyzhOeoum3kYaVd7XHlcSPWffc8e9yIHH87l4QBjGXXkMHji/lUANRE5pkaemIfG+f4YobdU1oPGPXiDqCaP2mKpZB1ZvSynEEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EIq1/DEl; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EIq1/DEl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772814966; x=1804350966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IznfVUgNhWMJHCpKhtlk6Ijt6BIL4HKZTTbBUveC/AA=; b=EIq1/DElI5tgdIrVlxE/KNatHQ3WT98Fd/q1Q1QHNQNwzgWLKhj/FIK2 yZQE/IWoeV6b14J/ramfhaoRu5RIMHUHbUw5Iw7UOVWrTNvn36Vju2UvQ NtlH4xoKGQhHBiMbDbjhx84cfneXSC73GzNh2Twf2LRK+Na7Rmza6kRg9 Z0hCwghzwlbHAFzI6EZFMk4p8FdDZPN4EyttDKS92zqTl4/KkJ/Dpywjv r7UfkBu3jIzljWQjf1U9yj+hYvBivhU1T3/+4lZIoXAJfEEh9AO3DFmsE 439vgB5jbEbVKq/hNN+dXFqG2PPpBBZMaMXkBCLwBG07wrntftPnb+2gh Q==; X-CSE-ConnectionGUID: 3eq+QbqMQ/GlFC3VK2x3ig== X-CSE-MsgGUID: VIIV1msWQK2kWM/vZdv7Fw== X-IronPort-AV: E=McAfee;i="6800,10657,11721"; a="77773874" X-IronPort-AV: E=Sophos;i="6.23,105,1770624000"; d="scan'208";a="77773874" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 08:36:05 -0800 X-CSE-ConnectionGUID: uWIxboNvSACZLJSgy4xGIA== X-CSE-MsgGUID: WAle/WahQuKekHk27J6cWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,105,1770624000"; d="scan'208";a="219180586" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by orviesa007.jf.intel.com with ESMTP; 06 Mar 2026 08:36:03 -0800 From: Arun T To: arun.t@intel.com, johannes.goede@oss.qualcomm.com Cc: sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: [PATCH v4 2/2] media: i2c: ov13b10: support tps68470 regulator and gpio Date: Fri, 6 Mar 2026 22:00:19 +0530 Message-ID: <20260306163019.1619490-3-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306163019.1619490-1-arun.t@intel.com> References: <20260306163019.1619490-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The OV13B10 sensor obtains clock and regulators from the TPS68470 PMIC. Add TPS68470 regulator and GPIO names to the sensor power on Signed-off-by: Arun T --- drivers/media/i2c/ov13b10.c | 47 ++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c index 5421874732bc..4b7b17afb64c 100644 --- a/drivers/media/i2c/ov13b10.c +++ b/drivers/media/i2c/ov13b10.c @@ -3,6 +3,7 @@ #include #include +#include #include #include #include @@ -699,6 +700,12 @@ static const struct ov13b10_mode supported_2_lanes_modes[] = { }, }; +static const char * const ov13b10_supply_names[] = { + "dovdd", /* Digital I/O power */ + "avdd", /* Analog power */ + "dvdd", /* Digital core power */ +}; + struct ov13b10 { struct device *dev; @@ -708,7 +715,7 @@ struct ov13b10 { struct v4l2_ctrl_handler ctrl_handler; struct clk *img_clk; - struct regulator *avdd; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov13b10_supply_names)]; struct gpio_desc *reset; /* V4L2 Controls */ @@ -1194,9 +1201,8 @@ static int ov13b10_power_off(struct device *dev) struct ov13b10 *ov13b10 = to_ov13b10(sd); gpiod_set_value_cansleep(ov13b10->reset, 1); - - if (ov13b10->avdd) - regulator_disable(ov13b10->avdd); + regulator_bulk_disable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); clk_disable_unprepare(ov13b10->img_clk); @@ -1214,14 +1220,12 @@ static int ov13b10_power_on(struct device *dev) dev_err(dev, "failed to enable imaging clock: %d", ret); return ret; } - - if (ov13b10->avdd) { - ret = regulator_enable(ov13b10->avdd); - if (ret < 0) { - dev_err(dev, "failed to enable avdd: %d", ret); - clk_disable_unprepare(ov13b10->img_clk); - return ret; - } + ret = regulator_bulk_enable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); + if (ret < 0) { + dev_err(dev, "failed to enable regulators\n"); + clk_disable_unprepare(ov13b10->img_clk); + return ret; } gpiod_set_value_cansleep(ov13b10->reset, 0); @@ -1475,7 +1479,8 @@ static int ov13b10_get_pm_resources(struct ov13b10 *ov13b) unsigned long freq; int ret; - ov13b->reset = devm_gpiod_get_optional(ov13b->dev, "reset", GPIOD_OUT_LOW); + ov13b->reset = devm_gpiod_get_optional(ov13b->dev, "reset", + GPIOD_OUT_LOW); if (IS_ERR(ov13b->reset)) return dev_err_probe(ov13b->dev, PTR_ERR(ov13b->reset), "failed to get reset gpio\n"); @@ -1491,15 +1496,15 @@ static int ov13b10_get_pm_resources(struct ov13b10 *ov13b) "external clock %lu is not supported\n", freq); - ov13b->avdd = devm_regulator_get_optional(ov13b->dev, "avdd"); - if (IS_ERR(ov13b->avdd)) { - ret = PTR_ERR(ov13b->avdd); - ov13b->avdd = NULL; - if (ret != -ENODEV) - return dev_err_probe(ov13b->dev, ret, - "failed to get avdd regulator\n"); - } + for (unsigned int i = 0; i < ARRAY_SIZE(ov13b10_supply_names); i++) + ov13b->supplies[i].supply = ov13b10_supply_names[i]; + ret = devm_regulator_bulk_get(ov13b->dev, + ARRAY_SIZE(ov13b10_supply_names), + ov13b->supplies); + if (ret) + return dev_err_probe(ov13b->dev, ret, + "failed to get regulators\n"); return 0; } -- 2.43.0