[sailus-media-tree:cleanup 30/33] drivers/media/i2c/ov9282.c:557:2: error: a label can only be part of a statement and a declaration is not a statement

[sailus-media-tree:cleanup 30/33] drivers/media/i2c/ov9282.c:557:2: error: a label can only be part of a statement and a declaration is not a statement

[kernel test robot]

tree:   git://linuxtv.org/sailus/media_tree.git cleanup
head:   862cacec7d570b9f6c8d60d12b50a210aecd933e
commit: 1f01b1dc2c4922f684a5992e7542cfb03f90223c [30/33] media: i2c: ov9282: Convert to CCI register access helpers
config: microblaze-randconfig-r062-20260306 (https://download.01.org/0day-ci/archive/20260306/202603061953.Dlyggyec-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260306/202603061953.Dlyggyec-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603061953.Dlyggyec-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/i2c/ov9282.c: In function 'ov9282_update_exp_gain':
>> drivers/media/i2c/ov9282.c:557:2: error: a label can only be part of a statement and a declaration is not a statement
     int ret_hold = cci_write(ov9282->regmap, OV9282_REG_HOLD, 0, NULL);
     ^~~


vim +557 drivers/media/i2c/ov9282.c

   523	
   524	/**
   525	 * ov9282_update_exp_gain() - Set updated exposure and gain
   526	 * @ov9282: pointer to ov9282 device
   527	 * @exposure: updated exposure value
   528	 * @gain: updated analog gain value
   529	 *
   530	 * Return: 0 if successful, error code otherwise.
   531	 */
   532	static int ov9282_update_exp_gain(struct ov9282 *ov9282, u32 exposure, u32 gain)
   533	{
   534		int ret;
   535		u32 exposure_us = ov9282_exposure_to_us(ov9282, exposure);
   536	
   537		dev_dbg(ov9282->dev, "Set exp %u (~%u us), analog gain %u",
   538			exposure, exposure_us, gain);
   539	
   540		ret = cci_write(ov9282->regmap, OV9282_REG_HOLD, 0x01, NULL);
   541		if (ret)
   542			return ret;
   543	
   544		ret = cci_write(ov9282->regmap, OV9282_REG_EXPOSURE, exposure << 4, NULL);
   545		if (ret)
   546			goto error_release_group_hold;
   547	
   548		ret = cci_write(ov9282->regmap, OV9282_REG_AGAIN, gain, NULL);
   549		if (ret)
   550			goto error_release_group_hold;
   551	
   552		ret = __v4l2_ctrl_modify_range(ov9282->flash_duration,
   553					       0, exposure_us, 1,
   554					       OV9282_STROBE_FRAME_SPAN_DEFAULT);
   555	
   556	error_release_group_hold:
 > 557		int ret_hold = cci_write(ov9282->regmap, OV9282_REG_HOLD, 0, NULL);
   558	
   559		return ret ? ret : ret_hold;
   560	}
   561	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [sailus-media-tree:cleanup 30/33] drivers/media/i2c/ov9282.c:557:2: error: a label can only be part of a statement and a declaration is not a statement

[Sakari Ailus]

On Fri, Mar 06, 2026 at 07:47:06PM +0800, kernel test robot wrote:
> tree:   git://linuxtv.org/sailus/media_tree.git cleanup
> head:   862cacec7d570b9f6c8d60d12b50a210aecd933e
> commit: 1f01b1dc2c4922f684a5992e7542cfb03f90223c [30/33] media: i2c: ov9282: Convert to CCI register access helpers
> config: microblaze-randconfig-r062-20260306 (https://download.01.org/0day-ci/archive/20260306/202603061953.Dlyggyec-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 8.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260306/202603061953.Dlyggyec-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202603061953.Dlyggyec-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/media/i2c/ov9282.c: In function 'ov9282_update_exp_gain':
> >> drivers/media/i2c/ov9282.c:557:2: error: a label can only be part of a statement and a declaration is not a statement
>      int ret_hold = cci_write(ov9282->regmap, OV9282_REG_HOLD, 0, NULL);
>      ^~~

I moved this to where the rest are declared. No need to resubmit.

-- 
Sakari Ailus