From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5959926B764; Sat, 7 Mar 2026 15:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772897629; cv=none; b=kHvzyGNNSkv60ssXGqjmFAwg/psdpz4B4uwgW5Tunyz+/i31WfloRF4pkNDVHxQvBTRFYqu7OW+Lf4BmBJ48RklBKi9h6TKqE9ruswnsSCEQyCC4MTof9td/SJTb1A+n0bEbOmrU2zUvAUBaJLS359CKxyxll2rFLA16dvigXgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772897629; c=relaxed/simple; bh=LGGa35LUu1Cajfet/gRyfYd8q2l0CArrIN4zoHM0CyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SjRy2eYknWej1mWNwr0gTGLq6Ex6dL6KsNkcwo25XBvIJuDkhC8trNxxy/YNYYtJmcIF5n4lJsfE5Y9rsnmI+PW7H+FSXFC7KKOdpfkSzEx9Mv+BOxwBT1aKXsN2ASpGmaLUr7idQEHyqB7LR86yWWg5xCeWFkrLrLNbQEP2cOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k3hKirZ5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k3hKirZ5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E05C2BCB1; Sat, 7 Mar 2026 15:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772897628; bh=LGGa35LUu1Cajfet/gRyfYd8q2l0CArrIN4zoHM0CyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k3hKirZ50L++Iv7ng1nmAk6Odn124V0dCq62IUqtY+htEN4qYwRrkfTYqm1V8p4OZ 5ts5tRfykMDwcJ2jGmShiFwTEk1z465sj2CgrgddITs6rVoMHxKUBvplkzIjaCtv4u lYIh77SLIXWsVkrfZrHqQU6dJrjBB1MH9UhlEakgd8Cdq86gtMRPoSrFtU220uIgSq xPWbJ04SA9vI2otDejr0A6sF4/vYVH3TIFb0tEsprOtu0nJS9pAG7RxvaF1H+Z+2Se A+htZTgiPiWA+N15RMBcazWW6i3AkvQWbtG5m5V+ln78n7g4qv7hyf7zUcO1Cad0cr piqfWAPSP55AQ== Date: Sat, 7 Mar 2026 16:33:46 +0100 From: Krzysztof Kozlowski To: Michael Riesch Cc: Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Collabora Kernel Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3588 compatible Message-ID: <20260307-complex-finicky-skua-bf52bd@quoll> References: <20260305-rk3588-csi2rx-v1-0-0cd8d2bf28c0@collabora.com> <20260305-rk3588-csi2rx-v1-1-0cd8d2bf28c0@collabora.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260305-rk3588-csi2rx-v1-1-0cd8d2bf28c0@collabora.com> On Fri, Mar 06, 2026 at 03:09:48PM +0100, Michael Riesch wrote: > The RK3588 MIPI CSI-2 receivers are compatible to the ones found in > the RK3568. However, their integration in the respective SoC may be > different when it comes to the (currently not implemented) split All this says they are compatible, so express it. > DPHY feature. Therefore, add the RK3588 compatible to allow for > future differentiation. This I do not understand. If you just copy standard rules from writing-bindings, then no, don't do that. It's obvious and there is never a need to repeat any standard/common rule. If you want to say devices are not compatible, then say that explicitly. Best regards, Krzysztof