From: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
To: hansg@kernel.org, mchehab@kernel.org
Cc: sakari.ailus@linux.intel.com, andy@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
Oskar Ray-Frayssinet <rayfraytech@gmail.com>
Subject: [PATCH] staging: atomisp: fix block comment style in refcount.c
Date: Mon, 9 Mar 2026 22:55:16 +0100 [thread overview]
Message-ID: <20260309215516.6091-1-rayfraytech@gmail.com> (raw)
Fix block comment formatting to comply with kernel coding style:
- Add leading '*' on continuation lines
- Move trailing '*/' to a separate line
- Remove unnecessary braces around single statement block
Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
.../atomisp/pci/base/refcount/src/refcount.c | 29 ++++++++++---------
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
index 58e4e3173b40..00e8a73f413e 100644
--- a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
+++ b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
@@ -16,7 +16,8 @@
#include "ia_css_debug.h"
/* TODO: enable for other memory aswell
- now only for ia_css_ptr */
+ * now only for ia_css_ptr
+ */
struct ia_css_refcount_entry {
u32 count;
ia_css_ptr data;
@@ -93,14 +94,15 @@ void ia_css_refcount_uninit(void)
"%s() entry\n", __func__);
for (i = 0; i < myrefcount.size; i++) {
/* driver verifier tool has issues with &arr[i]
- and prefers arr + i; as these are actually equivalent
- the line below uses + i
- */
+ * and prefers arr + i; as these are actually equivalent
+ * the line below uses + i
+ */
entry = myrefcount.items + i;
if (entry->data != mmgr_NULL) {
/* ia_css_debug_dtrace(IA_CSS_DBG_TRACE,
- "ia_css_refcount_uninit: freeing (%x)\n",
- entry->data);*/
+ * "ia_css_refcount_uninit: freeing (%x)\n",
+ * entry->data);
+ */
hmm_free(entry->data);
entry->data = mmgr_NULL;
entry->count = 0;
@@ -173,7 +175,8 @@ bool ia_css_refcount_decrement(s32 id, ia_css_ptr ptr)
entry->count -= 1;
if (entry->count == 0) {
/* ia_css_debug_dtrace(IA_CSS_DBEUG_TRACE,
- "ia_css_refcount_decrement: freeing\n");*/
+ * "ia_css_refcount_decrement: freeing\n");
+ */
hmm_free(ptr);
entry->data = mmgr_NULL;
entry->id = 0;
@@ -183,7 +186,8 @@ bool ia_css_refcount_decrement(s32 id, ia_css_ptr ptr)
}
/* SHOULD NOT HAPPEN: ptr not managed by refcount, or not
- valid anymore */
+ * valid anymore
+ */
if (entry)
IA_CSS_ERROR("id %x, ptr 0x%x entry %p entry->id %x entry->count %d\n",
id, ptr, entry, entry->id, entry->count);
@@ -221,9 +225,9 @@ void ia_css_refcount_clear(s32 id, clear_func clear_func_ptr)
for (i = 0; i < myrefcount.size; i++) {
/* driver verifier tool has issues with &arr[i]
- and prefers arr + i; as these are actually equivalent
- the line below uses + i
- */
+ * and prefers arr + i; as these are actually equivalent
+ * the line below uses + i
+ */
entry = myrefcount.items + i;
if ((entry->data != mmgr_NULL) && (entry->id == id)) {
ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE,
@@ -238,9 +242,8 @@ void ia_css_refcount_clear(s32 id, clear_func clear_func_ptr)
hmm_free(entry->data);
}
- if (entry->count != 0) {
+ if (entry->count != 0)
IA_CSS_WARNING("Ref count for entry %x is not zero!", entry->id);
- }
assert(entry->count == 0);
--
2.43.0
next reply other threads:[~2026-03-09 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 21:55 Oskar Ray-Frayssinet [this message]
2026-03-10 11:43 ` [PATCH] staging: atomisp: fix block comment style in refcount.c Andy Shevchenko
2026-03-10 20:35 ` [PATCH v2] staging: media: " Oskar Ray-Frayssinet
2026-03-10 22:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309215516.6091-1-rayfraytech@gmail.com \
--to=rayfraytech@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox