From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530A32D7DD4 for ; Tue, 10 Mar 2026 14:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773152691; cv=none; b=eOTK8o50qy2yGqXgoSAt1+OeSNI/LDfWQT4ZSIfx3A9NkXZF1da9Wd3czo6ZNhmbBCCDoK6PJVs2k2nHtaRA7lLM7UKi/sWjyIMXuSt0QVLGwt5Sxctv7GnbwAoQFuuHWyUlim8xcQMyZssLvewQek0xj9XRwvj8PwN/hyS6E6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773152691; c=relaxed/simple; bh=XwidptKIhvR+UF4aaOLrgKMULsgr14IRJkHhby+ViXQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bf000q7eQXj9mIe9YCzr9fQ8LliqInGmBUBnQLqtr6XwNxT+6a3T0SdGb/zjFQvOZgH5pGUTRjyCv3WA7lALQ57QE3itGn9Vb/7p5IF4pr/ATRUZ2JzwgjWzRTVZi5GrBDk8bbAobEFQq5Gj3YDQDfR5WGbsvsUwP226carHwm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=F6C5rtqO; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="F6C5rtqO" Received: from macsyma.thunk.org (pool-173-48-117-133.bstnma.fios.verizon.net [173.48.117.133]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 62AENmx0023256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Mar 2026 10:23:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1773152637; bh=4/p8AtxdJ3b4aYgpRIBgOOPVM9R5HZLzlaxPPsEZ2Q4=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=F6C5rtqODrQpEwdwVTgFCawAhLv3gwk1txjCpTf9qYEhws10oNToQIbXrBSiNnSGn HKzLPM0wlhbQz5hd3KNNbDsKNUIOcLP5D+4J1qJhv/m9AJCmBvmBntSwPXXBcrZ48c UG5I74ocwzVwmg9UHdT0hLejm00ahwJz4Tby2LgiJXvFIYDaYDAoayC1G2vaNRdttd dnaccWPVwGwuO0YYJTFV0/A1hSU2yI/onO0qlICZ11ISIKYrG0S38XY0XZ07wXHuQf SRLcsUXeYesD2NrtHf5Vg5nqM+e/voDzSfyx+6EAL02kYRxR5zwo7A3kwnstvVAN1a N4dmfF0o4YLWg== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 96A8A5C4FCED; Tue, 10 Mar 2026 10:23:48 -0400 (EDT) Date: Tue, 10 Mar 2026 10:23:48 -0400 From: "Theodore Tso" To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Julia Lawall , Nicolas Palix , Chris Mason , David Sterba , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Andreas Dilger , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Miklos Szeredi , Konstantin Komarov , Andreas Gruenbacher , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Jan Kara , Phillip Lougher , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Tejun Heo , David Vernet , Andrea Righi , Changwoo Min , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Max Filippov , Paolo Bonzini , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Jamal Hadi Salim , Jiri Pirko , Marcelo Ricardo Leitner , Xin Long , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Jon Maloy , Johannes Berg , Catalin Marinas , Russell King , John Crispin , Thomas Bogendoerfer , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Igor Russkikh , Andrew Lunn , Pavan Chebbi , Michael Chan , Potnuri Bharat Teja , Tony Nguyen , Przemek Kitszel , Taras Chornyi , Maxime Coquelin , Alexandre Torgue , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Heiner Kallweit , Marc Zyngier , Thomas Gleixner , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vinod Koul , Linus Walleij , Ulf Hansson , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Martin K. Petersen" , Eduardo Valentin , Keerthy , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alex Williamson , Mark Greer , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Shuah Khan , Kieran Bingham , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Lee Jones , Pavel Machek , Dave Penkler , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Justin Sanders , Jens Axboe , Georgi Djakov , Michael Turquette , Stephen Boyd , Philipp Zabel , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pali =?iso-8859-1?Q?Roh=E1r?= , Dmitry Torokhov Subject: Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor Message-ID: <20260310142348.GA41218@macsyma-wired.lan> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> On Tue, Mar 10, 2026 at 12:48:26PM +0100, Philipp Hahn wrote: > While doing some static code analysis I stumbled over a common pattern, > where IS_ERR() is combined with a NULL check. For that there is > IS_ERR_OR_NULL(). > > I've written a Coccinelle patch to find and patch those instances. > The patches follow grouped by subsystem. I'm going to gently suggest that you *not* try to do this as a tree-wide change, since we don't need to change some interface requiring a global, flag day change. This is instead a cleanup, which maybe makes the code slightly better, but which also has a the downside of breaking lots of inflight development patches by potentially causing merge or patch conflicts. So why don't you send it to each subsystem as a separate patch or small patch series, instead of spamming a dozen-plus mailing lists, are probably hundreds of developers, most of whom aren't going to care about changs in some far flung part of the kernel? Regards, - Ted