From: Lin YuChen <starpt.official@gmail.com>
To: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
gregkh@linuxfoundation.org
Cc: sakari.ailus@linux.intel.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
starpt.official@gmail.com
Subject: [PATCH v3] staging: media: atomisp: use kmalloc_array() for sh_css_blob_info
Date: Sat, 14 Mar 2026 01:55:26 +0800 [thread overview]
Message-ID: <20260313175526.14974-1-starpt.official@gmail.com> (raw)
In-Reply-To: <abQ1nYvEpKV-rkL8@ashevche-desk.local>
Replace the open-coded multiplication in kmalloc() with kmalloc_array()
to provide overflow protection and improve code readability.
Signed-off-by: Lin YuChen <starpt.official@gmail.com>
---
v3:
- Resend as a single patch to fix the incorrect versioning and
numbering (1/2, 2/2) in the previous submission.
v2:
- Remove unnecessary parentheses in kmalloc_array() call as suggested
by Andy Shevchenko.
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index 57ecf5549c23..af12df2f9b09 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -253,9 +253,9 @@ sh_css_load_firmware(struct device *dev, const char *fw_data,
sh_css_num_binaries = file_header->binary_nr;
/* Only allocate memory for ISP blob info */
if (sh_css_num_binaries > NUM_OF_SPS) {
- sh_css_blob_info = kmalloc(
- (sh_css_num_binaries - NUM_OF_SPS) *
- sizeof(*sh_css_blob_info), GFP_KERNEL);
+ sh_css_blob_info =
+ kmalloc_array(sh_css_num_binaries - NUM_OF_SPS,
+ sizeof(*sh_css_blob_info), GFP_KERNEL);
if (!sh_css_blob_info)
return -ENOMEM;
} else {
--
2.34.1
prev parent reply other threads:[~2026-03-13 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 15:29 [PATCH 2/2] staging: media: atomisp: use kmalloc_array() for sh_css_blob_info Lin YuChen
2026-03-13 16:04 ` Andy Shevchenko
2026-03-13 17:46 ` YuChen Lin
2026-03-13 17:55 ` Lin YuChen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313175526.14974-1-starpt.official@gmail.com \
--to=starpt.official@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox