[PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Krzysztof Kozlowski]

The "endpoint" node references video-interfaces.yaml schema with
"unevaluatedProperties: false" which means that all properties from
referenced schema apply.  Listing some of them with ": true" is simply
redundant and does not make this code easier to read.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 .../bindings/media/i2c/alliedvision,alvium-csi2.yaml      | 2 --
 .../devicetree/bindings/media/i2c/galaxycore,gc0308.yaml  | 8 --------
 .../devicetree/bindings/media/i2c/galaxycore,gc2145.yaml  | 3 ---
 .../devicetree/bindings/media/i2c/maxim,max9286.yaml      | 3 ---
 .../devicetree/bindings/media/i2c/maxim,max96712.yaml     | 1 -
 Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 2 --
 .../devicetree/bindings/media/i2c/ovti,og01a1b.yaml       | 2 --
 .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml       | 1 -
 .../devicetree/bindings/media/i2c/ovti,ov5647.yaml        | 3 ---
 .../devicetree/bindings/media/i2c/ovti,ov5648.yaml        | 2 --
 .../devicetree/bindings/media/i2c/ovti,ov5675.yaml        | 4 +---
 .../devicetree/bindings/media/i2c/ovti,ov7251.yaml        | 2 --
 .../devicetree/bindings/media/i2c/ovti,ov8865.yaml        | 2 --
 .../devicetree/bindings/media/i2c/ovti,ov9282.yaml        | 4 ----
 .../devicetree/bindings/media/i2c/sony,imx334.yaml        | 4 ----
 .../devicetree/bindings/media/i2c/sony,imx412.yaml        | 4 ----
 .../devicetree/bindings/media/i2c/toshiba,tc358746.yaml   | 5 -----
 17 files changed, 1 insertion(+), 51 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml b/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
index d3329e991d16..c2ae33532700 100644
--- a/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
@@ -35,8 +35,6 @@ properties:
         unevaluatedProperties: false
 
         properties:
-          link-frequencies: true
-
           data-lanes:
             minItems: 1
             items:
diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
index 2bf1a81feaf4..fcf79f4c5a0d 100644
--- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
@@ -53,14 +53,6 @@ properties:
         $ref: /schemas/media/video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          bus-width: true
-          data-shift: true
-          hsync-active: true
-          vsync-active: true
-          data-active: true
-          pclk-sample: true
-
         required:
           - bus-width
 
diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
index 9eac588de0bc..ccac2cb85d57 100644
--- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
@@ -58,9 +58,6 @@ properties:
         $ref: /schemas/media/video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          link-frequencies: true
-
         required:
           - link-frequencies
 
diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
index a37447256f8d..d806b821dae3 100644
--- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
@@ -137,9 +137,6 @@ properties:
             $ref: /schemas/media/video-interfaces.yaml#
             unevaluatedProperties: false
 
-            properties:
-              data-lanes: true
-
             required:
               - data-lanes
 
diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
index 26f85151afbd..4b9afc73de62 100644
--- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
@@ -67,7 +67,6 @@ properties:
             unevaluatedProperties: false
 
             properties:
-              data-lanes: true
               bus-type:
                 enum:
                   - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
index 217b08c8cbbd..9ba8a17c62e0 100644
--- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
@@ -78,8 +78,6 @@ properties:
         unevaluatedProperties: false
 
         properties:
-          link-frequencies: true
-          data-lanes: true
           bus-type:
             enum:
               - 1 # CSI-2 C-PHY
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml
index ca57c01739d2..efdac2e91589 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml
@@ -64,8 +64,6 @@ properties:
             items:
               enum: [1, 2]
 
-          link-frequencies: true
-
         required:
           - data-lanes
           - link-frequencies
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
index 0e1d9c390180..b98260d5e6a3 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
@@ -81,7 +81,6 @@ properties:
         unevaluatedProperties: false
 
         properties:
-          link-frequencies: true
           ovti,mipi-clock-voltage:
             $ref: /schemas/types.yaml#/definitions/uint32
             description:
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
index 2d7937a372a2..7a05a1eda58d 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
@@ -51,9 +51,6 @@ properties:
         $ref: /schemas/media/video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          clock-noncontinuous: true
-
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
index 8028c8b107c4..ec53e55b2290 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
@@ -48,8 +48,6 @@ properties:
         unevaluatedProperties: false
 
         properties:
-          link-frequencies: true
-
           data-lanes:
             minItems: 1
             maxItems: 2
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml
index ad07204057f9..90b2c6d35df6 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml
@@ -21,6 +21,7 @@ description: |
 
   This chip is programmable through I2C and two-wire SCCB. The sensor output
   is available via CSI-2 serial data output (up to 2-lane).
+  It supports max data transfer of 900 Mbps per lane.
 
 properties:
   compatible:
@@ -67,9 +68,6 @@ properties:
             minItems: 1
             maxItems: 2
 
-          # Supports max data transfer of 900 Mbps per lane
-          link-frequencies: true
-
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
index 922996da59b2..0ad271a4bf39 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
@@ -63,8 +63,6 @@ properties:
           data-lanes:
             maxItems: 1
 
-          link-frequencies: true
-
         required:
           - data-lanes
           - link-frequencies
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
index 320b9aacbb8b..c535a5257a3e 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
@@ -48,8 +48,6 @@ properties:
         unevaluatedProperties: false
 
         properties:
-          link-frequencies: true
-
           data-lanes:
             minItems: 1
             maxItems: 4
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
index 401c8613f840..20dc0885e30e 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
@@ -53,10 +53,6 @@ properties:
         $ref: /schemas/media/video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          data-lanes: true
-          link-frequencies: true
-
         required:
           - data-lanes
           - link-frequencies
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
index 3842e5130463..e90ebe6a0a24 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
@@ -40,10 +40,6 @@ properties:
         $ref: /schemas/media/video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          data-lanes: true
-          link-frequencies: true
-
         required:
           - data-lanes
           - link-frequencies
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
index 5447ab0768a6..dec428d46937 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
@@ -52,10 +52,6 @@ properties:
         $ref: /schemas/media/video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          data-lanes: true
-          link-frequencies: true
-
         required:
           - data-lanes
           - link-frequencies
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
index 1c476b635b69..505c6d22ef7c 100644
--- a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
@@ -78,8 +78,6 @@ properties:
             unevaluatedProperties: false
 
             properties:
-              hsync-active: true
-              vsync-active: true
               bus-type:
                 enum: [ 5, 6 ]
 
@@ -103,9 +101,6 @@ properties:
                 minItems: 1
                 maxItems: 4
 
-              clock-noncontinuous: true
-              link-frequencies: true
-
             required:
               - data-lanes
               - link-frequencies
-- 
2.51.0

[PATCH 2/2] media: dt-bindings: Drop redundant endpoint properties

[Krzysztof Kozlowski]

The "endpoint" node references video-interfaces.yaml schema with
"unevaluatedProperties: false" which means that all properties from
referenced schema apply.  Listing some of them with ": true" is simply
redundant and does not make this code easier to read.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 .../devicetree/bindings/media/marvell,mmp2-ccic.yaml        | 6 ------
 Documentation/devicetree/bindings/media/renesas,ceu.yaml    | 3 ---
 .../devicetree/bindings/media/renesas,rzg2l-cru.yaml        | 6 ------
 3 files changed, 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
index de3e483f146a..a8bf06108158 100644
--- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
+++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
@@ -35,12 +35,6 @@ properties:
         $ref: video-interfaces.yaml#
         unevaluatedProperties: false
 
-        properties:
-          hsync-active: true
-          vsync-active: true
-          pclk-sample: true
-          bus-type: true
-
   clocks:
     minItems: 1
     items:
diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
index d527fc42c3fd..5f78c77b10a3 100644
--- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
@@ -43,9 +43,6 @@ properties:
         unevaluatedProperties: false
 
         properties:
-          hsync-active: true
-          vsync-active: true
-          field-even-active: false
           bus-width:
             enum: [8, 16]
             default: 8
diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
index 47e18690fa57..c1b81416bd85 100644
--- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml
@@ -95,12 +95,6 @@ properties:
             $ref: video-interfaces.yaml#
             unevaluatedProperties: false
 
-            properties:
-              hsync-active: true
-              vsync-active: true
-              bus-width: true
-              data-shift: true
-
       port@1:
         $ref: /schemas/graph.yaml#/properties/port
         description:
-- 
2.51.0

Re: [PATCH 2/2] media: dt-bindings: Drop redundant endpoint properties

[Krzysztof Kozlowski]

On 16/03/2026 14:45, Krzysztof Kozlowski wrote:
> The "endpoint" node references video-interfaces.yaml schema with
> "unevaluatedProperties: false" which means that all properties from
> referenced schema apply.  Listing some of them with ": true" is simply
> redundant and does not make this code easier to read.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/media/marvell,mmp2-ccic.yaml        | 6 ------
>  Documentation/devicetree/bindings/media/renesas,ceu.yaml    | 3 ---
>  .../devicetree/bindings/media/renesas,rzg2l-cru.yaml        | 6 ------
>  3 files changed, 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> index de3e483f146a..a8bf06108158 100644
> --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> @@ -35,12 +35,6 @@ properties:
>          $ref: video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          hsync-active: true
> -          vsync-active: true
> -          pclk-sample: true
> -          bus-type: true
> -
>    clocks:
>      minItems: 1
>      items:
> diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> index d527fc42c3fd..5f78c77b10a3 100644
> --- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> @@ -43,9 +43,6 @@ properties:
>          unevaluatedProperties: false
>  
>          properties:
> -          hsync-active: true
> -          vsync-active: true
> -          field-even-active: false

Removed too much, this must stay.

>            bus-width:
>              enum: [8, 16]

Best regards,
Krzysztof

Re: [PATCH 2/2] media: dt-bindings: Drop redundant endpoint properties

[Laurent Pinchart]

On Mon, Mar 16, 2026 at 07:08:01PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2026 14:45, Krzysztof Kozlowski wrote:
> > The "endpoint" node references video-interfaces.yaml schema with
> > "unevaluatedProperties: false" which means that all properties from
> > referenced schema apply.  Listing some of them with ": true" is simply
> > redundant and does not make this code easier to read.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> >  .../devicetree/bindings/media/marvell,mmp2-ccic.yaml        | 6 ------
> >  Documentation/devicetree/bindings/media/renesas,ceu.yaml    | 3 ---
> >  .../devicetree/bindings/media/renesas,rzg2l-cru.yaml        | 6 ------
> >  3 files changed, 15 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > index de3e483f146a..a8bf06108158 100644
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -35,12 +35,6 @@ properties:
> >          $ref: video-interfaces.yaml#
> >          unevaluatedProperties: false
> >  
> > -        properties:
> > -          hsync-active: true
> > -          vsync-active: true
> > -          pclk-sample: true
> > -          bus-type: true
> > -
> >    clocks:
> >      minItems: 1
> >      items:
> > diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> > index d527fc42c3fd..5f78c77b10a3 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> > @@ -43,9 +43,6 @@ properties:
> >          unevaluatedProperties: false
> >  
> >          properties:
> > -          hsync-active: true
> > -          vsync-active: true
> > -          field-even-active: false
> 
> Removed too much, this must stay.

Disabling properties not relevant for a device doesn't scale. You would
need to disable way more than that one here. The better option is to use
"additionalProperties: false" and list the allowed properties.

> 
> >            bus-width:
> >              enum: [8, 16]

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Laurent Pinchart]

Hello Krzysztof,

Thank you for the patch.

On Mon, Mar 16, 2026 at 02:45:34PM +0100, Krzysztof Kozlowski wrote:
> The "endpoint" node references video-interfaces.yaml schema with
> "unevaluatedProperties: false" which means that all properties from
> referenced schema apply.  Listing some of them with ": true" is simply
> redundant and does not make this code easier to read.

I think you know my opinion on this topic. I believe we would be better
off by turning "unevaluatedProperties: false" into
"additionalProperties: false" here, and keeping the list of applicable
properties. It brings value to device tree authors by telling which
properties are applicable to the device at hand. For instance ... (see
below)

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  .../bindings/media/i2c/alliedvision,alvium-csi2.yaml      | 2 --
>  .../devicetree/bindings/media/i2c/galaxycore,gc0308.yaml  | 8 --------
>  .../devicetree/bindings/media/i2c/galaxycore,gc2145.yaml  | 3 ---
>  .../devicetree/bindings/media/i2c/maxim,max9286.yaml      | 3 ---
>  .../devicetree/bindings/media/i2c/maxim,max96712.yaml     | 1 -
>  Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 2 --
>  .../devicetree/bindings/media/i2c/ovti,og01a1b.yaml       | 2 --
>  .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml       | 1 -
>  .../devicetree/bindings/media/i2c/ovti,ov5647.yaml        | 3 ---
>  .../devicetree/bindings/media/i2c/ovti,ov5648.yaml        | 2 --
>  .../devicetree/bindings/media/i2c/ovti,ov5675.yaml        | 4 +---
>  .../devicetree/bindings/media/i2c/ovti,ov7251.yaml        | 2 --
>  .../devicetree/bindings/media/i2c/ovti,ov8865.yaml        | 2 --
>  .../devicetree/bindings/media/i2c/ovti,ov9282.yaml        | 4 ----
>  .../devicetree/bindings/media/i2c/sony,imx334.yaml        | 4 ----
>  .../devicetree/bindings/media/i2c/sony,imx412.yaml        | 4 ----
>  .../devicetree/bindings/media/i2c/toshiba,tc358746.yaml   | 5 -----
>  17 files changed, 1 insertion(+), 51 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml b/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
> index d3329e991d16..c2ae33532700 100644
> --- a/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
> @@ -35,8 +35,6 @@ properties:
>          unevaluatedProperties: false
>  
>          properties:
> -          link-frequencies: true
> -
>            data-lanes:
>              minItems: 1
>              items:
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
> index 2bf1a81feaf4..fcf79f4c5a0d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
> @@ -53,14 +53,6 @@ properties:
>          $ref: /schemas/media/video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          bus-width: true
> -          data-shift: true
> -          hsync-active: true
> -          vsync-active: true
> -          data-active: true
> -          pclk-sample: true
> -
>          required:
>            - bus-width
>  
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> index 9eac588de0bc..ccac2cb85d57 100644
> --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> @@ -58,9 +58,6 @@ properties:
>          $ref: /schemas/media/video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          link-frequencies: true
> -
>          required:
>            - link-frequencies
>  
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index a37447256f8d..d806b821dae3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -137,9 +137,6 @@ properties:
>              $ref: /schemas/media/video-interfaces.yaml#
>              unevaluatedProperties: false
>  
> -            properties:
> -              data-lanes: true
> -
>              required:
>                - data-lanes
>  
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index 26f85151afbd..4b9afc73de62 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -67,7 +67,6 @@ properties:
>              unevaluatedProperties: false
>  
>              properties:
> -              data-lanes: true
>                bus-type:
>                  enum:
>                    - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> index 217b08c8cbbd..9ba8a17c62e0 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> @@ -78,8 +78,6 @@ properties:
>          unevaluatedProperties: false
>  
>          properties:
> -          link-frequencies: true
> -          data-lanes: true
>            bus-type:
>              enum:
>                - 1 # CSI-2 C-PHY
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml
> index ca57c01739d2..efdac2e91589 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,og01a1b.yaml
> @@ -64,8 +64,6 @@ properties:
>              items:
>                enum: [1, 2]
>  
> -          link-frequencies: true
> -
>          required:
>            - data-lanes
>            - link-frequencies
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
> index 0e1d9c390180..b98260d5e6a3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
> @@ -81,7 +81,6 @@ properties:
>          unevaluatedProperties: false
>  
>          properties:
> -          link-frequencies: true
>            ovti,mipi-clock-voltage:
>              $ref: /schemas/types.yaml#/definitions/uint32
>              description:
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> index 2d7937a372a2..7a05a1eda58d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> @@ -51,9 +51,6 @@ properties:
>          $ref: /schemas/media/video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          clock-noncontinuous: true
> -

... Without this, an integrator will need to dive into driver code to
know if non-continuous clock is usable for the device.

>  required:
>    - compatible
>    - reg
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> index 8028c8b107c4..ec53e55b2290 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> @@ -48,8 +48,6 @@ properties:
>          unevaluatedProperties: false
>  
>          properties:
> -          link-frequencies: true
> -
>            data-lanes:
>              minItems: 1
>              maxItems: 2
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml
> index ad07204057f9..90b2c6d35df6 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml
> @@ -21,6 +21,7 @@ description: |
>  
>    This chip is programmable through I2C and two-wire SCCB. The sensor output
>    is available via CSI-2 serial data output (up to 2-lane).
> +  It supports max data transfer of 900 Mbps per lane.
>  
>  properties:
>    compatible:
> @@ -67,9 +68,6 @@ properties:
>              minItems: 1
>              maxItems: 2
>  
> -          # Supports max data transfer of 900 Mbps per lane
> -          link-frequencies: true
> -
>  required:
>    - compatible
>    - reg
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
> index 922996da59b2..0ad271a4bf39 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
> @@ -63,8 +63,6 @@ properties:
>            data-lanes:
>              maxItems: 1
>  
> -          link-frequencies: true
> -
>          required:
>            - data-lanes
>            - link-frequencies
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> index 320b9aacbb8b..c535a5257a3e 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> @@ -48,8 +48,6 @@ properties:
>          unevaluatedProperties: false
>  
>          properties:
> -          link-frequencies: true
> -
>            data-lanes:
>              minItems: 1
>              maxItems: 4
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> index 401c8613f840..20dc0885e30e 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> @@ -53,10 +53,6 @@ properties:
>          $ref: /schemas/media/video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          data-lanes: true
> -          link-frequencies: true
> -
>          required:
>            - data-lanes
>            - link-frequencies
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> index 3842e5130463..e90ebe6a0a24 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> @@ -40,10 +40,6 @@ properties:
>          $ref: /schemas/media/video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          data-lanes: true
> -          link-frequencies: true
> -
>          required:
>            - data-lanes
>            - link-frequencies
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> index 5447ab0768a6..dec428d46937 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> @@ -52,10 +52,6 @@ properties:
>          $ref: /schemas/media/video-interfaces.yaml#
>          unevaluatedProperties: false
>  
> -        properties:
> -          data-lanes: true
> -          link-frequencies: true
> -
>          required:
>            - data-lanes
>            - link-frequencies
> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
> index 1c476b635b69..505c6d22ef7c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml
> @@ -78,8 +78,6 @@ properties:
>              unevaluatedProperties: false
>  
>              properties:
> -              hsync-active: true
> -              vsync-active: true
>                bus-type:
>                  enum: [ 5, 6 ]
>  
> @@ -103,9 +101,6 @@ properties:
>                  minItems: 1
>                  maxItems: 4
>  
> -              clock-noncontinuous: true
> -              link-frequencies: true
> -
>              required:
>                - data-lanes
>                - link-frequencies

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Krzysztof Kozlowski]

On 16/03/2026 14:53, Laurent Pinchart wrote:
> Hello Krzysztof,
> 
> Thank you for the patch.
> 
> On Mon, Mar 16, 2026 at 02:45:34PM +0100, Krzysztof Kozlowski wrote:
>> The "endpoint" node references video-interfaces.yaml schema with
>> "unevaluatedProperties: false" which means that all properties from
>> referenced schema apply.  Listing some of them with ": true" is simply
>> redundant and does not make this code easier to read.
> 
> I think you know my opinion on this topic. I believe we would be better
> off by turning "unevaluatedProperties: false" into
> "additionalProperties: false" here, and keeping the list of applicable
> properties. It brings value to device tree authors by telling which
> properties are applicable to the device at hand. For instance ... (see
> below)


(let me trim)

>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
>> index 2d7937a372a2..7a05a1eda58d 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
>> @@ -51,9 +51,6 @@ properties:
>>          $ref: /schemas/media/video-interfaces.yaml#
>>          unevaluatedProperties: false
>>  
>> -        properties:
>> -          clock-noncontinuous: true
>> -
> 
> ... Without this, an integrator will need to dive into driver code to
> know if non-continuous clock is usable for the device.

I see. Our usual interpretation of common schema, expressed by @Rob in
few places, that eventually all properties might be applicable. This
applies especially for ABI tied to the core Linux specifics, e.g.
rotation and orientation from video-interface-devices.yaml.

Absolutely every sensor can be mounted rotated, therefore every binding
referencing video-interface-devices should allow it, even if driver is
not using it. Because basically that's the ABI we want to define for
each sensor, thus each binding referencing common schema should have
"unevaluatedProps: true" without listing them.

Similarly touchscreen.yaml.

OTOH, second option, properties which are strictly hardware, e.g. name
of power supply or whether clock has or has not non-continuous mode,
should be allowed only when they match the hardware. Such bindings
should use "additionalProperties: false" so the hardware description is
constrained/fixed/specific.

The only exception is trivial-devices.

To the point:

1. We should not have another exception of listing hardware properties
and allowing them for every device, even if device does not have.

2. What's more, you propose unwritten coding style
(unevaluatedProps:false with listing properties when you want to
indicate hardware capability) which will be very difficult to implement.
I doubt that existing bindings, except a few, follow such approach. I
doubt we will remember this... And it already spreads to new bindings
when I ask to remove redundant "foo: true" properties.

3. These sensor bindings should follow only one of mentioned earlier
options - additionalProps or unevaluatedProps - because either these are
hardware properties or this is generic kernel ABI which everyone
will/could use.

Best regards,
Krzysztof

Re: [PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Sakari Ailus]

Hi Krzysztof, Laurent,

On Mon, Mar 16, 2026 at 03:42:09PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2026 14:53, Laurent Pinchart wrote:
> > Hello Krzysztof,
> > 
> > Thank you for the patch.
> > 
> > On Mon, Mar 16, 2026 at 02:45:34PM +0100, Krzysztof Kozlowski wrote:
> >> The "endpoint" node references video-interfaces.yaml schema with
> >> "unevaluatedProperties: false" which means that all properties from
> >> referenced schema apply.  Listing some of them with ": true" is simply
> >> redundant and does not make this code easier to read.
> > 
> > I think you know my opinion on this topic. I believe we would be better
> > off by turning "unevaluatedProperties: false" into
> > "additionalProperties: false" here, and keeping the list of applicable
> > properties. It brings value to device tree authors by telling which
> > properties are applicable to the device at hand. For instance ... (see
> > below)
> 
> (let me trim)
> 
> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> >> index 2d7937a372a2..7a05a1eda58d 100644
> >> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> >> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> >> @@ -51,9 +51,6 @@ properties:
> >>          $ref: /schemas/media/video-interfaces.yaml#
> >>          unevaluatedProperties: false
> >>  
> >> -        properties:
> >> -          clock-noncontinuous: true
> >> -
> > 
> > ... Without this, an integrator will need to dive into driver code to
> > know if non-continuous clock is usable for the device.
> 
> I see. Our usual interpretation of common schema, expressed by @Rob in
> few places, that eventually all properties might be applicable. This
> applies especially for ABI tied to the core Linux specifics, e.g.
> rotation and orientation from video-interface-devices.yaml.
> 
> Absolutely every sensor can be mounted rotated, therefore every binding
> referencing video-interface-devices should allow it, even if driver is
> not using it. Because basically that's the ABI we want to define for
> each sensor, thus each binding referencing common schema should have
> "unevaluatedProps: true" without listing them.
> 
> Similarly touchscreen.yaml.
> 
> OTOH, second option, properties which are strictly hardware, e.g. name
> of power supply or whether clock has or has not non-continuous mode,
> should be allowed only when they match the hardware. Such bindings
> should use "additionalProperties: false" so the hardware description is
> constrained/fixed/specific.

The patch may be technically correct but I'm afraid it won't improve the
bindings but rather the opposite: it removes information telling whether a
property is relevant for a given device.

I bet there are a lot of possibilities to write invalid DTS while the
checker says it's fine (missing data-lanes or link-frequencies, for
instance). That may have been the case before the patch but I'd make
properties a driver needs to function mandatory rather than removing them
from bindings altogether.

It'd been on my to-do list to split the current video-interfaces.yaml into
several files: generic camera sensor properties, CSI-2 interface
properties, DVP/Bt.656 interface properties and the rest (full list
probably requires more thought). That way we could only include properties
that are relevant for the device without necessarily listing each one for
all bindings.

I'd also continue to list boolean properties relevant for devices as well
as other properties that are relevant for a device but not mandatory.

-- 
Regards,

Sakari Ailus

Re: [PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Krzysztof Kozlowski]

On 16/03/2026 18:19, Sakari Ailus wrote:
> Hi Krzysztof, Laurent,
> 
> On Mon, Mar 16, 2026 at 03:42:09PM +0100, Krzysztof Kozlowski wrote:
>> On 16/03/2026 14:53, Laurent Pinchart wrote:
>>> Hello Krzysztof,
>>>
>>> Thank you for the patch.
>>>
>>> On Mon, Mar 16, 2026 at 02:45:34PM +0100, Krzysztof Kozlowski wrote:
>>>> The "endpoint" node references video-interfaces.yaml schema with
>>>> "unevaluatedProperties: false" which means that all properties from
>>>> referenced schema apply.  Listing some of them with ": true" is simply
>>>> redundant and does not make this code easier to read.
>>>
>>> I think you know my opinion on this topic. I believe we would be better
>>> off by turning "unevaluatedProperties: false" into
>>> "additionalProperties: false" here, and keeping the list of applicable
>>> properties. It brings value to device tree authors by telling which
>>> properties are applicable to the device at hand. For instance ... (see
>>> below)
>>
>> (let me trim)
>>
>>>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
>>>> index 2d7937a372a2..7a05a1eda58d 100644
>>>> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
>>>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
>>>> @@ -51,9 +51,6 @@ properties:
>>>>          $ref: /schemas/media/video-interfaces.yaml#
>>>>          unevaluatedProperties: false
>>>>  
>>>> -        properties:
>>>> -          clock-noncontinuous: true
>>>> -
>>>
>>> ... Without this, an integrator will need to dive into driver code to
>>> know if non-continuous clock is usable for the device.
>>
>> I see. Our usual interpretation of common schema, expressed by @Rob in
>> few places, that eventually all properties might be applicable. This
>> applies especially for ABI tied to the core Linux specifics, e.g.
>> rotation and orientation from video-interface-devices.yaml.
>>
>> Absolutely every sensor can be mounted rotated, therefore every binding
>> referencing video-interface-devices should allow it, even if driver is
>> not using it. Because basically that's the ABI we want to define for
>> each sensor, thus each binding referencing common schema should have
>> "unevaluatedProps: true" without listing them.
>>
>> Similarly touchscreen.yaml.
>>
>> OTOH, second option, properties which are strictly hardware, e.g. name
>> of power supply or whether clock has or has not non-continuous mode,
>> should be allowed only when they match the hardware. Such bindings
>> should use "additionalProperties: false" so the hardware description is
>> constrained/fixed/specific.
> 
> The patch may be technically correct but I'm afraid it won't improve the
> bindings but rather the opposite: it removes information telling whether a
> property is relevant for a given device.
> 
> I bet there are a lot of possibilities to write invalid DTS while the
> checker says it's fine (missing data-lanes or link-frequencies, for
> instance). That may have been the case before the patch but I'd make
> properties a driver needs to function mandatory rather than removing them
> from bindings altogether.

That's pretty different problem and I am not removing any mandatory
properties. I changed absolutely nothing from functional point of view.

> 
> It'd been on my to-do list to split the current video-interfaces.yaml into
> several files: generic camera sensor properties, CSI-2 interface
> properties, DVP/Bt.656 interface properties and the rest (full list
> probably requires more thought). That way we could only include properties
> that are relevant for the device without necessarily listing each one for
> all bindings.
> 
> I'd also continue to list boolean properties relevant for devices as well
> as other properties that are relevant for a device but not mandatory.

I don't think there is such goal and particular subsystem does not get
exception here. What is relevant for device comes either from the
hardware or implemented ABI, as I explained. Bindings arbitrarily
choosing "I think this might be relevant" from some big schema with
irrelevant pieces is not manageable and not correct.

The common schema should be rather entirely relevant thus making such
arbitrary choice what could be "more relevant" not even needed.


Best regards,
Krzysztof

Re: [PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Laurent Pinchart]

Hello Krzysztof,

On Mon, Mar 16, 2026 at 07:02:41PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2026 18:19, Sakari Ailus wrote:
> > On Mon, Mar 16, 2026 at 03:42:09PM +0100, Krzysztof Kozlowski wrote:
> >> On 16/03/2026 14:53, Laurent Pinchart wrote:
> >>> On Mon, Mar 16, 2026 at 02:45:34PM +0100, Krzysztof Kozlowski wrote:
> >>>> The "endpoint" node references video-interfaces.yaml schema with
> >>>> "unevaluatedProperties: false" which means that all properties from
> >>>> referenced schema apply.  Listing some of them with ": true" is simply
> >>>> redundant and does not make this code easier to read.
> >>>
> >>> I think you know my opinion on this topic. I believe we would be better
> >>> off by turning "unevaluatedProperties: false" into
> >>> "additionalProperties: false" here, and keeping the list of applicable
> >>> properties. It brings value to device tree authors by telling which
> >>> properties are applicable to the device at hand. For instance ... (see
> >>> below)
> >>
> >> (let me trim)
> >>
> >>>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> >>>> index 2d7937a372a2..7a05a1eda58d 100644
> >>>> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> >>>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> >>>> @@ -51,9 +51,6 @@ properties:
> >>>>          $ref: /schemas/media/video-interfaces.yaml#
> >>>>          unevaluatedProperties: false
> >>>>  
> >>>> -        properties:
> >>>> -          clock-noncontinuous: true
> >>>> -
> >>>
> >>> ... Without this, an integrator will need to dive into driver code to
> >>> know if non-continuous clock is usable for the device.
> >>
> >> I see. Our usual interpretation of common schema, expressed by @Rob in
> >> few places, that eventually all properties might be applicable. This
> >> applies especially for ABI tied to the core Linux specifics, e.g.
> >> rotation and orientation from video-interface-devices.yaml.
> >>
> >> Absolutely every sensor can be mounted rotated, therefore every binding
> >> referencing video-interface-devices should allow it, even if driver is
> >> not using it. Because basically that's the ABI we want to define for
> >> each sensor, thus each binding referencing common schema should have
> >> "unevaluatedProps: true" without listing them.

Yes, that's totally fine. I agree that properties defined in
video-interface-devices.yaml should not be listed in individual
bindings. They're generic, and all of them are applicable to each image
sensor device. That part is fine, I think we have no disagreement.

> >> Similarly touchscreen.yaml.
> >>
> >> OTOH, second option, properties which are strictly hardware, e.g. name
> >> of power supply or whether clock has or has not non-continuous mode,
> >> should be allowed only when they match the hardware. Such bindings
> >> should use "additionalProperties: false" so the hardware description is
> >> constrained/fixed/specific.
> > 
> > The patch may be technically correct but I'm afraid it won't improve the
> > bindings but rather the opposite: it removes information telling whether a
> > property is relevant for a given device.
> > 
> > I bet there are a lot of possibilities to write invalid DTS while the
> > checker says it's fine (missing data-lanes or link-frequencies, for
> > instance). That may have been the case before the patch but I'd make
> > properties a driver needs to function mandatory rather than removing them
> > from bindings altogether.
> 
> That's pretty different problem and I am not removing any mandatory
> properties. I changed absolutely nothing from functional point of view.
> 
> > It'd been on my to-do list to split the current video-interfaces.yaml into
> > several files: generic camera sensor properties, CSI-2 interface
> > properties, DVP/Bt.656 interface properties and the rest (full list
> > probably requires more thought). That way we could only include properties
> > that are relevant for the device without necessarily listing each one for
> > all bindings.
> > 
> > I'd also continue to list boolean properties relevant for devices as well
> > as other properties that are relevant for a device but not mandatory.
> 
> I don't think there is such goal and particular subsystem does not get
> exception here. What is relevant for device comes either from the
> hardware or implemented ABI, as I explained. Bindings arbitrarily
> choosing "I think this might be relevant" from some big schema with
> irrelevant pieces is not manageable and not correct.

But that's not what we're discussing. The properties you're dropping
here are not "arbitrarily" choosen as being relevant. Whether it is
possible or not to use a non-continuous clock is a hardware property,
it's not an arbitrary choice.

Your patch will not change anything when it comes to validation of DT by
tools using the schema, but it drops important information relevant to
DT writers. What I recommend instead is to switch from
"unevaluatedProperties: false" to "additionalProperties: false". Not
only will we keep the information, but it will also be enforced properly
by tools.

> The common schema should be rather entirely relevant thus making such
> arbitrary choice what could be "more relevant" not even needed.

Sakari mentioned splitting video-interfaces.yaml into multiple files,
which may help, but I don't think it will solve the problem completely.
Even with a video-interface-csi2.yaml, whether or not the clock can be
non-continuous, or if the data lines polarity can be configured, is a
hardware property.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] media: dt-bindings: i2c: Drop redundant endpoint properties

[Rob Herring]

On Wed, Mar 18, 2026 at 07:12:46PM +0200, Laurent Pinchart wrote:
> Hello Krzysztof,
> 
> On Mon, Mar 16, 2026 at 07:02:41PM +0100, Krzysztof Kozlowski wrote:
> > On 16/03/2026 18:19, Sakari Ailus wrote:
> > > On Mon, Mar 16, 2026 at 03:42:09PM +0100, Krzysztof Kozlowski wrote:
> > >> On 16/03/2026 14:53, Laurent Pinchart wrote:
> > >>> On Mon, Mar 16, 2026 at 02:45:34PM +0100, Krzysztof Kozlowski wrote:
> > >>>> The "endpoint" node references video-interfaces.yaml schema with
> > >>>> "unevaluatedProperties: false" which means that all properties from
> > >>>> referenced schema apply.  Listing some of them with ": true" is simply
> > >>>> redundant and does not make this code easier to read.
> > >>>
> > >>> I think you know my opinion on this topic. I believe we would be better
> > >>> off by turning "unevaluatedProperties: false" into
> > >>> "additionalProperties: false" here, and keeping the list of applicable
> > >>> properties. It brings value to device tree authors by telling which
> > >>> properties are applicable to the device at hand. For instance ... (see
> > >>> below)
> > >>
> > >> (let me trim)
> > >>
> > >>>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > >>>> index 2d7937a372a2..7a05a1eda58d 100644
> > >>>> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > >>>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > >>>> @@ -51,9 +51,6 @@ properties:
> > >>>>          $ref: /schemas/media/video-interfaces.yaml#
> > >>>>          unevaluatedProperties: false
> > >>>>  
> > >>>> -        properties:
> > >>>> -          clock-noncontinuous: true
> > >>>> -
> > >>>
> > >>> ... Without this, an integrator will need to dive into driver code to
> > >>> know if non-continuous clock is usable for the device.
> > >>
> > >> I see. Our usual interpretation of common schema, expressed by @Rob in
> > >> few places, that eventually all properties might be applicable. This
> > >> applies especially for ABI tied to the core Linux specifics, e.g.
> > >> rotation and orientation from video-interface-devices.yaml.
> > >>
> > >> Absolutely every sensor can be mounted rotated, therefore every binding
> > >> referencing video-interface-devices should allow it, even if driver is
> > >> not using it. Because basically that's the ABI we want to define for
> > >> each sensor, thus each binding referencing common schema should have
> > >> "unevaluatedProps: true" without listing them.
> 
> Yes, that's totally fine. I agree that properties defined in
> video-interface-devices.yaml should not be listed in individual
> bindings. They're generic, and all of them are applicable to each image
> sensor device. That part is fine, I think we have no disagreement.
> 
> > >> Similarly touchscreen.yaml.
> > >>
> > >> OTOH, second option, properties which are strictly hardware, e.g. name
> > >> of power supply or whether clock has or has not non-continuous mode,
> > >> should be allowed only when they match the hardware. Such bindings
> > >> should use "additionalProperties: false" so the hardware description is
> > >> constrained/fixed/specific.
> > > 
> > > The patch may be technically correct but I'm afraid it won't improve the
> > > bindings but rather the opposite: it removes information telling whether a
> > > property is relevant for a given device.
> > > 
> > > I bet there are a lot of possibilities to write invalid DTS while the
> > > checker says it's fine (missing data-lanes or link-frequencies, for
> > > instance). That may have been the case before the patch but I'd make
> > > properties a driver needs to function mandatory rather than removing them
> > > from bindings altogether.
> > 
> > That's pretty different problem and I am not removing any mandatory
> > properties. I changed absolutely nothing from functional point of view.
> > 
> > > It'd been on my to-do list to split the current video-interfaces.yaml into
> > > several files: generic camera sensor properties, CSI-2 interface
> > > properties, DVP/Bt.656 interface properties and the rest (full list
> > > probably requires more thought). That way we could only include properties
> > > that are relevant for the device without necessarily listing each one for
> > > all bindings.
> > > 
> > > I'd also continue to list boolean properties relevant for devices as well
> > > as other properties that are relevant for a device but not mandatory.
> > 
> > I don't think there is such goal and particular subsystem does not get
> > exception here. What is relevant for device comes either from the
> > hardware or implemented ABI, as I explained. Bindings arbitrarily
> > choosing "I think this might be relevant" from some big schema with
> > irrelevant pieces is not manageable and not correct.
> 
> But that's not what we're discussing. The properties you're dropping
> here are not "arbitrarily" choosen as being relevant. Whether it is
> possible or not to use a non-continuous clock is a hardware property,
> it's not an arbitrary choice.
> 
> Your patch will not change anything when it comes to validation of DT by
> tools using the schema, but it drops important information relevant to
> DT writers. What I recommend instead is to switch from
> "unevaluatedProperties: false" to "additionalProperties: false". Not
> only will we keep the information, but it will also be enforced properly
> by tools.

I agree with keeping the information. Really, I'm indifferent, so if 
anyone finds it useful then let's leave it. I'm also not going to care 
in reviews either, so it's up to the media maintainers to care and 
ensure consistency.

Also, I don't think we can switch to additionalProperties here because 
then we have to list all the standard graph properties, too. That I do 
care about and don't care to see.

Rob