Re: [raw2rgbpnm PATCH v4 05/11] Add "help" for listing formats and de-Bayering algos, document it

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Tue, Mar 10, 2026 at 10:46:11AM +0200, Sakari Ailus wrote:
> '?' is a problematic character for shells.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  raw2rgbpnm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/raw2rgbpnm.c b/raw2rgbpnm.c
> index 16ef64e984b9..b0151789b0c1 100644
> --- a/raw2rgbpnm.c
> +++ b/raw2rgbpnm.c
> @@ -865,7 +865,7 @@ int main(int argc, char *argv[])
>  		if (c==-1) break;
>  		switch (c) {
>  		case 'a':
> -			if (optarg[0]=='?') {
> +			if (optarg[0]=='?' || !strcmp(optarg, "help")) {
>  				printf("Available bayer-to-rgb conversion algorithms:\n");
>  				qc_print_algorithms();
>  				exit(0);
> @@ -876,7 +876,7 @@ int main(int argc, char *argv[])
>  			brightness = (int)(atof(optarg) * 256.0 + 0.5);
>  			break;
>  		case 'f':
> -			if (optarg[0]=='?' && optarg[1]==0) {
> +			if ((optarg[0]=='?' && optarg[1]==0) || !strcmp(optarg, "help")) {
>  				unsigned int i,j;
>  				printf("Supported formats:\n");
>  				for (i=0; i<SIZE(v4l2_pix_fmt_str); i++) {
> @@ -904,11 +904,11 @@ int main(int argc, char *argv[])
>  			       "Usage: %s [--algo|-a <algo>] [--brightness|-b <brightness>]\n"
>  			       "       [--format|-f <format>] [--help|-h] [--high-bits|-g] [--size|-s XxY]\n"
>  			       "       [--swap-rb|-w] <inputfile> <outputfile>\n\n"
> -			       "--algo, -a <algo>         Select algorithm, use \"-a ?\" for a list\n"
> +			       "--algo, -a <algo>         Select algorithm, use \"-a help\" for a list\n"
>  			       "--brightness, -b <bright> Set brightness (multiplier) to output image\n"
>  			       "                          (float, default 1.0)\n"
>  			       "--format, -f <format>     Specify input file format format\n"
> -			       "                          (-f ? for list, default UYVY)\n"
> +			       "                          (-f help for list, default UYVY)\n"

While at it, quote "-f help" like done above for -a.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  			       "--help, -h                Show this help\n"
>  			       "--high-bits, -g           Use high bits for Bayer RAW 10 data\n"
>  			       "--size, -s <XxY>          Specify image size\n"

-- 
Regards,

Laurent Pinchart