From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 6/7] Use "stride" in a stride-related error message instead of an internal name
Date: Tue, 17 Mar 2026 12:55:11 +0200 [thread overview]
Message-ID: <20260317105511.GG302774@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20260317095802.214532-7-sakari.ailus@linux.intel.com>
On Tue, Mar 17, 2026 at 11:58:01AM +0200, Sakari Ailus wrote:
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> raw2rgbpnm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/raw2rgbpnm.c b/raw2rgbpnm.c
> index ef12be820be6..3b92c6ba519b 100644
> --- a/raw2rgbpnm.c
> +++ b/raw2rgbpnm.c
> @@ -177,7 +177,7 @@ static unsigned char *read_raw_data(char *filename, unsigned int *width,
> line_length = line_length ?: (*width * bpp + 7) / 8;
> if (!line_length || UINT_MAX / line_length < *height ||
> line_length < *width * bpp / 8)
> - error("line_length %u is bad", line_length);
> + error("stride %u is bad", line_length);
> if (file_size > UINT_MAX)
> error("too large file");
> if ((unsigned int)file_size < line_length * *height)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2026-03-17 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 9:57 [PATCH 0/7] raw2rgbpnm cleanups and a fix Sakari Ailus
2026-03-17 9:57 ` [PATCH 1/7] Reorder headers alphabetically Sakari Ailus
2026-03-17 10:50 ` Laurent Pinchart
2026-03-17 9:57 ` [PATCH 2/7] Check we have a supported format first before allocating memory Sakari Ailus
2026-03-17 10:54 ` Laurent Pinchart
2026-03-17 13:11 ` Sakari Ailus
2026-03-17 9:57 ` [PATCH 3/7] Add quotes for "-f help" in help text and do a line wrap Sakari Ailus
2026-03-17 10:54 ` Laurent Pinchart
2026-03-17 9:57 ` [PATCH 4/7] Constify progname Sakari Ailus
2026-03-17 10:54 ` Laurent Pinchart
2026-03-17 9:58 ` [PATCH 5/7] More header sorting Sakari Ailus
2026-03-17 10:54 ` Laurent Pinchart
2026-03-17 9:58 ` [PATCH 6/7] Use "stride" in a stride-related error message instead of an internal name Sakari Ailus
2026-03-17 10:55 ` Laurent Pinchart [this message]
2026-03-17 9:58 ` [PATCH 7/7] Fix file size check Sakari Ailus
2026-03-17 10:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317105511.GG302774@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox