From: Felix Gu <ustc.gu@gmail.com>
To: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dale Farnsworth <dale@farnsworth.org>,
Benoit Parrot <bparrot@ti.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Sukrut Bellary <sbellary@baylibre.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Felix Gu <ustc.gu@gmail.com>
Subject: [PATCH 2/3] media: ti: vpe: Fix the error code of devm_request_irq()
Date: Wed, 18 Mar 2026 01:21:54 +0800 [thread overview]
Message-ID: <20260318-vip-v1-2-5fdcdbd01829@gmail.com> (raw)
In-Reply-To: <20260318-vip-v1-0-5fdcdbd01829@gmail.com>
Return the actual error code from devm_request_irq() instead of
incorrectly returning -ENOMEM.
Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/media/platform/ti/vpe/vip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/ti/vpe/vip.c
index 01d27769cd10..f0354b52048e 100644
--- a/drivers/media/platform/ti/vpe/vip.c
+++ b/drivers/media/platform/ti/vpe/vip.c
@@ -3472,7 +3472,7 @@ static int vip_probe_slice(struct platform_device *pdev, int slice)
ret = devm_request_irq(&pdev->dev, dev->irq, vip_irq,
0, VIP_MODULE_NAME, dev);
if (ret < 0)
- return -ENOMEM;
+ return ret;
spin_lock_init(&dev->slock);
mutex_init(&dev->mutex);
--
2.43.0
next prev parent reply other threads:[~2026-03-17 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 17:21 [PATCH 0/3] media: ti: vpe: three small fixes Felix Gu
2026-03-17 17:21 ` [PATCH 1/3] media: ti: vpe: Fix fwnode_handle leak in vip_probe_complete() Felix Gu
2026-03-17 17:21 ` Felix Gu [this message]
2026-03-18 9:00 ` [PATCH 2/3] media: ti: vpe: Fix the error code of devm_request_irq() Markus Elfring
2026-03-17 17:21 ` [PATCH 3/3] media: ti: vpe: Fix the error code of devm_kzalloc() in vip_probe_slice() Felix Gu
2026-03-18 9:22 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318-vip-v1-2-5fdcdbd01829@gmail.com \
--to=ustc.gu@gmail.com \
--cc=bparrot@ti.com \
--cc=dale@farnsworth.org \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sbellary@baylibre.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox