Re: [PATCH 1/2] em28xx: Add support for Empia em2828X bridge

[kernel test robot <lkp@intel.com>]

Hi Bradford,

kernel test robot noticed the following build errors:

[auto build test ERROR on linuxtv-media-pending/master]
[also build test ERROR on media-tree/master sailus-media-tree/master linus/master v7.0-rc4 next-20260317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bradford-Love/em28xx-Add-support-for-Empia-em2828X-bridge/20260318-090020
base:   https://git.linuxtv.org/media-ci/media-pending.git master
patch link:    https://lore.kernel.org/r/20260312224915.2907539-2-brad%40nextdimension.cc
patch subject: [PATCH 1/2] em28xx: Add support for Empia em2828X bridge
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260319/202603190036.DvoHb1dH-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260319/202603190036.DvoHb1dH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603190036.DvoHb1dH-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/media/usb/em28xx/em28xx-video.c:1154:17: error: incompatible pointer types assigning to 'struct media_entity *' from 'typeof (v4l2->decoder) *' (aka 'struct media_entity **'); dereference with * [-Wincompatible-pointer-types]
    1154 |                 v4l2->decoder = kzalloc_obj(v4l2->decoder, GFP_KERNEL);
         |                               ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                 *(                                    )
   1 error generated.


vim +1154 drivers/media/usb/em28xx/em28xx-video.c

  1086	
  1087	static void em28xx_v4l2_create_entities(struct em28xx *dev)
  1088	{
  1089	#if defined(CONFIG_MEDIA_CONTROLLER)
  1090		struct em28xx_v4l2 *v4l2 = dev->v4l2;
  1091		int ret, i;
  1092	
  1093		/* Initialize Video, VBI and Radio pads */
  1094		v4l2->video_pad.flags = MEDIA_PAD_FL_SINK;
  1095		ret = media_entity_pads_init(&v4l2->vdev.entity, 1, &v4l2->video_pad);
  1096		if (ret < 0)
  1097			dev_err(&dev->intf->dev,
  1098				"failed to initialize video media entity!\n");
  1099	
  1100		if (em28xx_vbi_supported(dev)) {
  1101			v4l2->vbi_pad.flags = MEDIA_PAD_FL_SINK;
  1102			ret = media_entity_pads_init(&v4l2->vbi_dev.entity, 1,
  1103						     &v4l2->vbi_pad);
  1104			if (ret < 0)
  1105				dev_err(&dev->intf->dev,
  1106					"failed to initialize vbi media entity!\n");
  1107		}
  1108	
  1109		/* Webcams don't have input connectors */
  1110		if (dev->is_webcam)
  1111			return;
  1112	
  1113		/* Create entities for each input connector */
  1114		for (i = 0; i < MAX_EM28XX_INPUT; i++) {
  1115			struct media_entity *ent = &dev->input_ent[i];
  1116	
  1117			if (!INPUT(i)->type)
  1118				break;
  1119	
  1120			ent->name = iname[INPUT(i)->type];
  1121			ent->flags = MEDIA_ENT_FL_CONNECTOR;
  1122			dev->input_pad[i].flags = MEDIA_PAD_FL_SOURCE;
  1123	
  1124			switch (INPUT(i)->type) {
  1125			case EM28XX_VMUX_COMPOSITE:
  1126				ent->function = MEDIA_ENT_F_CONN_COMPOSITE;
  1127				break;
  1128			case EM28XX_VMUX_SVIDEO:
  1129				ent->function = MEDIA_ENT_F_CONN_SVIDEO;
  1130				break;
  1131			default: /* EM28XX_VMUX_TELEVISION or EM28XX_RADIO */
  1132				if (dev->tuner_type != TUNER_ABSENT || em28xx_analogtv_supported(dev))
  1133					ent->function = MEDIA_ENT_F_CONN_RF;
  1134				break;
  1135			}
  1136	
  1137			ret = media_entity_pads_init(ent, 1, &dev->input_pad[i]);
  1138			if (ret < 0)
  1139				dev_err(&dev->intf->dev,
  1140					"failed to initialize input pad[%d]!\n", i);
  1141	
  1142			ret = media_device_register_entity(dev->media_dev, ent);
  1143			if (ret < 0)
  1144				dev_err(&dev->intf->dev,
  1145					"failed to register input entity %d!\n", i);
  1146		}
  1147	
  1148		if (dev->board.decoder == EM28XX_BUILTIN) {
  1149			v4l2->decoder_pads[EM2828X_PAD_INPUT].flags = MEDIA_PAD_FL_SINK;
  1150			v4l2->decoder_pads[EM2828X_PAD_INPUT].sig_type = PAD_SIGNAL_ANALOG;
  1151			v4l2->decoder_pads[EM2828X_PAD_VID_OUT].flags = MEDIA_PAD_FL_SOURCE;
  1152			v4l2->decoder_pads[EM2828X_PAD_VID_OUT].sig_type = PAD_SIGNAL_DV;
  1153	
> 1154			v4l2->decoder = kzalloc_obj(v4l2->decoder, GFP_KERNEL);
  1155			v4l2->decoder->name = "em2828x_builtin";
  1156			v4l2->decoder->function = MEDIA_ENT_F_ATV_DECODER;
  1157	
  1158			ret = media_entity_pads_init(v4l2->decoder, EM2828X_NUM_PADS, &v4l2->decoder_pads[0]);
  1159			if (ret < 0)
  1160				dev_err(&dev->intf->dev, "failed to initialize decoder pads %d!\n", ret);
  1161	
  1162			ret = media_device_register_entity(dev->media_dev, v4l2->decoder);
  1163			if (ret < 0)
  1164				dev_err(&dev->intf->dev, "failed to register decoder entity %d!\n", ret);
  1165		}
  1166	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki