* [PATCH] media: rockchip: Disable VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon
@ 2026-02-13 20:10 Nathan Chancellor
2026-02-16 16:17 ` Nicolas Dufresne
0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2026-02-13 20:10 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Heiko Stuebner
Cc: Brian Cain, Nick Desaulniers, Bill Wendling, Justin Stitt,
linux-media, linux-rockchip, linux-arm-kernel, linux-kernel,
linux-hexagon, llvm, Nathan Chancellor
Building rkvdec-vdpu383-h264.c can take a few hours to finish building
with Clang 20.1.0 or newer when compile testing for Hexagon. While this
is further investigated and understood on the LLVM side [1], disable
CONFIG_VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon.
Link: https://github.com/llvm/llvm-project/issues/178535 [1]
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/media/platform/rockchip/rkvdec/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rkvdec/Kconfig b/drivers/media/platform/rockchip/rkvdec/Kconfig
index 5f3bdd848a2c..d03689464206 100644
--- a/drivers/media/platform/rockchip/rkvdec/Kconfig
+++ b/drivers/media/platform/rockchip/rkvdec/Kconfig
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0
config VIDEO_ROCKCHIP_VDEC
tristate "Rockchip Video Decoder driver"
- depends on ARCH_ROCKCHIP || COMPILE_TEST
+ # !HEXAGON: https://github.com/llvm/llvm-project/issues/178535
+ depends on ARCH_ROCKCHIP || (COMPILE_TEST && !HEXAGON)
depends on VIDEO_DEV
select MEDIA_CONTROLLER
select VIDEOBUF2_DMA_CONTIG
---
base-commit: c824345288d11e269ce41b36c105715bc2286050
change-id: 20260213-media-disable-rockchip-vdec-hexagon-eb67c47292c5
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: rockchip: Disable VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon
2026-02-13 20:10 [PATCH] media: rockchip: Disable VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon Nathan Chancellor
@ 2026-02-16 16:17 ` Nicolas Dufresne
2026-03-19 20:08 ` Nicolas Dufresne
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Dufresne @ 2026-02-16 16:17 UTC (permalink / raw)
To: Nathan Chancellor, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Heiko Stuebner
Cc: Brian Cain, Nick Desaulniers, Bill Wendling, Justin Stitt,
linux-media, linux-rockchip, linux-arm-kernel, linux-kernel,
linux-hexagon, llvm
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
Hi Nathan,
Le vendredi 13 février 2026 à 15:10 -0500, Nathan Chancellor a écrit :
> Building rkvdec-vdpu383-h264.c can take a few hours to finish building
> with Clang 20.1.0 or newer when compile testing for Hexagon. While this
> is further investigated and understood on the LLVM side [1], disable
> CONFIG_VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon.
>
> Link: https://github.com/llvm/llvm-project/issues/178535 [1]
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/media/platform/rockchip/rkvdec/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkvdec/Kconfig b/drivers/media/platform/rockchip/rkvdec/Kconfig
> index 5f3bdd848a2c..d03689464206 100644
> --- a/drivers/media/platform/rockchip/rkvdec/Kconfig
> +++ b/drivers/media/platform/rockchip/rkvdec/Kconfig
> @@ -1,7 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
> config VIDEO_ROCKCHIP_VDEC
> tristate "Rockchip Video Decoder driver"
> - depends on ARCH_ROCKCHIP || COMPILE_TEST
> + # !HEXAGON: https://github.com/llvm/llvm-project/issues/178535
> + depends on ARCH_ROCKCHIP || (COMPILE_TEST && !HEXAGON)
This is clearly not a pleasing change to make. As this specific data structure
and usage of bitfield has been discussed (along with the numerous issues in
clang/llvm around these). We also agreed to move away from bitfield for this
data structure and use a bitwriter. I would favour delaying this change to give
devs the time to port instead. Ping again if nothing moves within few weeks.
best regards,
Nicolas
> depends on VIDEO_DEV
> select MEDIA_CONTROLLER
> select VIDEOBUF2_DMA_CONTIG
>
> ---
> base-commit: c824345288d11e269ce41b36c105715bc2286050
> change-id: 20260213-media-disable-rockchip-vdec-hexagon-eb67c47292c5
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: rockchip: Disable VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon
2026-02-16 16:17 ` Nicolas Dufresne
@ 2026-03-19 20:08 ` Nicolas Dufresne
2026-03-19 20:24 ` Nathan Chancellor
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Dufresne @ 2026-03-19 20:08 UTC (permalink / raw)
To: Nathan Chancellor, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Heiko Stuebner
Cc: Brian Cain, Nick Desaulniers, Bill Wendling, Justin Stitt,
linux-media, linux-rockchip, linux-arm-kernel, linux-kernel,
linux-hexagon, llvm
[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]
Le lundi 16 février 2026 à 11:17 -0500, Nicolas Dufresne a écrit :
> Hi Nathan,
>
> Le vendredi 13 février 2026 à 15:10 -0500, Nathan Chancellor a écrit :
> > Building rkvdec-vdpu383-h264.c can take a few hours to finish building
> > with Clang 20.1.0 or newer when compile testing for Hexagon. While this
> > is further investigated and understood on the LLVM side [1], disable
> > CONFIG_VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon.
> >
> > Link: https://github.com/llvm/llvm-project/issues/178535 [1]
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> > drivers/media/platform/rockchip/rkvdec/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/rockchip/rkvdec/Kconfig
> > b/drivers/media/platform/rockchip/rkvdec/Kconfig
> > index 5f3bdd848a2c..d03689464206 100644
> > --- a/drivers/media/platform/rockchip/rkvdec/Kconfig
> > +++ b/drivers/media/platform/rockchip/rkvdec/Kconfig
> > @@ -1,7 +1,8 @@
> > # SPDX-License-Identifier: GPL-2.0
> > config VIDEO_ROCKCHIP_VDEC
> > tristate "Rockchip Video Decoder driver"
> > - depends on ARCH_ROCKCHIP || COMPILE_TEST
> > + # !HEXAGON: https://github.com/llvm/llvm-project/issues/178535
> > + depends on ARCH_ROCKCHIP || (COMPILE_TEST && !HEXAGON)
>
> This is clearly not a pleasing change to make. As this specific data structure
> and usage of bitfield has been discussed (along with the numerous issues in
> clang/llvm around these). We also agreed to move away from bitfield for this
> data structure and use a bitwriter. I would favour delaying this change to
> give
> devs the time to port instead. Ping again if nothing moves within few weeks.
>
> best regards,
> Nicolas
I haven't heard back about the port to plain bitwriter. I guess I have to pick
this patch, but I really don't want to have to maintain too many of these hacks.
Anyone else with an opinion on the topic ? Or a better idea how this can be
workaround differently ?
Nicolas
>
> > depends on VIDEO_DEV
> > select MEDIA_CONTROLLER
> > select VIDEOBUF2_DMA_CONTIG
> >
> > ---
> > base-commit: c824345288d11e269ce41b36c105715bc2286050
> > change-id: 20260213-media-disable-rockchip-vdec-hexagon-eb67c47292c5
> >
> > Best regards,
> > --
> > Nathan Chancellor <nathan@kernel.org>
> >
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: rockchip: Disable VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon
2026-03-19 20:08 ` Nicolas Dufresne
@ 2026-03-19 20:24 ` Nathan Chancellor
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2026-03-19 20:24 UTC (permalink / raw)
To: Nicolas Dufresne
Cc: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab,
Heiko Stuebner, Brian Cain, Nick Desaulniers, Bill Wendling,
Justin Stitt, linux-media, linux-rockchip, linux-arm-kernel,
linux-kernel, linux-hexagon, llvm
On Thu, Mar 19, 2026 at 04:08:29PM -0400, Nicolas Dufresne wrote:
> Le lundi 16 février 2026 à 11:17 -0500, Nicolas Dufresne a écrit :
> > Le vendredi 13 février 2026 à 15:10 -0500, Nathan Chancellor a écrit :
> > > Building rkvdec-vdpu383-h264.c can take a few hours to finish building
> > > with Clang 20.1.0 or newer when compile testing for Hexagon. While this
> > > is further investigated and understood on the LLVM side [1], disable
> > > CONFIG_VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon.
> > >
> > > Link: https://github.com/llvm/llvm-project/issues/178535 [1]
> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > > ---
> > > drivers/media/platform/rockchip/rkvdec/Kconfig | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/platform/rockchip/rkvdec/Kconfig
> > > b/drivers/media/platform/rockchip/rkvdec/Kconfig
> > > index 5f3bdd848a2c..d03689464206 100644
> > > --- a/drivers/media/platform/rockchip/rkvdec/Kconfig
> > > +++ b/drivers/media/platform/rockchip/rkvdec/Kconfig
> > > @@ -1,7 +1,8 @@
> > > # SPDX-License-Identifier: GPL-2.0
> > > config VIDEO_ROCKCHIP_VDEC
> > > tristate "Rockchip Video Decoder driver"
> > > - depends on ARCH_ROCKCHIP || COMPILE_TEST
> > > + # !HEXAGON: https://github.com/llvm/llvm-project/issues/178535
> > > + depends on ARCH_ROCKCHIP || (COMPILE_TEST && !HEXAGON)
> >
> > This is clearly not a pleasing change to make. As this specific data structure
> > and usage of bitfield has been discussed (along with the numerous issues in
> > clang/llvm around these). We also agreed to move away from bitfield for this
> > data structure and use a bitwriter. I would favour delaying this change to
> > give
> > devs the time to port instead. Ping again if nothing moves within few weeks.
> >
> > best regards,
> > Nicolas
>
> I haven't heard back about the port to plain bitwriter. I guess I have to pick
> this patch, but I really don't want to have to maintain too many of these hacks.
> Anyone else with an opinion on the topic ? Or a better idea how this can be
> workaround differently ?
For what it's worth, I don't anticipate more of these hacks. Hexagon is
rather special in that it has a lot of target specific optimization
passes, which do not always see code as complex as Linux has in places
during development. Ideally, it is resolved at some point during the
LLVM 23 development cycle then we can version check this workaround and
eventually clean it up altogether.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-19 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-13 20:10 [PATCH] media: rockchip: Disable VIDEO_ROCKCHIP_VDEC when compile testing for Hexagon Nathan Chancellor
2026-02-16 16:17 ` Nicolas Dufresne
2026-03-19 20:08 ` Nicolas Dufresne
2026-03-19 20:24 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox