public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org
Subject: [sailus-media-tree:metadata 99/106] drivers/media/pci/intel/ipu6/ipu6-isys-queue.c:561:14: warning: unused variable 'has_pipeline'
Date: Sat, 21 Mar 2026 01:17:37 +0800	[thread overview]
Message-ID: <202603210104.4hUqxqYU-lkp@intel.com> (raw)

tree:   git://linuxtv.org/sailus/media_tree.git metadata
head:   7a108073e0c1f6e9035329a152d5835f9d4f9507
commit: 526d9c2d124199ae12d8c48148ca47b2f1ad676f [99/106] media: ipu6: Bridge the gap between streams in V4L2 and IPU6 firmware
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20260321/202603210104.4hUqxqYU-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260321/202603210104.4hUqxqYU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603210104.4hUqxqYU-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/pci/intel/ipu6/ipu6-isys-queue.c: In function 'start_streaming':
>> drivers/media/pci/intel/ipu6/ipu6-isys-queue.c:561:14: warning: unused variable 'has_pipeline' [-Wunused-variable]
     561 |         bool has_pipeline = (bool)video_device_pipeline(&av->vdev);
         |              ^~~~~~~~~~~~


vim +/has_pipeline +561 drivers/media/pci/intel/ipu6/ipu6-isys-queue.c

   532	
   533	static int start_streaming(struct vb2_queue *q, unsigned int count)
   534	{
   535		struct ipu6_isys_queue *aq = vb2_queue_to_isys_queue(q);
   536		struct ipu6_isys_video *av = ipu6_isys_queue_to_video(aq);
   537		struct device *dev = &av->isys->adev->auxdev.dev;
   538		const struct ipu6_isys_pixelformat *pfmt =
   539			ipu6_isys_get_isys_format(ipu6_isys_get_format(av), 0);
   540		struct media_pad *source_pad, *remote_pad;
   541		int ret;
   542	
   543		dev_dbg(dev, "stream: %s: width %u, height %u, css pixelformat %u\n",
   544			av->vdev.name, ipu6_isys_get_frame_width(av),
   545			ipu6_isys_get_frame_height(av), pfmt->css_pixelformat);
   546	
   547		remote_pad = media_pad_remote_pad_unique(&av->pad);
   548		if (IS_ERR(remote_pad)) {
   549			dev_dbg(dev, "failed to get remote pad\n");
   550			ret = PTR_ERR(remote_pad);
   551			goto out_return_buffers;
   552		}
   553	
   554		source_pad = media_pad_remote_pad_unique(&remote_pad->entity->pads[0]);
   555		if (IS_ERR(source_pad)) {
   556			dev_dbg(dev, "No external source entity\n");
   557			ret = PTR_ERR(source_pad);
   558			goto out_return_buffers;
   559		}
   560	
 > 561		bool has_pipeline = (bool)video_device_pipeline(&av->vdev);
   562	
   563		ret = video_device_pipeline_alloc_start(&av->vdev);
   564		if (ret < 0)
   565			goto out_return_buffers;
   566	
   567		ret = ipu6_isys_link_fmt_validate(aq);
   568		if (ret) {
   569			dev_dbg(dev,
   570				"%s: link format validation failed (%d)\n",
   571				av->vdev.name, ret);
   572			goto out_pipeline_stop;
   573		}
   574	
   575		ret = ipu6_isys_fw_open(av->isys);
   576		if (ret)
   577			goto out_pipeline_stop;
   578	
   579		ret = ipu6_isys_stream_start(av);
   580		if (ret)
   581			goto out_fw_close;
   582	
   583		return 0;
   584	
   585	out_fw_close:
   586		ipu6_isys_fw_close(av->isys);
   587	
   588	out_pipeline_stop:
   589		ipu6_isys_stream_cleanup(av);
   590	
   591	out_return_buffers:
   592		return_buffers(aq, VB2_BUF_STATE_QUEUED);
   593	
   594		return ret;
   595	}
   596	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-03-20 17:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202603210104.4hUqxqYU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox