[PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line

[PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line

[Anushka Badhe]

Removed the whitespace at the start of the line to comply with
 linux kernel coding style.

Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_local.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..3cf35678383f 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -87,7 +87,7 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
  * so, having multiple base addresses for
  * different timers does not help*/
 const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+	(hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
-- 
2.43.0

Re: [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line

[Andy Shevchenko]

On Tue, Mar 24, 2026 at 01:40:07PM +0530, Anushka Badhe wrote:
> Removed the whitespace at the start of the line to comply with
>  linux kernel coding style.

Linux

...

>  const hrt_address GP_TIMER_BASE =
> -    (hrt_address)0x0000000000000600ULL;
> +	(hrt_address)0x0000000000000600ULL;

Always think one or even two steps further. How does your patch add value?
For now it's just a warning of a tool or even no warning, just some whitespace
shuffling, which is usually the type of patches that are doomed to be ceased.

Compare to

const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;

which gives the same result + reduces number of LoC for free. This increases
the value of the change. Now, you can look at the rest of the code for the
indentation problems.

BUT, they are so-o-o-o LOW priority thing, that most likely will be simply
NAKed. Can you rather do a real patch instead, please?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line

[Andy Shevchenko]

On Tue, Mar 24, 2026 at 01:50:37PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 24, 2026 at 01:40:07PM +0530, Anushka Badhe wrote:
> > Removed the whitespace at the start of the line to comply with
> >  linux kernel coding style.
> 
> Linux

Also note, while fixing the above mentioned problem in the code, the commit
message suffers from the same issue.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration

[Anushka Badhe]

Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

Thank you so much for your guidance on improving the patch.

 drivers/staging/media/atomisp/pci/system_local.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..1c513ead5300 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -85,9 +85,9 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
- * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+ * different timers does not help
+ */
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
-- 
2.43.0

[PATCH v3] staging: media: atomisp: pci: fix block comment style and merge split declaration

[Anushka Badhe]

The closing */ of a block comment is on the same line as the comment
text, violating kernel coding style. GP_TIMER_BASE declaration is also
unnecessarily split across two lines. Fix both issues.

Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:

Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

 drivers/staging/media/atomisp/pci/system_local.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..1c513ead5300 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -85,9 +85,9 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
- * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+ * different timers does not help
+ */
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
-- 
2.43.0

Re: [PATCH v3] staging: media: atomisp: pci: fix block comment style and merge split declaration

[Andy Shevchenko]

On Wed, Mar 25, 2026 at 01:13:56AM +0530, Anushka Badhe wrote:
> The closing */ of a block comment is on the same line as the comment
> text, violating kernel coding style. GP_TIMER_BASE declaration is also
> unnecessarily split across two lines. Fix both issues.

You are doing two things in one change. And doing first half-way...
NAK.

-- 
With Best Regards,
Andy Shevchenko

[PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration

[Anushka Badhe]

Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
readability.

Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
Thank you so much for your review and guidance.

Changes in v4:
- Remove unrelated block comment style fixes

Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:

Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Note:
* This patch is part of the GSoC2026 application process for device tree 
binding
s conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/media/atomisp/pci/system_local.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..69bcd557a821 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -86,8 +86,7 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
  * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
-- 
2.43.0

Re: [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration

[Andy Shevchenko]

On Wed, Mar 25, 2026 at 06:54:34PM +0530, Anushka Badhe wrote:
> Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
> readability.

Nice, but this constant is only used in one file, id est gp_timer.c.
Just move it there with the (fixed style of the) comment to there
and drop the mentioning in the rest of the files. With this being done,
the patch gains real value.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration

[Greg KH]

On Tue, Mar 24, 2026 at 11:38:21PM +0530, Anushka Badhe wrote:
> Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
> ---
> Changes in v2:
> - Fix block comment style (move closing */ to its own line)
> - Merge split GP_TIMER_BASE declaration onto a single line
> 
> Checked the rest of the file for similar issues; no others found.
> 
> Thank you so much for your guidance on improving the patch.

For obvious reasons, we can't take patches without any changelog text.

thanks,

greg k-h

Re: [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration

[Anushka B]

On Wed, Mar 25, 2026 at 2:15 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Mar 24, 2026 at 11:38:21PM +0530, Anushka Badhe wrote:
> > Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
> > ---
> > Changes in v2:
> > - Fix block comment style (move closing */ to its own line)
> > - Merge split GP_TIMER_BASE declaration onto a single line
> >
> > Checked the rest of the file for similar issues; no others found.
> >
> > Thank you so much for your guidance on improving the patch.
>
> For obvious reasons, we can't take patches without any changelog text.
>
> thanks,
>
> greg k-h

Thank you for your feedback - v3 fixes this issue with a proper
changelog description.
https://lore.kernel.org/linux-media/20260324194356.49090-1-anushkabadhe@gmail.com/#t