public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Anushka Badhe <anushkabadhe@gmail.com>
To: anushkabadhe@gmail.com
Cc: andriy.shevchenko@intel.com, andy@kernel.org,
	gregkh@linuxfoundation.org, hansg@kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-staging@lists.linux.dev, mchehab@kernel.org,
	sakari.ailus@linux.intel.com
Subject: [PATCH v3] staging: media: atomisp: pci: fix block comment style and merge split declaration
Date: Wed, 25 Mar 2026 01:13:56 +0530	[thread overview]
Message-ID: <20260324194356.49090-1-anushkabadhe@gmail.com> (raw)
In-Reply-To: <20260324180821.42084-1-anushkabadhe@gmail.com>

The closing */ of a block comment is on the same line as the comment
text, violating kernel coding style. GP_TIMER_BASE declaration is also
unnecessarily split across two lines. Fix both issues.

Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:

Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

 drivers/staging/media/atomisp/pci/system_local.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..1c513ead5300 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -85,9 +85,9 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
- * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+ * different timers does not help
+ */
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
-- 
2.43.0


  reply	other threads:[~2026-03-24 19:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24  8:10 [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line Anushka Badhe
2026-03-24 11:50 ` Andy Shevchenko
2026-03-24 11:51   ` Andy Shevchenko
2026-03-24 18:08     ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Anushka Badhe
2026-03-24 19:43       ` Anushka Badhe [this message]
2026-03-25 12:08         ` [PATCH v3] staging: media: " Andy Shevchenko
2026-03-25 13:24           ` [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration Anushka Badhe
2026-03-26 10:48             ` Andy Shevchenko
2026-03-25  8:45       ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Greg KH
2026-03-25  9:12         ` Anushka B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260324194356.49090-1-anushkabadhe@gmail.com \
    --to=anushkabadhe@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox