From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD5503C8720 for ; Wed, 25 Mar 2026 10:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436330; cv=none; b=ToXOEEYgG00g52dIVOpk87uyL5Lvp+5Z3EQVJhNsgJDsEiQa+L2TcB6izBKlM1BOWP0nRPEXKztmGDiglnAvI6E4qwhEO7a08Ut7ktC/QXTN3hucnUz+6BrD+Xy1JYNOPUnUXVkepRaEYqOhP3R1sIpYE713eHMopO68aoq1RGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436330; c=relaxed/simple; bh=d6ewd0OgnjdCKMEMQLVVi5WVY9nK65gp+GsUlIM3QjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P4KsykOTrm+CGH+MAa0nD7DT4k1LF6BK8otVN4uhxjgzvBdUVimHwLv0ja6WVFk2dPKzDi4DRPWOncfNBuNFBdg8Ai/fIJcnC7+tdfJMWu72Cl/+L7Z4H+rgGIRgJyvsc4goj0UUo7VmCsGL0vutSNIsLPzDFBHp9xecgk0au6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VFAikgi7; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VFAikgi7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774436330; x=1805972330; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=d6ewd0OgnjdCKMEMQLVVi5WVY9nK65gp+GsUlIM3QjM=; b=VFAikgi7oE2GWeCZoZFqjMm4jXvrQ6OkOmW+8FhUExkqqhR6evu8PSDv V9Axu7o6pPnpMZgR6kSd31sUyRd6T26WWox2BnO8iydY8/T+DnVvLmUr/ RqqkeswKICwLx7EZ0j9bx/bEL4S9cIK7/rF6C3K3Nmm53flrL56BSnJAY D3z8z6oKk9/bGg6jaK3MzESZ11REi5H/t5GAYwkPsKHwkaiDQWihxgBtW WiJ7DKdR7eghzz9kY6Z7J+qdBo7ytuFTzBoWhyU/xLAnB9hgDSmFUUbnY MsIuo0v0U8jsZRuR+foXPkp80NnjBVH55HZwW6utcmQgJxKv++kF5Fuws A==; X-CSE-ConnectionGUID: rznQBt13QR2I2r3uSsqB1Q== X-CSE-MsgGUID: lj0VpBIwTzq+6Ww1QoBfvw== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="74496419" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="74496419" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 03:58:49 -0700 X-CSE-ConnectionGUID: l8IUO/+hQhm4JM1XrNBmqg== X-CSE-MsgGUID: LhctG/gDRlO9TzOjgXHKRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="221763530" Received: from dalessan-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.64]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 03:58:43 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id ADE1F122472; Wed, 25 Mar 2026 12:58:30 +0200 (EET) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1w5LwJ-00000004wAp-0bdh; Wed, 25 Mar 2026 12:58:19 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra Subject: [PATCH v3 15/22] media: mc: Don't care about unsettable flags in MEDIA_IOC_LINK_SETUP Date: Wed, 25 Mar 2026 12:58:12 +0200 Message-ID: <20260325105818.1176816-17-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325105818.1176816-1-sakari.ailus@linux.intel.com> References: <20260325105818.1176816-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The implementation of MEDIA_IOC_LINK_SETUP currently requires that all flags that are set by the driver are correctly set as the driver expects. This poses a problem for adding new flags as programs could not work with links that have unknown flags even when the use of these flags wouldn't affect the program. Ignore the non-settable link flags. Signed-off-by: Sakari Ailus --- drivers/media/mc/mc-entity.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c index 717569bd1a8c..287eded356bb 100644 --- a/drivers/media/mc/mc-entity.c +++ b/drivers/media/mc/mc-entity.c @@ -1319,7 +1319,7 @@ static int __media_entity_setup_link_notify(struct media_link *link, u32 flags) int __media_entity_setup_link(struct media_link *link, u32 flags) { - const u32 mask = MEDIA_LNK_FL_ENABLED; + const u32 settable_flags = MEDIA_LNK_FL_ENABLED; struct media_device *mdev; struct media_pad *source, *sink; int ret = -EBUSY; @@ -1327,9 +1327,9 @@ int __media_entity_setup_link(struct media_link *link, u32 flags) if (link == NULL) return -EINVAL; - /* The non-modifiable link flags must not be modified. */ - if ((link->flags & ~mask) != (flags & ~mask)) - return -EINVAL; + /* Only allow changing user-settable flags. */ + flags &= settable_flags; + flags |= link->flags & ~settable_flags; if (link->flags & MEDIA_LNK_FL_IMMUTABLE) return link->flags == flags ? 0 : -EINVAL; -- 2.47.3