From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C42E33AE1B6 for ; Wed, 25 Mar 2026 10:58:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436320; cv=none; b=UxpOTADcLP9requUfrUPkOrw9vkBHKOoEjmq2TaN6T9BMONTUcAmjGidkZB45fXn9KlPpNzKFg6epd5aqc4OZTIJDvlyImeZyT1Sg1bNUH+5QXT8goaif2tSrIsUc/oAac+ijtxJSo4bZrmusL7eGXBKVOALt72mgnvW9dMoQgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436320; c=relaxed/simple; bh=lt7bCPHbpYooKcYOEuDZsDHcs9l7wNzglDdc3ZkPHxg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y2jzG5EtPOQNOR4hzfSUPEEbYrZZl1Dq04q4VouFMu1C91rFBT/mDIyFWBoN5Qsmx2coQBTA11D56UXZisFJdHhN8MXZqlqkjUMqyRz6vKaf7VWMNxPt6SZrXoQWKnDEagmDDfZLmuVySOOZlZEZb93axF3QBmBGnfF1SbAQZYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZgJ170m0; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZgJ170m0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774436319; x=1805972319; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lt7bCPHbpYooKcYOEuDZsDHcs9l7wNzglDdc3ZkPHxg=; b=ZgJ170m0wgRMVhiprxjHeVBq50Dd0E54FnRf5X0IZf1U8f6n+pfLPZDc d7nMtbaQvffK/3DzTZ790ueiCHQTrAs2fAw7Ipj8Sows6GnKUd1m67fOg UaFIC0kb2269wYDt0qcz3XxOjgBYGvpgVQ5KY1VzgrymEqW6CBpACKiwf 5RRFyuz6gupR4KhJc4GP8vt7yGs6mFA75Suo0JGdCNEWmjRm+WJP4htY7 ZFyf7LgXON4a9IT1JV21c0IuskGdqOJmH6T6AAhhoyv+b+ZbihBj5o1pv g5YGXIkhVhPYl3SG2l8Tw21KecGF0vzpmyzocYN//xZFr3Bh5b9RoXkHv A==; X-CSE-ConnectionGUID: hK3mP+NRRV2lB7hU1MgGBg== X-CSE-MsgGUID: 8hmgap5ZQR23tWYOm8hkIw== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="75186773" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="75186773" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 03:58:33 -0700 X-CSE-ConnectionGUID: DrfHVG/ISI6gWynVpFTsBA== X-CSE-MsgGUID: mEll4A5nSDSGGXPZXP2Q2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="262568556" Received: from dalessan-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.64]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 03:58:27 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 80B27121D27; Wed, 25 Mar 2026 12:58:30 +0200 (EET) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1w5LwI-00000004wA3-3xG2; Wed, 25 Mar 2026 12:58:18 +0200 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra Subject: [PATCH v3 04/22] media: imx219: Scale the vblank limits according to rate_factor Date: Wed, 25 Mar 2026 12:58:00 +0200 Message-ID: <20260325105818.1176816-5-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325105818.1176816-1-sakari.ailus@linux.intel.com> References: <20260325105818.1176816-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The limits for vertical blanking (and frame length in pixels) is related to the properties of the hardware, it's not in half-line units the driver uses. Multiply the vertical blanking limits by the rate_factor to satisty hardware requirements. Fixes: f513997119f4 ("media: i2c: imx219: Scale the pixel rate for analog binning") Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus --- drivers/media/i2c/imx219.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 62a23541b1dc..6819a2fa3262 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -878,14 +878,17 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2; if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) { + unsigned int rate_factor = imx219_get_rate_factor(state); int exposure_max; int exposure_def; int llp_min; int pixel_rate; /* Update limits and set FPS to default */ - ret = __v4l2_ctrl_modify_range(imx219->vblank, IMX219_VBLANK_MIN, - IMX219_FLL_MAX - mode->height, 1, + ret = __v4l2_ctrl_modify_range(imx219->vblank, + IMX219_VBLANK_MIN * rate_factor, + (IMX219_FLL_MAX - mode->height) * + rate_factor, rate_factor, mode->fll_def - mode->height); if (ret) return ret; @@ -928,8 +931,7 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, return ret; /* Scale the pixel rate based on the mode specific factor */ - pixel_rate = imx219_get_pixel_rate(imx219) * - imx219_get_rate_factor(state); + pixel_rate = imx219_get_pixel_rate(imx219) * rate_factor; ret = __v4l2_ctrl_modify_range(imx219->pixel_rate, pixel_rate, pixel_rate, 1, pixel_rate); if (ret) -- 2.47.3