From: Anushka Badhe <anushkabadhe@gmail.com>
To: andriy.shevchenko@intel.com
Cc: andy@kernel.org, anushkabadhe@gmail.com,
gregkh@linuxfoundation.org, hansg@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Subject: [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration
Date: Wed, 25 Mar 2026 18:54:34 +0530 [thread overview]
Message-ID: <20260325132434.55775-1-anushkabadhe@gmail.com> (raw)
In-Reply-To: <acPQOplQWD_-saf9@ashevche-desk.local>
Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
readability.
Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
Thank you so much for your review and guidance.
Changes in v4:
- Remove unrelated block comment style fixes
Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:
Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line
Note:
* This patch is part of the GSoC2026 application process for device tree
binding
s conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
drivers/staging/media/atomisp/pci/system_local.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..69bcd557a821 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -86,8 +86,7 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
/*GP TIMER , all timer registers are inter-twined,
* so, having multiple base addresses for
* different timers does not help*/
-const hrt_address GP_TIMER_BASE =
- (hrt_address)0x0000000000000600ULL;
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
/* GPIO */
const hrt_address GPIO_BASE[N_GPIO_ID] = {
--
2.43.0
next prev parent reply other threads:[~2026-03-25 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 8:10 [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line Anushka Badhe
2026-03-24 11:50 ` Andy Shevchenko
2026-03-24 11:51 ` Andy Shevchenko
2026-03-24 18:08 ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Anushka Badhe
2026-03-24 19:43 ` [PATCH v3] staging: media: " Anushka Badhe
2026-03-25 12:08 ` Andy Shevchenko
2026-03-25 13:24 ` Anushka Badhe [this message]
2026-03-26 10:48 ` [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration Andy Shevchenko
2026-03-25 8:45 ` [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration Greg KH
2026-03-25 9:12 ` Anushka B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325132434.55775-1-anushkabadhe@gmail.com \
--to=anushkabadhe@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox