From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D50733FEB12 for ; Thu, 26 Mar 2026 14:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774534890; cv=none; b=oQHWkXuv5CHCLRg/mWswze3l3kBuuie7EBNac63X/c8cqxtJ84XPN7HcfQ8rcMSfMWvTKPNz3MMM1xSICGENiyIGAy7ubsu9DdrQWxj6q+goW0P+uS/Xd/i4EZTz8zQFurAAEfS/hCuC7op3RBp8cMENzb7GVC7C2K86vB/dTw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774534890; c=relaxed/simple; bh=RJe9GzRsVnP9RgGUrpNPFKt+FZ5gT6tjolAsDsfcPn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QqgT71Z9E6erBUWGGUX9BxAcjvoQ6zXnNKcXqRn6ThtxdlIoXw2y2ozAHENLq6688GmBN6k/3Q/qTKUEUy5kK3Q7McDql3lRXEck7hzCw/7nsF+IVt6c+eVi3nVSDa5PFSWbFPvxCVbgZ6z9KC0aUXpuXn9jDzQhn1W5hl3kWQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ndIBRqvh; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ndIBRqvh" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486ff3a0fc1so10294865e9.2 for ; Thu, 26 Mar 2026 07:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774534880; x=1775139680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7X4Hw21VVlfFhBGvSzfDwQVT4JNcMNCdD8bUyasxiZU=; b=ndIBRqvhSgR/rfSMgo4lBh3zXtOUIJf7/saNuIwdqWUqEmlkIoXmSZgBqC8R6cwiq4 9aQVygocYQpZRDrh+wAHPKUnYNW8t+HZfwKL7yJOnKk4xx/5+2dPF2BykOdIhQ5DALpK kc1Kg4dP/PLFh94+JbSgB3LOrftzoT7N56/pEq44jZtXc75mlRfiKy8gGGV58JTkt8L5 e4y1HMkq7nrpHvhwzkTzgTVO4+2/Fu5GypZUgIAjGc0RQ0AuayDjISpnh56vS2G9GpEp V9+NBqWdvRK2NIUMsEV4d8ikfJogbNbuxLUqc8oHijSzgZuq+WP8YRFDmeMZDYJ8VK6e fZTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774534880; x=1775139680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7X4Hw21VVlfFhBGvSzfDwQVT4JNcMNCdD8bUyasxiZU=; b=gpJRUZSwR3oLd4o2vCMoLXZZmhyYz9ViQkIhMnFBL5XoGWThfOOjW+jf7TQvcams4E VfHaSYCjaSrP8kszyH9DQxdeJbiwnt/AzQ5mK8BYZ+YCEG+PJYS/gnk2o9XTXkyvXy3K 83vM0AJquV9w7WlJlAvwM1Z2hhwcYKdvsOJhqIoNGsoUhQT5gGic7rVGQaCFSYpE4Po7 h0lLweGavynmHV197ATyZsCfp96s86GK9bzoTs7CyimuykpKM59/t6md+G5VtnMg5zBX 8XTtCYfCZ4N9YFfR8Jmt1ADOmdFl1liMatVKNZZ9Ow1TZyzzWrtF2gZsFtQeZrQWGvcx kG8A== X-Gm-Message-State: AOJu0YyztSLB5m5Z3n3Ud8s5/AC5qnm28MS0pj3+7EHF7z19S1PlGXB6 ejfTqBcXZ+5w265AUsN85eFnnwGsazjt7Y7bnl5Y7uToYVt0E8MRqOs1 X-Gm-Gg: ATEYQzyxp1j7UXy+6v3rY25DT5Y7yPUIHe2ej8/dW77BqfOvaRuQwhniuWMkqBBnlUe 2qD5ha9894i/HeBNxkCs3xo/8KqaR4WDrhe0D8+WSDZZclTAy6Cp9nSLwD7dfl54VXNfuDL/jnY 4frcAqsA9zSBQgtY0D1x0hX8iCLmfjvvYrPgGU4anSP+Lz5F2K+euWMQDZPSrFy0SSCLQ0ZeYUw isGEH66AEdn0gHglyz+h2SDRgW5jDxBRjieXA8eFuck4850A77TeRGWEVGtorcv2M5gZ0v6ga9c 6Py337CzGPObvP+jq6NZRkkrSkntipMQz5BGXacWB8UQ/5o8B99qPqqUKRpz016j8IZINce3aIy 0B7gVR6w7pHqI9CPmpdp9xweZ5+2+R4/ayoGInvnyr8PAwWLB8MBmfHQ7q0PJ8QoSy63wriFsvH cmXkQpJzjk7AyRuc12ajh2eeBYG4Yflw+4XeNEbIJenULvRlTN8+LSF0tz5P73R5GXBfzIm3TmC EJfhdD9303sV5rWhfh3q3hKvaANDaeI5nM3NQ== X-Received: by 2002:a05:600c:37cc:b0:486:fa35:aef2 with SMTP id 5b1f17b1804b1-48715fbfee6mr126722855e9.4.1774534880027; Thu, 26 Mar 2026 07:21:20 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:516a:f94c:8d31:fabd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c65989sm63574445e9.2.2026.03.26.07.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 07:21:19 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , Hans de Goede , Laurent Pinchart , Vladimir Zapolskiy , Mehdi Djait , Xiaolei Wang , Benjamin Mugnier , Sylvain Petinot , Hardevsinh Palaniya Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , Laurent Pinchart Subject: [PATCH 1/2] media: i2c: ov5645: Report streams using frame descriptors Date: Thu, 26 Mar 2026 14:21:06 +0000 Message-ID: <20260326142107.297811-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326142107.297811-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260326142107.297811-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lad Prabhakar Implement the .get_frame_desc() subdev operation to report information about streams to the connected CSI-2 receiver. This is required to let the CSI-2 receiver driver know about virtual channels and data types for each stream. Signed-off-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- Changes since v3 [0], - Added a macro for the source pad index. - Updated ov5645_init_state() to use the new macro. [0] https://lore.kernel.org/all/20241018153230.235647-9-prabhakar.mahadev-lad.rj@bp.renesas.com/ Hi Laurent, Ive restored your RB tag with the above changes. Please let me know if you have any further comments. Cheers, Prabhakar --- drivers/media/i2c/ov5645.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c index b10d408034a1..df9001fce44d 100644 --- a/drivers/media/i2c/ov5645.c +++ b/drivers/media/i2c/ov5645.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -68,6 +69,8 @@ static const char * const ov5645_supply_name[] = { #define OV5645_NUM_SUPPLIES ARRAY_SIZE(ov5645_supply_name) +#define OV5645_PAD_SOURCE 0 + struct reg_value { u16 reg; u8 val; @@ -817,6 +820,29 @@ static const struct v4l2_ctrl_ops ov5645_ctrl_ops = { .s_ctrl = ov5645_s_ctrl, }; +static int ov5645_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_mbus_frame_desc *fd) +{ + struct v4l2_subdev_state *state; + u32 code; + + state = v4l2_subdev_lock_and_get_active_state(sd); + code = v4l2_subdev_state_get_format(state, OV5645_PAD_SOURCE, 0)->code; + v4l2_subdev_unlock_state(state); + + fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2; + fd->num_entries = 1; + + memset(fd->entry, 0, sizeof(fd->entry)); + + fd->entry[0].pixelcode = code; + fd->entry[0].stream = 0; + fd->entry[0].bus.csi2.vc = 0; + fd->entry[0].bus.csi2.dt = MIPI_CSI2_DT_YUV422_8B; + + return 0; +} + static int ov5645_enum_mbus_code(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_mbus_code_enum *code) @@ -897,7 +923,7 @@ static int ov5645_init_state(struct v4l2_subdev *subdev, { struct v4l2_subdev_format fmt = { .which = V4L2_SUBDEV_FORMAT_TRY, - .pad = 0, + .pad = OV5645_PAD_SOURCE, .format = { .code = MEDIA_BUS_FMT_UYVY8_1X16, .width = ov5645_mode_info_data[1].width, @@ -988,6 +1014,7 @@ static const struct v4l2_subdev_video_ops ov5645_video_ops = { }; static const struct v4l2_subdev_pad_ops ov5645_subdev_pad_ops = { + .get_frame_desc = ov5645_get_frame_desc, .enum_mbus_code = ov5645_enum_mbus_code, .enum_frame_size = ov5645_enum_frame_size, .get_fmt = v4l2_subdev_get_fmt, -- 2.53.0