From: kernel test robot <lkp@intel.com>
To: David Carlier <devnexen@gmail.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nayden Kanchev <nayden.kanchev@arm.com>,
Hans Verkuil <hverkuil@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org,
David Carlier <devnexen@gmail.com>
Subject: Re: [PATCH] media: mali-c55: fix resource leaks in probe and remove
Date: Fri, 27 Mar 2026 12:29:08 +0800 [thread overview]
Message-ID: <202603271219.b8QddrPS-lkp@intel.com> (raw)
In-Reply-To: <20260326190052.11780-1-devnexen@gmail.com>
Hi David,
kernel test robot noticed the following build warnings:
[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master v7.0-rc5 next-20260326]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/David-Carlier/media-mali-c55-fix-resource-leaks-in-probe-and-remove/20260327-045201
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/20260326190052.11780-1-devnexen%40gmail.com
patch subject: [PATCH] media: mali-c55: fix resource leaks in probe and remove
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260327/202603271219.b8QddrPS-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260327/202603271219.b8QddrPS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603271219.b8QddrPS-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/media/platform/arm/mali-c55/mali-c55-core.c: In function 'mali_c55_probe':
>> drivers/media/platform/arm/mali-c55/mali-c55-core.c:883:1: warning: label 'err_free_context_registers' defined but not used [-Wunused-label]
883 | err_free_context_registers:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/err_free_context_registers +883 drivers/media/platform/arm/mali-c55/mali-c55-core.c
d5f281f3dd2988 Daniel Scally 2025-11-11 804
d5f281f3dd2988 Daniel Scally 2025-11-11 805 static int mali_c55_probe(struct platform_device *pdev)
d5f281f3dd2988 Daniel Scally 2025-11-11 806 {
d5f281f3dd2988 Daniel Scally 2025-11-11 807 struct device *dev = &pdev->dev;
d5f281f3dd2988 Daniel Scally 2025-11-11 808 struct mali_c55 *mali_c55;
d5f281f3dd2988 Daniel Scally 2025-11-11 809 struct resource *res;
d5f281f3dd2988 Daniel Scally 2025-11-11 810 int ret;
d5f281f3dd2988 Daniel Scally 2025-11-11 811
d5f281f3dd2988 Daniel Scally 2025-11-11 812 mali_c55 = devm_kzalloc(dev, sizeof(*mali_c55), GFP_KERNEL);
d5f281f3dd2988 Daniel Scally 2025-11-11 813 if (!mali_c55)
d5f281f3dd2988 Daniel Scally 2025-11-11 814 return -ENOMEM;
d5f281f3dd2988 Daniel Scally 2025-11-11 815
d5f281f3dd2988 Daniel Scally 2025-11-11 816 mali_c55->dev = dev;
d5f281f3dd2988 Daniel Scally 2025-11-11 817 platform_set_drvdata(pdev, mali_c55);
d5f281f3dd2988 Daniel Scally 2025-11-11 818
d5f281f3dd2988 Daniel Scally 2025-11-11 819 mali_c55->base = devm_platform_get_and_ioremap_resource(pdev, 0,
d5f281f3dd2988 Daniel Scally 2025-11-11 820 &res);
d5f281f3dd2988 Daniel Scally 2025-11-11 821 if (IS_ERR(mali_c55->base))
d5f281f3dd2988 Daniel Scally 2025-11-11 822 return dev_err_probe(dev, PTR_ERR(mali_c55->base),
d5f281f3dd2988 Daniel Scally 2025-11-11 823 "failed to map IO memory\n");
d5f281f3dd2988 Daniel Scally 2025-11-11 824
d5f281f3dd2988 Daniel Scally 2025-11-11 825 for (unsigned int i = 0; i < ARRAY_SIZE(mali_c55_clk_names); i++)
d5f281f3dd2988 Daniel Scally 2025-11-11 826 mali_c55->clks[i].id = mali_c55_clk_names[i];
d5f281f3dd2988 Daniel Scally 2025-11-11 827
d5f281f3dd2988 Daniel Scally 2025-11-11 828 ret = devm_clk_bulk_get(dev, ARRAY_SIZE(mali_c55->clks), mali_c55->clks);
d5f281f3dd2988 Daniel Scally 2025-11-11 829 if (ret)
d5f281f3dd2988 Daniel Scally 2025-11-11 830 return dev_err_probe(dev, ret, "failed to acquire clocks\n");
d5f281f3dd2988 Daniel Scally 2025-11-11 831
d5f281f3dd2988 Daniel Scally 2025-11-11 832 for (unsigned int i = 0; i < ARRAY_SIZE(mali_c55_reset_names); i++)
d5f281f3dd2988 Daniel Scally 2025-11-11 833 mali_c55->resets[i].id = mali_c55_reset_names[i];
d5f281f3dd2988 Daniel Scally 2025-11-11 834
d5f281f3dd2988 Daniel Scally 2025-11-11 835 ret = devm_reset_control_bulk_get_optional_shared(dev,
d5f281f3dd2988 Daniel Scally 2025-11-11 836 ARRAY_SIZE(mali_c55_reset_names), mali_c55->resets);
d5f281f3dd2988 Daniel Scally 2025-11-11 837 if (ret)
d5f281f3dd2988 Daniel Scally 2025-11-11 838 return dev_err_probe(dev, ret, "failed to acquire resets\n");
d5f281f3dd2988 Daniel Scally 2025-11-11 839
d5f281f3dd2988 Daniel Scally 2025-11-11 840 of_reserved_mem_device_init(dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 841 vb2_dma_contig_set_max_seg_size(dev, UINT_MAX);
d5f281f3dd2988 Daniel Scally 2025-11-11 842
d5f281f3dd2988 Daniel Scally 2025-11-11 843 ret = __mali_c55_power_on(mali_c55);
3b2d04fb011b8b David Carlier 2026-03-26 844 if (ret) {
3b2d04fb011b8b David Carlier 2026-03-26 845 dev_err_probe(dev, ret, "failed to power on\n");
3b2d04fb011b8b David Carlier 2026-03-26 846 goto err_release_mem;
3b2d04fb011b8b David Carlier 2026-03-26 847 }
d5f281f3dd2988 Daniel Scally 2025-11-11 848
d5f281f3dd2988 Daniel Scally 2025-11-11 849 ret = mali_c55_check_hwcfg(mali_c55);
d5f281f3dd2988 Daniel Scally 2025-11-11 850 if (ret)
d5f281f3dd2988 Daniel Scally 2025-11-11 851 goto err_power_off;
d5f281f3dd2988 Daniel Scally 2025-11-11 852
d5f281f3dd2988 Daniel Scally 2025-11-11 853 ret = mali_c55_init_context(mali_c55, res);
d5f281f3dd2988 Daniel Scally 2025-11-11 854 if (ret)
d5f281f3dd2988 Daniel Scally 2025-11-11 855 goto err_power_off;
d5f281f3dd2988 Daniel Scally 2025-11-11 856
d5f281f3dd2988 Daniel Scally 2025-11-11 857 mali_c55->media_dev.dev = dev;
d5f281f3dd2988 Daniel Scally 2025-11-11 858
d5f281f3dd2988 Daniel Scally 2025-11-11 859 pm_runtime_set_autosuspend_delay(&pdev->dev, 2000);
d5f281f3dd2988 Daniel Scally 2025-11-11 860 pm_runtime_use_autosuspend(&pdev->dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 861 pm_runtime_set_active(&pdev->dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 862 pm_runtime_enable(&pdev->dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 863
d5f281f3dd2988 Daniel Scally 2025-11-11 864 ret = mali_c55_media_frameworks_init(mali_c55);
d5f281f3dd2988 Daniel Scally 2025-11-11 865 if (ret)
3b2d04fb011b8b David Carlier 2026-03-26 866 goto err_runtime_disable;
d5f281f3dd2988 Daniel Scally 2025-11-11 867
d5f281f3dd2988 Daniel Scally 2025-11-11 868 pm_runtime_idle(&pdev->dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 869
d5f281f3dd2988 Daniel Scally 2025-11-11 870 mali_c55->irqnum = platform_get_irq(pdev, 0);
d5f281f3dd2988 Daniel Scally 2025-11-11 871 if (mali_c55->irqnum < 0) {
d5f281f3dd2988 Daniel Scally 2025-11-11 872 ret = mali_c55->irqnum;
d5f281f3dd2988 Daniel Scally 2025-11-11 873 dev_err(dev, "failed to get interrupt\n");
d5f281f3dd2988 Daniel Scally 2025-11-11 874 goto err_deinit_media_frameworks;
d5f281f3dd2988 Daniel Scally 2025-11-11 875 }
d5f281f3dd2988 Daniel Scally 2025-11-11 876
d5f281f3dd2988 Daniel Scally 2025-11-11 877 return 0;
d5f281f3dd2988 Daniel Scally 2025-11-11 878
d5f281f3dd2988 Daniel Scally 2025-11-11 879 err_deinit_media_frameworks:
d5f281f3dd2988 Daniel Scally 2025-11-11 880 mali_c55_media_frameworks_deinit(mali_c55);
3b2d04fb011b8b David Carlier 2026-03-26 881 err_runtime_disable:
d5f281f3dd2988 Daniel Scally 2025-11-11 882 pm_runtime_disable(&pdev->dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 @883 err_free_context_registers:
d5f281f3dd2988 Daniel Scally 2025-11-11 884 kfree(mali_c55->context.registers);
d5f281f3dd2988 Daniel Scally 2025-11-11 885 err_power_off:
d5f281f3dd2988 Daniel Scally 2025-11-11 886 __mali_c55_power_off(mali_c55);
3b2d04fb011b8b David Carlier 2026-03-26 887 err_release_mem:
3b2d04fb011b8b David Carlier 2026-03-26 888 of_reserved_mem_device_release(dev);
d5f281f3dd2988 Daniel Scally 2025-11-11 889
d5f281f3dd2988 Daniel Scally 2025-11-11 890 return ret;
d5f281f3dd2988 Daniel Scally 2025-11-11 891 }
d5f281f3dd2988 Daniel Scally 2025-11-11 892
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-03-27 4:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 19:00 [PATCH] media: mali-c55: fix resource leaks in probe and remove David Carlier
2026-03-26 20:33 ` David Carlier
2026-03-26 22:06 ` Dan Scally
2026-03-27 4:29 ` kernel test robot [this message]
2026-03-27 6:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603271219.b8QddrPS-lkp@intel.com \
--to=lkp@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=devnexen@gmail.com \
--cc=hverkuil@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nayden.kanchev@arm.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox