Re: [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion

Sakari Ailus
2026-04-21T16:37:32Z

Hi Sunny,

Thanks for the update.

Please always set the version of the patch if not the first.

On Thu, Apr 09, 2026 at 10:45:23PM +0530, Sunny Patel wrote:
> Removal is only required afte state->pads for stream_configs since
> state->pads only represents the static array so not required locking for
> it.
>
>

Extra newline.

> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.

Please use imperative when describing what the patch does.

>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---

Please describe changes across versions, at least from the previous one.

> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -
> if (state->pads) {
> if (stream)
> return NULL;

--
Kind regards,

Sakari Ailus