Re: [PATCH v4 06/29] media: imx219: Don't update exposure limits while setting format

Jacopo Mondi
2026-04-10T08:44:39Z

Hi Sakari

On Wed, Apr 08, 2026 at 06:39:15PM +0300, Sakari Ailus wrote:
> Don't update exposure limits explicitly while setting format. This is
> already done through the s_ctrl() callback.

already done through the s_ctrl() callback for the VBLANK control.

>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
> drivers/media/i2c/imx219.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index a72630ad1561..ca6a5939773d 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -867,8 +867,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
> crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2;
>
> if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
> - int exposure_max;
> - int exposure_def;
> int llp_min;
> int pixel_rate;
>
> @@ -887,18 +885,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
> if (ret)
> return ret;
>
> - /* Update max exposure while meeting expected vblanking */
> - exposure_max = mode->fll_def - IMX219_EXPOSURE_OFFSET;
> - exposure_def = (exposure_max < IMX219_EXPOSURE_DEFAULT) ?
> - exposure_max : IMX219_EXPOSURE_DEFAULT;
> - ret = __v4l2_ctrl_modify_range(imx219->exposure,
> - imx219->exposure->minimum,
> - exposure_max,
> - imx219->exposure->step,
> - exposure_def);
> - if (ret)
> - return ret;
> -
> /*
> * With analog binning the default minimum line length of 3448
> * can cause artefacts with RAW10 formats, because the ADC
> --
> 2.47.3
>
>