From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com,
Prabhakar <prabhakar.csengg@gmail.com>,
"Kate Hsuan" <hpa@redhat.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Tommaso Merciai" <tomm.merciai@gmail.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Julien Massot" <julien.massot@collabora.com>,
"Naushir Patuck" <naush@raspberrypi.com>,
"Yan, Dongcheng" <dongcheng.yan@intel.com>,
"Cao, Bingbu" <bingbu.cao@intel.com>,
"Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
"Stefan Klug" <stefan.klug@ideasonboard.com>,
"Mirela Rabulea" <mirela.rabulea@nxp.com>,
"André Apitzsch" <git@apitzsch.eu>,
"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Mehdi Djait" <mehdi.djait@linux.intel.com>,
"Ricardo Ribalda Delgado" <ribalda@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"David Plowman" <david.plowman@raspberrypi.com>,
"Yu, Ong Hock" <ong.hock.yu@intel.com>,
"Ng, Khai Wen" <khai.wen.ng@intel.com>,
"Jai Luthra" <jai.luthra@ideasonboard.com>,
"Rishikesh Donadkar" <r-donadkar@ti.com>
Subject: [PATCH v4 01/29] media: imx219: Rename "PIXEL_ARRAY" as "VISIBLE"
Date: Wed, 8 Apr 2026 18:39:10 +0300 [thread overview]
Message-ID: <20260408153939.969381-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20260408153939.969381-1-sakari.ailus@linux.intel.com>
The imx219 driver uses macros for denoting the size of the pixel array.
The values reflect the area of manufacturer-designated visible pixels,
reflect this in the naming by calling it "VISIBLE" instead of
"PIXEL_ARRAY".
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/imx219.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 7da02ce5da15..cbd151d4af5f 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -142,10 +142,10 @@
/* IMX219 native and active pixel array size. */
#define IMX219_NATIVE_WIDTH 3296U
#define IMX219_NATIVE_HEIGHT 2480U
-#define IMX219_PIXEL_ARRAY_LEFT 8U
-#define IMX219_PIXEL_ARRAY_TOP 8U
-#define IMX219_PIXEL_ARRAY_WIDTH 3280U
-#define IMX219_PIXEL_ARRAY_HEIGHT 2464U
+#define IMX219_VISIBLE_LEFT 8U
+#define IMX219_VISIBLE_TOP 8U
+#define IMX219_VISIBLE_WIDTH 3280U
+#define IMX219_VISIBLE_HEIGHT 2464U
/* Mode : resolution and related config&values */
struct imx219_mode {
@@ -675,13 +675,13 @@ static int imx219_set_framefmt(struct imx219 *imx219,
bpp = imx219_get_format_bpp(format);
cci_write(imx219->regmap, IMX219_REG_X_ADD_STA_A,
- crop->left - IMX219_PIXEL_ARRAY_LEFT, &ret);
+ crop->left - IMX219_VISIBLE_LEFT, &ret);
cci_write(imx219->regmap, IMX219_REG_X_ADD_END_A,
- crop->left - IMX219_PIXEL_ARRAY_LEFT + crop->width - 1, &ret);
+ crop->left - IMX219_VISIBLE_LEFT + crop->width - 1, &ret);
cci_write(imx219->regmap, IMX219_REG_Y_ADD_STA_A,
- crop->top - IMX219_PIXEL_ARRAY_TOP, &ret);
+ crop->top - IMX219_VISIBLE_TOP, &ret);
cci_write(imx219->regmap, IMX219_REG_Y_ADD_END_A,
- crop->top - IMX219_PIXEL_ARRAY_TOP + crop->height - 1, &ret);
+ crop->top - IMX219_VISIBLE_TOP + crop->height - 1, &ret);
imx219_get_binning(state, &bin_h, &bin_v);
cci_write(imx219->regmap, IMX219_REG_BINNING_MODE_H, bin_h, &ret);
@@ -867,8 +867,8 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd,
* Use binning to maximize the crop rectangle size, and centre it in the
* sensor.
*/
- bin_h = min(IMX219_PIXEL_ARRAY_WIDTH / format->width, 2U);
- bin_v = min(IMX219_PIXEL_ARRAY_HEIGHT / format->height, 2U);
+ bin_h = min(IMX219_VISIBLE_WIDTH / format->width, 2U);
+ bin_v = min(IMX219_VISIBLE_HEIGHT / format->height, 2U);
/* Ensure bin_h and bin_v are same to avoid 1:2 or 2:1 stretching */
binning = min(bin_h, bin_v);
@@ -967,10 +967,10 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
case V4L2_SEL_TGT_CROP_DEFAULT:
case V4L2_SEL_TGT_CROP_BOUNDS:
- sel->r.top = IMX219_PIXEL_ARRAY_TOP;
- sel->r.left = IMX219_PIXEL_ARRAY_LEFT;
- sel->r.width = IMX219_PIXEL_ARRAY_WIDTH;
- sel->r.height = IMX219_PIXEL_ARRAY_HEIGHT;
+ sel->r.top = IMX219_VISIBLE_TOP;
+ sel->r.left = IMX219_VISIBLE_LEFT;
+ sel->r.width = IMX219_VISIBLE_WIDTH;
+ sel->r.height = IMX219_VISIBLE_HEIGHT;
return 0;
}
--
2.47.3
next prev parent reply other threads:[~2026-04-08 15:39 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:39 [PATCH v4 00/29] Metadata series preparation Sakari Ailus
2026-04-08 15:39 ` Sakari Ailus [this message]
2026-04-16 13:14 ` [PATCH v4 01/29] media: imx219: Rename "PIXEL_ARRAY" as "VISIBLE" Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 02/29] media: imx219: Fix maximum frame length in lines Sakari Ailus
2026-04-16 13:56 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 03/29] media: imx219: Set horizontal blanking on mode change Sakari Ailus
2026-04-10 7:27 ` Jacopo Mondi
2026-04-16 14:22 ` Laurent Pinchart
2026-04-16 14:38 ` Dave Stevenson
2026-04-08 15:39 ` [PATCH v4 04/29] media: imx219: Scale the vblank limits according to rate_factor Sakari Ailus
2026-04-10 8:28 ` Jacopo Mondi
2026-04-10 8:41 ` Sakari Ailus
2026-04-10 9:01 ` Jacopo Mondi
2026-04-20 21:08 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 05/29] media: imx219: Fix vertical blanking and exposure for analogue binning Sakari Ailus
2026-04-10 8:42 ` Jacopo Mondi
2026-04-10 8:46 ` Sakari Ailus
2026-04-10 8:56 ` Jacopo Mondi
2026-04-10 9:04 ` Sakari Ailus
2026-04-10 13:38 ` Jacopo Mondi
2026-04-15 14:38 ` Jai Luthra
2026-04-20 21:02 ` Sakari Ailus
2026-04-15 17:15 ` Jai Luthra
2026-04-20 20:54 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 06/29] media: imx219: Don't update exposure limits while setting format Sakari Ailus
2026-04-10 8:44 ` Jacopo Mondi
2026-04-10 10:14 ` Sakari Ailus
2026-04-10 10:29 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 07/29] media: imx219: Rename "binning" as "bin_hv" in imx219_set_pad_format Sakari Ailus
2026-04-16 14:25 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 08/29] media: imx274: Remove redundant kernel-doc comments Sakari Ailus
2026-04-10 8:48 ` Jacopo Mondi
2026-04-10 8:54 ` Sakari Ailus
2026-04-10 9:02 ` Jacopo Mondi
2026-04-16 14:26 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 09/29] media: imx334: " Sakari Ailus
2026-04-10 9:02 ` Jacopo Mondi
2026-04-16 14:27 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 10/29] media: imx335: " Sakari Ailus
2026-04-10 9:02 ` Jacopo Mondi
2026-04-16 14:27 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 11/29] media: imx412: " Sakari Ailus
2026-04-10 9:03 ` Jacopo Mondi
2026-04-16 14:28 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 12/29] media: ov9282: " Sakari Ailus
2026-04-10 9:08 ` Jacopo Mondi
2026-04-16 14:28 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 13/29] media: tvp514x: " Sakari Ailus
2026-04-10 9:08 ` Jacopo Mondi
2026-04-16 14:28 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 14/29] media: Documentation: Improve LINK_FREQ documentation Sakari Ailus
2026-04-16 15:05 ` Laurent Pinchart
2026-04-21 14:42 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 15/29] media: Documentation: Improve pixel rate calculation documentation Sakari Ailus
2026-04-16 16:20 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 16/29] media: v4l2-subdev: Refactor returning routes Sakari Ailus
2026-04-16 16:24 ` Laurent Pinchart
2026-04-21 14:50 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 17/29] media: v4l2-subdev: Allow accessing routes with STREAMS client capability Sakari Ailus
2026-04-16 15:06 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 18/29] media: mc: Simplify link processing in __media_pipeline_start() Sakari Ailus
2026-04-10 9:26 ` Jacopo Mondi
2026-04-16 14:35 ` Laurent Pinchart
2026-04-21 10:24 ` Sakari Ailus
2026-04-21 11:18 ` Laurent Pinchart
2026-04-21 12:37 ` Sakari Ailus
2026-04-21 22:10 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 19/29] media: mc: Separate single link validation into a new function Sakari Ailus
2026-04-10 9:29 ` Jacopo Mondi
2026-04-16 16:35 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 20/29] media: uapi: Bump the STREAMS bit a little Sakari Ailus
2026-04-10 9:31 ` Jacopo Mondi
2026-04-16 14:31 ` Laurent Pinchart
2026-04-21 10:27 ` Sakari Ailus
2026-04-21 11:18 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 21/29] media: mc: Don't care about unsettable flags in MEDIA_IOC_LINK_SETUP Sakari Ailus
2026-04-10 10:31 ` Jacopo Mondi
2026-04-10 12:56 ` Sakari Ailus
2026-04-10 13:24 ` Jacopo Mondi
2026-04-16 15:59 ` Laurent Pinchart
2026-04-21 10:44 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 22/29] media: mc: Add MEDIA_LNK_FL_VALIDATE_LATE Sakari Ailus
2026-04-10 10:41 ` Jacopo Mondi
2026-04-13 7:59 ` Sakari Ailus
2026-04-13 9:30 ` Jacopo Mondi
2026-04-16 16:29 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 23/29] media: Improve enable_streams and disable_streams documentation Sakari Ailus
2026-04-16 15:49 ` Laurent Pinchart
2026-04-21 15:35 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 24/29] media: v4l2-subdev: Introduce v4l2_subdev_get_frame_desc() Sakari Ailus
2026-04-10 10:53 ` Jacopo Mondi
2026-04-13 8:07 ` Sakari Ailus
2026-04-16 16:16 ` Laurent Pinchart
2026-04-21 12:18 ` Sakari Ailus
2026-04-21 22:18 ` Laurent Pinchart
2026-04-22 8:26 ` Sakari Ailus
2026-04-22 9:02 ` Laurent Pinchart
2026-04-22 10:02 ` Sakari Ailus
2026-04-22 10:47 ` Laurent Pinchart
2026-04-22 10:48 ` Sakari Ailus
2026-04-22 10:54 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 25/29] media: v4l2-subdev: Move subdev client capabilities into a new struct Sakari Ailus
2026-04-10 13:31 ` Jacopo Mondi
2026-04-13 8:11 ` Sakari Ailus
2026-04-13 12:42 ` Jacopo Mondi
2026-04-16 17:30 ` Laurent Pinchart
2026-04-23 7:02 ` Jacopo Mondi
2026-04-08 15:39 ` [PATCH v4 26/29] media: v4l2-subdev: Add struct v4l2_subdev_client_info pointer to pad ops Sakari Ailus
2026-04-16 17:32 ` Laurent Pinchart
2026-04-08 15:39 ` [PATCH v4 27/29] media: v4l2-subdev: Add v4l2_subdev_call_ci_active_state Sakari Ailus
2026-04-16 17:38 ` Laurent Pinchart
2026-04-21 16:04 ` Sakari Ailus
2026-04-21 16:12 ` Laurent Pinchart
2026-04-21 16:34 ` Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 28/29] media: v4l2-subdev: Perform client info changes to i2c drivers Sakari Ailus
2026-04-08 15:39 ` [PATCH v4 29/29] media: v4l2-subdev: Add struct v4l2_subdev_client_info argument to pad ops Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408153939.969381-2-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=bingbu.cao@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.com \
--cc=david.plowman@raspberrypi.com \
--cc=dongcheng.yan@intel.com \
--cc=git@apitzsch.eu \
--cc=hans@jjverkuil.nl \
--cc=hansg@kernel.org \
--cc=heimir.sverrisson@gmail.com \
--cc=hpa@redhat.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jai.luthra@ideasonboard.com \
--cc=julien.massot@collabora.com \
--cc=khai.wen.ng@intel.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=mirela.rabulea@nxp.com \
--cc=naush@raspberrypi.com \
--cc=ong.hock.yu@intel.com \
--cc=prabhakar.csengg@gmail.com \
--cc=r-donadkar@ti.com \
--cc=ribalda@kernel.org \
--cc=stefan.klug@ideasonboard.com \
--cc=sylvain.petinot@foss.st.com \
--cc=tian.shu.qiu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox