From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996263D6CAE for ; Wed, 8 Apr 2026 15:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775662797; cv=none; b=iuwsn3U47Rc3tSFqD5U/KGhEhCVa8X6p61fB+nnmAiBb7FXT8rjQuaNIE7Nq+S4Wfo/AV4cRwiodRmHHoWqxJYVXc7nW+J8sAMOnT739tVqveEMsoYrt/fCBr1NPGLEpRK0bWHqY/orXsA7i4LY0KxLLqeDSu+datxAr6Qkjil4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775662797; c=relaxed/simple; bh=blCU1YDYTf+exv4TLHu/bS1Q1d5U1mSnefsRXOzKjdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tDqgdK+mKb0JX0k65NEyZaiV8CgcAiDy4y9qFY9gzHDL5zSnKWtgsVdHhs+5oj25dwmfbulOdGuzR6j03B8pg7QXv2Rvxi4TSSJ0JmQ+bR1Tt72w8WmpuuPhRO3efCty4LW9HMULdI4CSfgBEGh6BaSLGt3FnC33gYpnZ6KEbI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=glW0L9NR; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="glW0L9NR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775662794; x=1807198794; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=blCU1YDYTf+exv4TLHu/bS1Q1d5U1mSnefsRXOzKjdM=; b=glW0L9NRyixbYlk9GPIPeZppn1UxXNcm4GJxwy0m9XUqGphrGssMEncQ XOYvv1SZqaS0JoWsc6QMtYjKmbNEJUQz7cNFyyS3OULsSaK3SWzpI8SO5 FZODZ4KPuqM3COT/68cpVT4h3u0x4Vh9DU44TIFdNsUhH4m6dOOVhUDPI M9zKjxvoRnsf7807MWDXQePyjD3S86Rd5ciXUF6rGT9OuvBzSWOncz0cH mqvsbE1rNdxfDj/yWhOk46heyhdEawmjlfVLAMAbekfui9p0TU80Yae+8 OcgJKuW1eFjvpG6Klhyq6B4sa0vtIwiPwiESepu26mM/ZoJ8byhxlFTaE g==; X-CSE-ConnectionGUID: KkEGZBVwRxm94mmouS0fog== X-CSE-MsgGUID: dDtOA8z2SfisoVuBVXy+UQ== X-IronPort-AV: E=McAfee;i="6800,10657,11753"; a="94038298" X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="94038298" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 08:39:52 -0700 X-CSE-ConnectionGUID: f34J0F2TTzu867xysNa/zQ== X-CSE-MsgGUID: 0RwJBu2KS+GjejmTPGbd1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="223740274" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.104]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 08:39:45 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id E29AD121DE3; Wed, 08 Apr 2026 18:39:50 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wAV0F-000000044Cg-1LpM; Wed, 08 Apr 2026 18:39:39 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: [PATCH v4 06/29] media: imx219: Don't update exposure limits while setting format Date: Wed, 8 Apr 2026 18:39:15 +0300 Message-ID: <20260408153939.969381-7-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260408153939.969381-1-sakari.ailus@linux.intel.com> References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Don't update exposure limits explicitly while setting format. This is already done through the s_ctrl() callback. Signed-off-by: Sakari Ailus --- drivers/media/i2c/imx219.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index a72630ad1561..ca6a5939773d 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -867,8 +867,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, crop->top = (IMX219_NATIVE_HEIGHT - crop->height) / 2; if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE) { - int exposure_max; - int exposure_def; int llp_min; int pixel_rate; @@ -887,18 +885,6 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, if (ret) return ret; - /* Update max exposure while meeting expected vblanking */ - exposure_max = mode->fll_def - IMX219_EXPOSURE_OFFSET; - exposure_def = (exposure_max < IMX219_EXPOSURE_DEFAULT) ? - exposure_max : IMX219_EXPOSURE_DEFAULT; - ret = __v4l2_ctrl_modify_range(imx219->exposure, - imx219->exposure->minimum, - exposure_max, - imx219->exposure->step, - exposure_def); - if (ret) - return ret; - /* * With analog binning the default minimum line length of 3448 * can cause artefacts with RAW10 formats, because the ADC -- 2.47.3