Re: [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion

Laurent Pinchart
2026-04-06T12:23:50Z

When submitting new versions of a patch (or patch series), please
remember to indicate the version in the subject line. The -v option to
git-format-patch helps.

On Mon, Apr 06, 2026 at 03:28:50PM +0530, Sunny Patel wrote:
> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.
>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -

Why do you remove this assertion and not the next one ?

> if (state->pads) {
> if (stream)
> return NULL;

--
Regards,

Laurent Pinchart