From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDF83358B9 for ; Thu, 9 Apr 2026 20:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775765704; cv=none; b=jQ4tyxE+hYjGSF+NL9H+2ZzxAKo+mWhNU6vRH5+RCAK8GJJ8MPU6r66/p86fdRWFKl5cIAbdqM4TXsHr3Tl0E70Rtai8f3GPSEGfnyS7ADAQQokciqht5Yk/HCuuocfUkbq0VpAIGDNFCBmEIepGbHODptFV9ZY1Ve+ILoIEYVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775765704; c=relaxed/simple; bh=ddClvMGa/BxgNQH7DbR6UVG2cXsKelF9gcPFAKQ4YJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KF0fvgXmemm61KcLkasvdj7jj7i1GhoAw2h0Dl/0IxytZBUGUeTxXFbVqL+efj0kTgsJEWnX4nq4rTSDUAfDk6VAuD9M9jetvv4ixHuThwAicfvTm+FRWJC852jcCRXunij2CwK9LDST7yqgu/N2xPL2ZOiOLN4GUQphHlQcurw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dHoznO7c; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dHoznO7c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775765703; x=1807301703; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ddClvMGa/BxgNQH7DbR6UVG2cXsKelF9gcPFAKQ4YJs=; b=dHoznO7cp3hFuTei/LjeE4YnrUCfV42Ms46Ty71QU9sPZyVQ+/u5yEQi wEAk+Iagnbm7jBQfiQlPfG6U6XwGz3+AmMnCWhzCJW1BmCYmebt5Od466 x77yYMJBiTSnOvzT6MJ2XhrUbxJD2iMHmuDquUP+kP+d+JYNu3cGXMT3e Yx33vld+ZwiqtOZTaQnyNqIw6p8ceW9xNH6gWkVrR4nOjm7XFR53ScmHG 8/K/EkhGJGOBb99H2xqqARAGSJm/BaLQpjAi94j4kH57rxV7H25SSMBD9 A9d40VYBEt5j0KMTNTCv+4gOXHwq8vybCu0vZKINgH6duF8r7BK2licqn Q==; X-CSE-ConnectionGUID: PfUobnUaR16IBS6YetvqDQ== X-CSE-MsgGUID: Y7pmriTRStWoLXkk5bZC4g== X-IronPort-AV: E=McAfee;i="6800,10657,11754"; a="87408517" X-IronPort-AV: E=Sophos;i="6.23,170,1770624000"; d="scan'208";a="87408517" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2026 13:15:02 -0700 X-CSE-ConnectionGUID: mjNh33RuR8yNBCcEb+5QsA== X-CSE-MsgGUID: CUcVix5WS2Khn/d3puC9rg== X-ExtLoop1: 1 Received: from dalessan-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.29]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2026 13:14:56 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 15365121CFD; Thu, 09 Apr 2026 23:15:03 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wAvmI-000000045oa-2IEF; Thu, 09 Apr 2026 23:15:02 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: [PATCH v12 59/86] media: imx219: Report streams using frame descriptors Date: Thu, 9 Apr 2026 23:14:34 +0300 Message-ID: <20260409201501.975242-60-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260409201501.975242-1-sakari.ailus@linux.intel.com> References: <20260409201501.975242-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Laurent Pinchart Implement the .get_frame_desc() subdev operation to report information about streams to the connected CSI-2 receiver. This is required to let the CSI-2 receiver driver know about virtual channels and data types for each stream. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus --- drivers/media/i2c/imx219.c | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index e79b26268415..d695987839e4 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -23,6 +23,7 @@ #include #include +#include #include #include #include @@ -669,6 +670,24 @@ static void imx219_free_controls(struct imx219 *imx219) * Subdev operations */ +static unsigned int imx219_format_bpp(u32 code) +{ + switch (code) { + case MEDIA_BUS_FMT_SRGGB8_1X8: + case MEDIA_BUS_FMT_SGRBG8_1X8: + case MEDIA_BUS_FMT_SGBRG8_1X8: + case MEDIA_BUS_FMT_SBGGR8_1X8: + return 8; + + case MEDIA_BUS_FMT_SRGGB10_1X10: + case MEDIA_BUS_FMT_SGRBG10_1X10: + case MEDIA_BUS_FMT_SGBRG10_1X10: + case MEDIA_BUS_FMT_SBGGR10_1X10: + default: + return 10; + } +} + static int imx219_set_framefmt(struct imx219 *imx219, struct v4l2_subdev_state *state) { @@ -1046,6 +1065,34 @@ static int imx219_get_selection(struct v4l2_subdev *sd, } } +static int imx219_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_mbus_frame_desc *fd) +{ + const struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u32 code; + + if (pad != IMX219_PAD_SOURCE) + return -EINVAL; + + state = v4l2_subdev_lock_and_get_active_state(sd); + fmt = v4l2_subdev_state_get_format(state, IMX219_PAD_SOURCE, + IMX219_STREAM_IMAGE); + code = fmt->code; + v4l2_subdev_unlock_state(state); + + fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2; + fd->num_entries = 1; + + fd->entry[0].pixelcode = code; + fd->entry[0].stream = IMX219_STREAM_IMAGE; + fd->entry[0].bus.csi2.vc = 0; + fd->entry[0].bus.csi2.dt = imx219_format_bpp(code) == 8 ? + MIPI_CSI2_DT_RAW8 : MIPI_CSI2_DT_RAW10; + + return 0; +} + static int imx219_init_state(struct v4l2_subdev *sd, struct v4l2_subdev_state *state) { @@ -1117,6 +1164,7 @@ static const struct v4l2_subdev_pad_ops imx219_pad_ops = { .set_fmt = imx219_set_pad_format, .get_selection = imx219_get_selection, .enum_frame_size = imx219_enum_frame_size, + .get_frame_desc = imx219_get_frame_desc, .enable_streams = imx219_enable_streams, .disable_streams = imx219_disable_streams, }; -- 2.47.3