From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0083E2770 for ; Wed, 15 Apr 2026 15:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776267952; cv=none; b=E+xtwiljb0ymGYcuyJ4zi7jIKZpfvq2En+8CcFmwIMZfXIIm7pttlVv/XufoxHd95vTqmVQGW7SptwEOdhtA9hDkXvA7NEx5wKFI1OzRaThVDJ6Q/fpFidXs0ilsGhvZLKOW0IEGPp9XhvCvFWBHYk1N/seVlvY8q7s62r+ohIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776267952; c=relaxed/simple; bh=gh7C2dUIZG4hFmy7cefMS/4bTu2pI3aYjrPn6rlC3xE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nRAidcMvtl89JAwAECi6bPA5PhjRBH55jpD+NmLlZCr1IhHaP5UzEFdsJNi7ctVQsQwG85ZFLxJBcLMqcEp4ZuSxRBdhQnINtrdodInlcfR/FzTGnvAqXEBuFAj2YmnqAFxYu9twzTknrJeVgOyEPQOxaU23y2hcqT86itjlcy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lL3gIjWB; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lL3gIjWB" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82d0b68837aso3797954b3a.2 for ; Wed, 15 Apr 2026 08:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776267951; x=1776872751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TnIFZObf5ErHGAi6LOPmajn+8u0D4ZmRXDoAcGE05pE=; b=lL3gIjWBeTBIX8TUGQVxde2jhgDTUpaf4MFozRqkyLw+KlwQUwhtugkpqln+ZHXzb0 pgPrdUYyF1KQdQ7chAMkIfA4cWid1L5V+nax/GEzAt8ZLl6e3mGiQ2KchPekhfbTh2ww fWFyIQusrnZxdkAOHvdhGYupPweWN96JT3gZ3ZGPn5HRMVZpFevjDDE05hj45Yg8mBNI aMns8yQmHY98n+xU0zY2MZG2LmdAUNgF+brDbSWhDp/73gdYWs97/fVW8qWKizPa2Q/8 8MZOtZxPE051JrpGc30lgb0mKnU7dW+gp5zoMwQiPkiTD5bdlGgDhorBhy34nQvm47eJ Ahyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776267951; x=1776872751; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TnIFZObf5ErHGAi6LOPmajn+8u0D4ZmRXDoAcGE05pE=; b=rVy6TWT9mq+Uo5Vl1tB7IeXpE+ixCB6Y7zidE2CZiEb3vpH6SYzmM8L3Mh5un26tS1 l7+M7KOTlZmTsyv4P3esWJO38mGp+Juo4EeDWHfG6Lm4t2fLrhEWooSYlor3IGjxtZ2y HNsdGCiuCBNZjrFGKhpkKqAchYOnZYkDNXjE3SytHgpq3xV1oT8FwXbRaZ2iucUdECLf f7S57H6t6SG38LSwhFZ4lT92aLD0QVueQ6Uk45wvH5r1ijLQUZHNS4j1GnZtrTbpWVEI f3Y7/bxDCknPRd+yt+IPoDg5/F2HKo9inXAONvPrH2wtG0MQ/8+bBAxu9N1ltSJFZIBg l5wg== X-Forwarded-Encrypted: i=1; AFNElJ8mArtOxlY6oA+9ZB8xfFZXLLEsZo/P4RlO3D5940erN4e4HYI0tuO9+TUiEVG3K0IgyF+VcSpzi22t3Q==@vger.kernel.org X-Gm-Message-State: AOJu0YzU+PIxMXbZ02vdO/yJkWLHLf1anZ/B5ktVNinD5R67wSSXd3u0 ODlfxASfNNlPICZ6dIXdRAVEgvi/CdM04UiEKfF5MyNFRfyTL3+X28OW X-Gm-Gg: AeBDietN19c906UCBCI0me2FYe/OZODMT2e0e9JgApdmSuP5xILlXZqivK3FwkSBlqP 9Jui9vEnD7JEhkVp1UMVOaOKTIyMeTjOt2xDcbH7hXWGTXJqMLKDho0WnTV5mVNxB7TPkAjB2AS n81cq+Y2mYwpc0ztUqctq3vxBtC0L9hFcme19vyf1tg96i6rPVlMq4lnJB/UWoFZ5f6IqAkrxAH Of7e24+3opG79WrMKuoSZnSAYMjVyJ2gs5y0qMBZIVA4HGramMANdLOGWoyCkx7ykcwr0+Fnrl8 9g4X4ha4/EhRGpEylj1VfAY0YSzuUnPbVd9OTfVSaRKM4J41gfa6AO75P5nCK7gN+LjVcJ2PYL8 qSSCyT5AfF94LwKetZvbggX9OVDq7ekxybz5Wjvq7tQeswquF6kEiEmoAuydwRMnHKNOlUG2ae6 w4NqoGiS93Oocs2Qo3LbCLVK8weZ2jnWVG X-Received: by 2002:a05:6a00:1ad3:b0:82f:6be8:6c0e with SMTP id d2e1a72fcca58-82f6be878e3mr2380350b3a.45.1776267950573; Wed, 15 Apr 2026 08:45:50 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f67476a5fsm2506233b3a.60.2026.04.15.08.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 08:45:49 -0700 (PDT) From: Guangshuo Li To: Shuah Khan , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Dafna Hirschfeld , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] media: vimc: fix reference leak on failed device registration Date: Wed, 15 Apr 2026 23:45:37 +0800 Message-ID: <20260415154537.3451732-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When platform_device_register() fails in vimc_init(), the embedded struct device in vimc_pdev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: vimc_init() -> platform_device_register(&vimc_pdev) -> device_initialize(&vimc_pdev.dev) -> setup_pdev_dma_masks(&vimc_pdev) -> platform_device_add(&vimc_pdev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 4babf057c143f ("media: vimc: allocate vimc_device dynamically") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/media/test-drivers/vimc/vimc-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c index 15167e127461..fee0c7a09c4f 100644 --- a/drivers/media/test-drivers/vimc/vimc-core.c +++ b/drivers/media/test-drivers/vimc/vimc-core.c @@ -421,6 +421,7 @@ static int __init vimc_init(void) if (ret) { dev_err(&vimc_pdev.dev, "platform device registration failed (err=%d)\n", ret); + platform_device_put(&vimc_pdev); return ret; } -- 2.43.0