From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D766D330D36 for ; Thu, 16 Apr 2026 14:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776349635; cv=none; b=eqOEdunj2hEg2aO8BAKuH0AgAgobDGEGvzmB0GXHBKmtaE3GyOFDrAQ7uo784DtClHMegxOZH/bW/TsDJkYxERUQo7XmLXr8TtDofiKc5hnKtp5+/j5LTHFV49wtGqYDjOhNK8f8Gnsq/D6P3pR6sYXRl4f2ton393Nug1KinBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776349635; c=relaxed/simple; bh=ETiTD68f2xAAia62znH3/fzc0EXdjrJI68nQeKopA5M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mj2cnM+TSXisVarnjcpX+91p56z/VLJ7zCgKcmFSR47vGN9pyIRMyScnJ9cq0RY/cZkngunYtV3nihaNn30TBPv5E+wCZolyzRqBzyMu2tAVG5fMw4JZODf2RyyidsVLkVmfybgqf9nctxz99RV370e1e1xmoz4q6/OOAlIaz6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=vdFh9Sx8; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vdFh9Sx8" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6EE04132; Thu, 16 Apr 2026 16:25:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776349538; bh=ETiTD68f2xAAia62znH3/fzc0EXdjrJI68nQeKopA5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vdFh9Sx8oKcTxacn+dfFEZVBEAzE1BnwKQxZuVoaAXmBsVe9immn/iMG0oKkgE9yo 91az3UV00tvmgUZUVoVtFpUEHsGc2YS/ucQHS/HkRkEDg1lpeRp/6FQsHhaEVMfN8f kkgBlpICw2xumRa7BR8rlj47YIGk800auBhYQy4w= Date: Thu, 16 Apr 2026 17:27:11 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 09/29] media: imx334: Remove redundant kernel-doc comments Message-ID: <20260416142711.GG1775831@killaraus.ideasonboard.com> References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-10-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408153939.969381-10-sakari.ailus@linux.intel.com> On Wed, Apr 08, 2026 at 06:39:18PM +0300, Sakari Ailus wrote: > Remove kernel-doc comments from regular callback functions. These comments > have no information value. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/imx334.c | 93 -------------------------------------- > 1 file changed, 93 deletions(-) > > diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c > index 9654f9268056..553a16b84f4d 100644 > --- a/drivers/media/i2c/imx334.c > +++ b/drivers/media/i2c/imx334.c > @@ -566,18 +566,6 @@ static int imx334_update_exp_gain(struct imx334 *imx334, u32 exposure, u32 gain) > return ret; > } > > -/** > - * imx334_set_ctrl() - Set subdevice control > - * @ctrl: pointer to v4l2_ctrl structure > - * > - * Supported controls: > - * - V4L2_CID_VBLANK > - * - cluster controls: > - * - V4L2_CID_ANALOGUE_GAIN > - * - V4L2_CID_EXPOSURE > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_set_ctrl(struct v4l2_ctrl *ctrl) > { > struct imx334 *imx334 = > @@ -678,14 +666,6 @@ static int imx334_get_format_code(struct imx334 *imx334, u32 code) > return imx334_mbus_codes[0]; > } > > -/** > - * imx334_enum_mbus_code() - Enumerate V4L2 sub-device mbus codes > - * @sd: pointer to imx334 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device state > - * @code: V4L2 sub-device code enumeration need to be filled > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_enum_mbus_code(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_mbus_code_enum *code) > @@ -698,14 +678,6 @@ static int imx334_enum_mbus_code(struct v4l2_subdev *sd, > return 0; > } > > -/** > - * imx334_enum_frame_size() - Enumerate V4L2 sub-device frame sizes > - * @sd: pointer to imx334 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device state > - * @fsize: V4L2 sub-device size enumeration need to be filled > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_enum_frame_size(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_frame_size_enum *fsize) > @@ -749,14 +721,6 @@ static void imx334_fill_pad_format(struct imx334 *imx334, > fmt->format.xfer_func = V4L2_XFER_FUNC_NONE; > } > > -/** > - * imx334_get_pad_format() - Get subdevice pad format > - * @sd: pointer to imx334 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device state > - * @fmt: V4L2 sub-device format need to be set > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_get_pad_format(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *fmt) > @@ -776,14 +740,6 @@ static int imx334_get_pad_format(struct v4l2_subdev *sd, > return 0; > } > > -/** > - * imx334_set_pad_format() - Set subdevice pad format > - * @sd: pointer to imx334 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device state > - * @fmt: V4L2 sub-device format need to be set > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_set_pad_format(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *fmt) > @@ -815,13 +771,6 @@ static int imx334_set_pad_format(struct v4l2_subdev *sd, > return ret; > } > > -/** > - * imx334_init_state() - Initialize sub-device state > - * @sd: pointer to imx334 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device state > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_init_state(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state) > { > @@ -856,15 +805,6 @@ static int imx334_set_framefmt(struct imx334 *imx334) > return -EINVAL; > } > > -/** > - * imx334_enable_streams() - Enable specified streams for the sensor > - * @sd: pointer to the V4L2 subdevice > - * @state: pointer to the subdevice state > - * @pad: pad number for which streams are enabled > - * @streams_mask: bitmask specifying the streams to enable > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_enable_streams(struct v4l2_subdev *sd, > struct v4l2_subdev_state *state, u32 pad, > u64 streams_mask) > @@ -929,15 +869,6 @@ static int imx334_enable_streams(struct v4l2_subdev *sd, > return ret; > } > > -/** > - * imx334_disable_streams() - Enable specified streams for the sensor > - * @sd: pointer to the V4L2 subdevice > - * @state: pointer to the subdevice state > - * @pad: pad number for which streams are disabled > - * @streams_mask: bitmask specifying the streams to disable > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_disable_streams(struct v4l2_subdev *sd, > struct v4l2_subdev_state *state, u32 pad, > u64 streams_mask) > @@ -1067,12 +998,6 @@ static const struct v4l2_subdev_internal_ops imx334_internal_ops = { > .init_state = imx334_init_state, > }; > > -/** > - * imx334_power_on() - Sensor power on sequence > - * @dev: pointer to i2c device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_power_on(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > @@ -1101,12 +1026,6 @@ static int imx334_power_on(struct device *dev) > return ret; > } > > -/** > - * imx334_power_off() - Sensor power off sequence > - * @dev: pointer to i2c device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_power_off(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > @@ -1206,12 +1125,6 @@ static int imx334_init_controls(struct imx334 *imx334) > return 0; > } > > -/** > - * imx334_probe() - I2C client device binding > - * @client: pointer to i2c client device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx334_probe(struct i2c_client *client) > { > struct imx334 *imx334; > @@ -1311,12 +1224,6 @@ static int imx334_probe(struct i2c_client *client) > return ret; > } > > -/** > - * imx334_remove() - I2C client device unbinding > - * @client: pointer to I2C client device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static void imx334_remove(struct i2c_client *client) > { > struct v4l2_subdev *sd = i2c_get_clientdata(client); -- Regards, Laurent Pinchart