From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4249C3DEFE6 for ; Thu, 16 Apr 2026 14:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776349668; cv=none; b=e3j8lD+EbgMoHx+6AMj9FDqUeGHwzQN6+vpq/ll/yzjHUxFiXszf1LQ7lAoRusDqy7n8bFMi2oFd/SoWYQ26t06AHRKylXHROmHuqgSMfBaqkF1sh9AR4Z4shWTfS7gm4gx78kqolgdHWx+hHl9Has/7E6j6xCNATVAQ5kGiRMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776349668; c=relaxed/simple; bh=aSZkr1QpCgEBOC6GO7aD4jznEwUa5hfkbp6K8c+o1AA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TM+CatIJ4LfZtolbja0eBUsvlrVCC9cU/IxoUjLVP8Nn2Oycmz1UAdDWBPT1ddiIV/fjDiy65SRlmBdRQ3NN6s8jBCrazGGV1C9dQMzjmC7PUNOCNV5BxJ1vLm9egeIh76dhtH3LjVMlQm0bznbB/3JLOXNvTIrtd2cCQiIzW1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=f0CfC+Gz; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="f0CfC+Gz" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id F1125132; Thu, 16 Apr 2026 16:26:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776349571; bh=aSZkr1QpCgEBOC6GO7aD4jznEwUa5hfkbp6K8c+o1AA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f0CfC+Gzyf8Xlh820GDPufVkT50cyTBIEMPHWI8KmS3zU5csGiLRdevwLRZ/qibK8 /23F4iwG3xrEmyarKyjylqiLXPx2hAGJuytc1bFhTCj5sMmHcmEzifxnXKCtQBxTTl w283VwqHY1pYDtDjkHYBJE1WFktxzu1ZTuyL5ZRM= Date: Thu, 16 Apr 2026 17:27:43 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 10/29] media: imx335: Remove redundant kernel-doc comments Message-ID: <20260416142743.GH1775831@killaraus.ideasonboard.com> References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-11-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408153939.969381-11-sakari.ailus@linux.intel.com> On Wed, Apr 08, 2026 at 06:39:19PM +0300, Sakari Ailus wrote: > Remove kernel-doc comments from regular callback functions. These comments > have no information value. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/imx335.c | 87 -------------------------------------- > 1 file changed, 87 deletions(-) > > diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c > index 5790aa4fabeb..1f777a1a8192 100644 > --- a/drivers/media/i2c/imx335.c > +++ b/drivers/media/i2c/imx335.c > @@ -698,18 +698,6 @@ static int imx335_update_test_pattern(struct imx335 *imx335, u32 pattern_index) > return ret; > } > > -/** > - * imx335_set_ctrl() - Set subdevice control > - * @ctrl: pointer to v4l2_ctrl structure > - * > - * Supported controls: > - * - V4L2_CID_VBLANK > - * - cluster controls: > - * - V4L2_CID_ANALOGUE_GAIN > - * - V4L2_CID_EXPOSURE > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_set_ctrl(struct v4l2_ctrl *ctrl) > { > struct imx335 *imx335 = > @@ -800,14 +788,6 @@ static int imx335_get_format_code(struct imx335 *imx335, u32 code) > return imx335_mbus_codes[0]; > } > > -/** > - * imx335_enum_mbus_code() - Enumerate V4L2 sub-device mbus codes > - * @sd: pointer to imx335 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @code: V4L2 sub-device code enumeration need to be filled > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_enum_mbus_code(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_mbus_code_enum *code) > @@ -820,14 +800,6 @@ static int imx335_enum_mbus_code(struct v4l2_subdev *sd, > return 0; > } > > -/** > - * imx335_enum_frame_size() - Enumerate V4L2 sub-device frame sizes > - * @sd: pointer to imx335 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @fsize: V4L2 sub-device size enumeration need to be filled > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_enum_frame_size(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_frame_size_enum *fsize) > @@ -871,14 +843,6 @@ static void imx335_fill_pad_format(struct imx335 *imx335, > fmt->format.xfer_func = V4L2_XFER_FUNC_NONE; > } > > -/** > - * imx335_set_pad_format() - Set subdevice pad format > - * @sd: pointer to imx335 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @fmt: V4L2 sub-device format need to be set > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_set_pad_format(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *fmt) > @@ -923,13 +887,6 @@ static int imx335_set_pad_format(struct v4l2_subdev *sd, > return ret; > } > > -/** > - * imx335_init_state() - Initialize sub-device state > - * @sd: pointer to imx335 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_init_state(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state) > { > @@ -947,14 +904,6 @@ static int imx335_init_state(struct v4l2_subdev *sd, > return imx335_set_pad_format(sd, sd_state, &fmt); > } > > -/** > - * imx335_get_selection() - Selection API > - * @sd: pointer to imx335 V4L2 sub-device structure > - * @sd_state: V4L2 sub-device configuration > - * @sel: V4L2 selection info > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_get_selection(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_selection *sel) > @@ -1011,15 +960,6 @@ static int imx335_set_framefmt(struct imx335 *imx335) > return ret; > } > > -/** > - * imx335_enable_streams() - Enable sensor streams > - * @sd: V4L2 subdevice > - * @state: V4L2 subdevice state > - * @pad: The pad to enable > - * @streams_mask: Bitmask of streams to enable > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_enable_streams(struct v4l2_subdev *sd, > struct v4l2_subdev_state *state, u32 pad, > u64 streams_mask) > @@ -1097,15 +1037,6 @@ static int imx335_enable_streams(struct v4l2_subdev *sd, > return ret; > } > > -/** > - * imx335_disable_streams() - Disable sensor streams > - * @sd: V4L2 subdevice > - * @state: V4L2 subdevice state > - * @pad: The pad to disable > - * @streams_mask: Bitmask of streams to disable > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_disable_streams(struct v4l2_subdev *sd, > struct v4l2_subdev_state *state, u32 pad, > u64 streams_mask) > @@ -1299,12 +1230,6 @@ static int imx335_power_on(struct device *dev) > return ret; > } > > -/** > - * imx335_power_off() - Sensor power off sequence > - * @dev: pointer to i2c device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_power_off(struct device *dev) > { > struct v4l2_subdev *sd = dev_get_drvdata(dev); > @@ -1430,12 +1355,6 @@ static int imx335_init_controls(struct imx335 *imx335) > return 0; > } > > -/** > - * imx335_probe() - I2C client device binding > - * @client: pointer to i2c client device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static int imx335_probe(struct i2c_client *client) > { > struct imx335 *imx335; > @@ -1530,12 +1449,6 @@ static int imx335_probe(struct i2c_client *client) > return ret; > } > > -/** > - * imx335_remove() - I2C client device unbinding > - * @client: pointer to I2C client device > - * > - * Return: 0 if successful, error code otherwise. > - */ > static void imx335_remove(struct i2c_client *client) > { > struct v4l2_subdev *sd = i2c_get_clientdata(client); -- Regards, Laurent Pinchart