From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D6122A1D4 for ; Thu, 16 Apr 2026 15:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776352017; cv=none; b=m3w5g+wQ/d/+jf7SPTqcXkAcNx15R5epZGNe0sAi5u03+zcLZlknJrJaHwZIY9oTfi5vX7ujjvIfHE9QnrSwd4dSjZkFhqki8b28e/mtBuJUVWe8ozeY3qm3JXq+gXrk/klVymw3o+L24DM/QSlw8DqJXoAJETcHkYcOh6M7ji4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776352017; c=relaxed/simple; bh=6gdARcIuxE97CTNC0q/HieR2Yl5Nanl+XbJTdnkR3vg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JMMDOfnbRyiztH1YUVhI/xrgEAeX++heptvIovOOTInfZGnCezHe8P0EVWNLYr8rF9bhmuURg+c4YxUXR8vFMvWiReSuf8OuzrbDW/P7JG/talmGIk35kh882jCWXz6+f5ifQDRgckN8lTlibHUT/Vn4FrbF6CcSSeViYlqkh1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=bU6BLyoo; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bU6BLyoo" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A97A5107; Thu, 16 Apr 2026 17:05:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776351918; bh=6gdARcIuxE97CTNC0q/HieR2Yl5Nanl+XbJTdnkR3vg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bU6BLyooPKd6q7y6pAFBdaFqXteh7duuuk1NRQhWlzr5LcG6CM0snjcU1KFPXMysM 1U++FzVNgcvHaEirLKkC5UYuBLoNS6QyNXckPnoIYX6T7Ns4n8xS+cCt+L7ZP9W+jj kfmLOxjzxQXaR6KzrjzuktsZIIR115V5bLPzhlCc= Date: Thu, 16 Apr 2026 18:06:51 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 17/29] media: v4l2-subdev: Allow accessing routes with STREAMS client capability Message-ID: <20260416150651.GO1775831@killaraus.ideasonboard.com> References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-18-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408153939.969381-18-sakari.ailus@linux.intel.com> On Wed, Apr 08, 2026 at 06:39:26PM +0300, Sakari Ailus wrote: > Disable access to routes when the STREAMS client capability bit isn't set. > Routes aren't relevant otherwise anyway. > > Signed-off-by: Sakari Ailus > Reviewed-by: Jacopo Mondi > Reviewed-by: Mirela Rabulea > Reviewed-by: Michael Riesch Reviewed-by: Laurent Pinchart > --- > drivers/media/v4l2-core/v4l2-subdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > index f8fde395a53a..647587c0499a 100644 > --- a/drivers/media/v4l2-core/v4l2-subdev.c > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > @@ -1020,6 +1020,9 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg, > if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) > return -ENOIOCTLCMD; > > + if (!client_supports_streams) > + return -EINVAL; > + > memset(routing->reserved, 0, sizeof(routing->reserved)); > > copy_routes_state_to_routing(routing, state); > @@ -1041,6 +1044,9 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg, > if (!(sd->flags & V4L2_SUBDEV_FL_STREAMS)) > return -ENOIOCTLCMD; > > + if (!client_supports_streams) > + return -EINVAL; > + > if (routing->which != V4L2_SUBDEV_FORMAT_TRY && ro_subdev) > return -EPERM; > -- Regards, Laurent Pinchart