From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0395619D093 for ; Thu, 16 Apr 2026 15:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776354561; cv=none; b=GuyMyd0VptrdnTmIP0BYjWmhwJ334gYUulTHNaRuvTMynrW04uq1mSoDcNuokNE1AbqPrH1g+mCnmVgfsoQtze+5IZs+fM/meUZgd5O/+CkNOwQcqULUVaCCwtJh0/VzblAXUTNeDYF4O1nf6mVKqLjtQlXRfMwN0yu0AHQtJHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776354561; c=relaxed/simple; bh=zPhftcwFY85Mwl9OokxsyOXxy6xqqEuZ/YAXM6qe31c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mcvP9IE26zlX3o5zWrzbXu7WnK3ZON7cXawJ9tPWNYp/wOmF1AhWqyENlgdDHTV9L6bT01vonaFTTrJdM6SZYqvW16RqRFK9l+mOupXX+G+l6N5B/SjIWlWVquVLETuOPXe5NE/kRhdaagt8eRY+TjfiZB5cgjw24MY5wshZwSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=YqBiD8Uk; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YqBiD8Uk" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3CD81107; Thu, 16 Apr 2026 17:47:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776354462; bh=zPhftcwFY85Mwl9OokxsyOXxy6xqqEuZ/YAXM6qe31c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YqBiD8UkeroRhSBS7aZabDUjRDWulfbZjvONgqfVAbLFuoPbiTpsIFsyrbCkzV6JZ ytvOi4CCA2uMXsc+/QkJvvxBzDDo244qTms19JhS6KtyUU8KrGAYxZupb9wkL3Vq2z XlRgBesXYIqrvgg4QBGd5inXXBFFs2HR8WS5/FBM= Date: Thu, 16 Apr 2026 18:49:14 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 23/29] media: Improve enable_streams and disable_streams documentation Message-ID: <20260416154914.GA1823068@killaraus.ideasonboard.com> References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-24-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408153939.969381-24-sakari.ailus@linux.intel.com> On Wed, Apr 08, 2026 at 06:39:32PM +0300, Sakari Ailus wrote: > Document that enable_streams may start additional streams and > disable_streams may not disable requested streams if other related streams > are still enabled. > > Signed-off-by: Sakari Ailus > Reviewed-by: Jacopo Mondi > Reviewed-by: Mirela Rabulea > --- > include/media/v4l2-subdev.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index d256b7ec8f84..4588992b4417 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -814,6 +814,10 @@ struct v4l2_subdev_state { > * V4L2_SUBDEV_CAP_STREAMS sub-device capability flag can ignore the mask > * argument. > * > + * Starting the requested streams may require starting additional > + * streams. Streams that are started together due to hardware are called a > + * stream group. > + * > * @disable_streams: Disable the streams defined in streams_mask on the given > * source pad. Subdevs that implement this operation must use the active > * state management provided by the subdev core (enabled through a call to > @@ -823,6 +827,9 @@ struct v4l2_subdev_state { > * Drivers that support only a single stream without setting the > * V4L2_SUBDEV_CAP_STREAMS sub-device capability flag can ignore the mask > * argument. > + * > + * A stream group is disabled when one or more streams in the stream > + * group are disabled. This contradicts the commit message. Did you mean that a stream group will be disabled when all the streams it contains are disabled ? > */ > struct v4l2_subdev_pad_ops { > int (*enum_mbus_code)(struct v4l2_subdev *sd, -- Regards, Laurent Pinchart