Re: [PATCH v4 21/29] media: mc: Don't care about unsettable flags in MEDIA_IOC_LINK_SETUP

Sakari Ailus
2026-05-05T06:51:13Z

Hi Hans,

On Tue, May 05, 2026 at 08:36:44AM +0200, Hans Verkuil wrote:
> On 08/04/2026 17:39, Sakari Ailus wrote:
> > The implementation of MEDIA_IOC_LINK_SETUP currently requires that all
> > flags that are set by the driver are correctly set as the driver expects.
> > This poses a problem for adding new flags as programs could not work with
> > links that have unknown flags even when the use of these flags wouldn't
> > affect the program.
> >
> > Ignore the non-settable link flags.
>
> Doesn't this require an uAPI documentation change as well, clarifying how
> flags are handled?

The handling of the flags could (and should) well be documented in UAPI
documentation but the current documentation is vague. It doesn't say the
user needs to set also the non-settable flags.

I'll add a patch for this.

--
Regards,

Sakari Ailus