From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E1CB2DEA68 for ; Tue, 21 Apr 2026 16:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776787947; cv=none; b=JSAOtITXyA0WRHkfraSKdukYiZK5OweVHyJ3JhB33e9vAYvXqdnasgW3TuuC6cVa/iaN75swu5SPfS5EDU0g+dr2S75/W1mu/DJyXgJy6eO0I8peqNG9C/0tH/jeuY3+Bd3EQ97NlErvxqT0y1JjKm0l4qiru3Ch0EeSmJBWqF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776787947; c=relaxed/simple; bh=nZ/4SK5gNBZvIzhgoaRV+l8KxVSUKBiRiN+Eu8d5+nI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RtjCzTDIOEM6DFndWPnY2+vgHrn3Y+J6GU77JAjHTzUzdbjzzNThO9DAc6v6NqzftnXeQmHYZIZJm4M9Vmz5LLwNiN/RHi4Z0if0ti7+LHRRMfB24xVao+RxXx6VEItufHlUD/ZkQfHBe+sgZqYGDi4QaylNxJjrBn0V1XCxBgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=VdypU76m; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VdypU76m" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 602075B2; Tue, 21 Apr 2026 18:10:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1776787844; bh=nZ/4SK5gNBZvIzhgoaRV+l8KxVSUKBiRiN+Eu8d5+nI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VdypU76mdeu8knWsDsumu6KE/JosZBlo7e9akg8t88AXsO3ttxXnQfkDbfdpWr9C3 3f64cGfRqyzY2piun0sr9lCKYDVPyf+f721D3PRf8Y6fJ6EqrurYhjjE6fktk4TE0+ VYUxzS4LwCkEAZNqHwYzZCCF3aWlLXFodgmHoDCY= Date: Tue, 21 Apr 2026 19:12:20 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Dave Stevenson , Tommaso Merciai , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen , David Plowman , "Yu, Ong Hock" , "Ng, Khai Wen" , Jai Luthra , Rishikesh Donadkar Subject: Re: [PATCH v4 27/29] media: v4l2-subdev: Add v4l2_subdev_call_ci_active_state Message-ID: <20260421161220.GC2360857@killaraus.ideasonboard.com> References: <20260408153939.969381-1-sakari.ailus@linux.intel.com> <20260408153939.969381-28-sakari.ailus@linux.intel.com> <20260416173821.GA1824072@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Apr 21, 2026 at 07:04:26PM +0300, Sakari Ailus wrote: > On Thu, Apr 16, 2026 at 08:38:21PM +0300, Laurent Pinchart wrote: > > On Wed, Apr 08, 2026 at 06:39:36PM +0300, Sakari Ailus wrote: > > > Add v4l2_subdev_call_ci_active_state(), to call sub-device pad ops that > > > take struct v4l2_subdev_client_info pointer as an argument. > > > > If we drop the client info parameter from .get_fmt(), the only driver > > calling this new macro will be > > drivers/media/platform/ti/cal/cal-video.c. I would just pass NULL > > explicitly there and drop this patch. > > That'd make the arguments for set_fmt and get_fmt different. I'm not sure > if that'd be a problem in practice, perhaps not. All drivers should eventually implement .get_fmt() using the v4l2_subdev_get_fmt() helper. There should be no need for client info there. > I could imagine in the end we'll need to include the client flags in more > callbacks than set_fmt(). It might not be a bad idea to add them to all pad > ops. Of course we could revisit this later when needed. We should really minimize addition of new client caps flags, and really, really try to implement them all in the subdev core. -- Regards, Laurent Pinchart