From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Subject: [PATCH 2/7] media: qcom: iris: fix state-change debug log printing stale value
Date: Wed, 22 Apr 2026 16:46:35 +0530 [thread overview]
Message-ID: <20260422-iris-code-improvement-v1-2-8e150482212d@oss.qualcomm.com> (raw)
In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com>
The state‑change debug log in iris_inst_change_state() always prints the
same value for the old and new state, rendering it useless for
debugging. This happens because the state is updated before the log is
emitted.
Log the transition before updating the state so the previous value is
preserved, consistent with the existing sub‑state handling.
Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops")
Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
---
drivers/media/platform/qcom/iris/iris_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c
index d14472414750dc7edc4834f32a51f2c5adc3762e..e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8 100644
--- a/drivers/media/platform/qcom/iris/iris_state.c
+++ b/drivers/media/platform/qcom/iris/iris_state.c
@@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst,
return -EINVAL;
change_state:
- inst->state = request_state;
dev_dbg(inst->core->dev, "state changed from %x to %x\n",
inst->state, request_state);
+ inst->state = request_state;
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2026-04-22 11:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 11:16 [PATCH 0/7] media: qcom: iris: miscellaneous code-quality fixes Dikshita Agarwal
2026-04-22 11:16 ` [PATCH 1/7] media: qcom: iris: Centralize internal buffer table selection Dikshita Agarwal
2026-04-23 9:17 ` Bryan O'Donoghue
2026-04-22 11:16 ` Dikshita Agarwal [this message]
2026-04-22 12:20 ` [PATCH 2/7] media: qcom: iris: fix state-change debug log printing stale value Konrad Dybcio
2026-04-23 9:18 ` Bryan O'Donoghue
2026-04-22 11:16 ` [PATCH 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Dikshita Agarwal
2026-04-23 9:23 ` Bryan O'Donoghue
2026-04-22 11:16 ` [PATCH 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Dikshita Agarwal
2026-04-22 12:23 ` Konrad Dybcio
2026-04-23 5:09 ` Dikshita Agarwal
2026-04-23 9:25 ` Bryan O'Donoghue
2026-04-23 9:52 ` Dikshita Agarwal
2026-04-22 11:16 ` [PATCH 5/7] media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry Dikshita Agarwal
2026-04-22 12:25 ` Konrad Dybcio
2026-04-22 11:16 ` [PATCH 6/7] media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() Dikshita Agarwal
2026-04-22 12:25 ` Konrad Dybcio
2026-04-23 9:32 ` Bryan O'Donoghue
2026-04-22 11:16 ` [PATCH 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void Dikshita Agarwal
2026-04-22 12:26 ` Konrad Dybcio
2026-04-22 12:26 ` Konrad Dybcio
2026-04-23 9:42 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422-iris-code-improvement-v1-2-8e150482212d@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=deepa.madivalara@oss.qualcomm.com \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox