From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC0E33CF693 for ; Wed, 22 Apr 2026 11:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856626; cv=none; b=Da1DytQE187cPENr4Zl3cNuXVxYaRrmwKjYc0RS5pfZALXL3Kd+kqLxO408sasIYgIxmhzcFDolA+8MNa2G8Hyvijm4JOXciDsocYbuamP0as7zlL7ypFNnQw/FvI6WpLZw/NioVMfEFGZ11vtCyoiOS2rhFd+3L77fYbe0fPO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856626; c=relaxed/simple; bh=Qy/Be5/4hsLlhF16qrlPI+nyPqg+3meE4d+jGR8bZvI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nD0gzI0kdhxpur6yWf8VEXYZyDbluz11s2jl+ScWP3B2ZkKZyMs7jUtA2ofDq8o/4ozyY9Slnbp/aUV3NermCJFXB3Un1qGympkbU0JP+/aRmBFrLu2/ikRkCEn3ld9toHvjQnzdBCf0lwyo9aJKWDTIUyTH+IGOz9/6StWkKEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=evK9AF27; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CDGbZC4R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="evK9AF27"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CDGbZC4R" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63MA9oHt2000978 for ; Wed, 22 Apr 2026 11:17:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8b4BYumIlUhTMjTFowWUiyeW6SXHWD9PMEUFmloo+xI=; b=evK9AF27Tk2AdAO0 f2E+GfslRDKFfqnvj3e8Zon3sXnPp0yAB20e9MVkg3xb1fy42rT7Exh5a+wFkdWw grx6ZwS7S4TObiAIjQCExqOemYRhWTuMGy/h3pysCt0zHqoPmgoQ1YT6RPBFyqhG FtGUGHQ6G8BlGIAXZIznb7rZTomARqnauVVQdKdvn4RDyjGrx18XAW78ZckgKwEF Xl/Zsqw3Tzb1CSh9SQm8/5lAEyhMjzu32awmSiGoQmPYtrthDC+2aW1JDrSs5YEH mMw8rQ63qqu+KGTsePERN+1ihOd24sWbWllw0uf4uH+1Nn51Lqr+/U3bjEu0Wx7q ILwIbQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenfb6pn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 11:17:04 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82fa6c3a77cso2735649b3a.3 for ; Wed, 22 Apr 2026 04:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776856624; x=1777461424; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8b4BYumIlUhTMjTFowWUiyeW6SXHWD9PMEUFmloo+xI=; b=CDGbZC4RmHGZIHLjAImr1tspJfbD+6wLZZU1lfbiFSlq4b+xWJ08G4z99M/0dJQ9lJ O2hcEbpTEkrWgsM3BMsmZszbu1oodvpc2+m4H9b/KaL/Y2Y47m6X+GHNRKYmCtmfbmwm 4WI+b09piPnR2JblO5s0EUM8+KG7d/asou8TYeyeZXhgm/jq8feRZTFXIjirr2OT0IVn SY7AM0ZG18iATMFHOw2ERjf1LyEJ5cqEvGnlBhIrJM7nSurzUFEp3UC8PfEQ8N4BnETa QMqvFsUNJDOJTcKR0BS3t5q8LEZ037hJ0CV41zrpSYZkl5Bcnh6XBi++dzvUNQTnxF/B G11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776856624; x=1777461424; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8b4BYumIlUhTMjTFowWUiyeW6SXHWD9PMEUFmloo+xI=; b=HTBSKONpPD6tGVRWcLaL7xjp3LeUJMLLkn6xhnUC/NfEYnenQqa4zkJUvbox6EbJAs d+yAcadLGrIwhgPKfmnXGGHD0IitZdVGMdPfGoJSdJRohfDuYvHNXeSIA6ajdOc6uhWh V4xjpAJ9Ij/IdS6/gCj+jQRf/ZBTmLj8GEMBLiB2XkjCFa5Mslap2vk4OhXw8AO4D2UE dLiCNFqHAi4TCa0fYcwjF5aluEci2skG/UEl6otpYzXZAqk9safHDraaY002z2RbEU7p +Ki88gfrHtk+ekgaKWnrdyV/qYhjxaktrdgT9iuYhqrlKnV+M+/BZyzp2slHOgWSWMAE xpvg== X-Gm-Message-State: AOJu0Yzh1QnlWzU/Her2HYO5xJ0z5DXSVmSPoyEXKCsC9gz7NIhMgRxo y7aYOtelqeQdZ4lgZcXhRLMoYYaflJ+YZU1uahWIJbLWnSmaLlsH1mLjHll3GovPdC23BYCBARj uBZic1mS30OnxEVFUnLbOydxcCrMqdQWu2uTY71Nyfnk5WrK+nt3E5Eo6d0/nwzCeEg== X-Gm-Gg: AeBDievd25bqTOCeTcZN8s0kpNFhyM3oqkFr1LoO/fpyM7cZjqVjGKsZFz7pe/yIijZ hYQ7GS2c2ahmOWIB5uo702nuzQEU7A1oCJ6/AFH2fTT7KXzrMBPqdzpFmrJbBzbF43YZFdX4AyL I9y+ygCMTGfvWkKR0Xpwl3p1QoKopY5jGT2+rC2V0aUY28rOAd5boBTXltJ9eo7Y24E51qFqFYb 9+A6wh2nqaMubGxORq0hF3nuxiugRUxPScytsBJnwGKHryzW5duDr5ZpbIbPRG2XCExCaUxx6IW mip9m9ZBuqJE0GuQ/ojQ6RSapJaryrab47WHTtJqTGYLbpzNaD4Zt7HmViLk2mR/H9db7KEreez LWy/lsrD7N/fFPvJJrkenHOPX39yPuE+bzLelwOnfb6dpL+ehcy9xoRd+wzEdfxmtT67ZDg== X-Received: by 2002:a05:6a00:b87:b0:827:441a:c970 with SMTP id d2e1a72fcca58-82f8c87e33amr21942489b3a.6.1776856623570; Wed, 22 Apr 2026 04:17:03 -0700 (PDT) X-Received: by 2002:a05:6a00:b87:b0:827:441a:c970 with SMTP id d2e1a72fcca58-82f8c87e33amr21942444b3a.6.1776856623065; Wed, 22 Apr 2026 04:17:03 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe901csm21100782b3a.48.2026.04.22.04.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 04:17:02 -0700 (PDT) From: Dikshita Agarwal Date: Wed, 22 Apr 2026 16:46:36 +0530 Subject: [PATCH 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260422-iris-code-improvement-v1-3-8e150482212d@oss.qualcomm.com> References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> In-Reply-To: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776856606; l=1180; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=Qy/Be5/4hsLlhF16qrlPI+nyPqg+3meE4d+jGR8bZvI=; b=jtm67hkpdalOgvSzH4iWBc24BA4VoODxqqL80IMpuBtOJuoHk/m36+f7OGigaor+2z76JHmEW pLTW4DHrlZ8AAZ/k6cD6npl8gKWiGTzz6UQb24JLe7nJcBPbSs/c5dH X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: nVEhrzl_o8cplJEHJeh4igzXz6fRW3pY X-Authority-Analysis: v=2.4 cv=fozsol4f c=1 sm=1 tr=0 ts=69e8ae30 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=et4WSneAAUjHYPCqp6wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEwOCBTYWx0ZWRfX8+ddQGqph2MN 8eY7yf5cz1ednH4okaDaFP0BY4N6R6MkTYl34fjCSVAzlV9NxkeTAfNAcjyNlW/ZsfkFP+K9P9h 2NNpmmI23fJZxQIYLVpGxg9VY0SxQKFg4UPy4j5zZGyt6AZwrcR/148i/bGptGYKiuR7Q5a+YmQ 5webY3TmXpf6YKto0d4eK7Nl/t04f+x7eAYRN4sE0hBbAEGr8Pj7/3OrzJSkLBsGTZetPZaNkmc axfPbHnt86iQmxN80J1eaS7/XrMmcrPHRKT4kEtvA+vp2mX/jFhz/YcONKWErnm1lQrMsX0pct3 nC7UiZBnWS/fO/4+DAw+pmm4f9lIZbqVIBMwhAd9ZfqyB5KWXKifyCUKW91veE172qtqHtD7rka 20NsKDEq7gSyzcCJ0d9EHSSrCQUcUMjIasUhXYfjRRtJJI1YFw7n/gvtNhMHNs9vMknZ/tcbJB4 Tdqk6OVc+6KKLeocchQ== X-Proofpoint-GUID: nVEhrzl_o8cplJEHJeh4igzXz6fRW3pY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220108 iris_allow_cmd() incorrectly tests a single sub‑state bit using a scalar comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index e991f34916ec6e74f3d2cf98bd61b8b1e12a3ca8..5552725c614ea2e336e254898270302fafa646c3 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd == V4L2_DEC_CMD_STOP || cmd == V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state != IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } -- 2.34.1